From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from flow-a7-smtp.messagingengine.com (flow-a7-smtp.messagingengine.com [103.168.172.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3118516DC28 for ; Wed, 10 Dec 2025 15:00:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.142 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765378847; cv=none; b=V79IngfV+1SEWyBTEJLoiKYPStjDIgX2SlJsVHq5BBiK+Z13IbYDcn6q7M93qKpNvxfLepZmfRrhv+/p8r+bsi7v75SksyvyKBR2NtoB5gqmqhvZaQhYPwncLzThjZhSfoTdsN/bpa4nzVLV25uazflUNY8rTAEgr8yFSPJBeqg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765378847; c=relaxed/simple; bh=J9VvfM7fI0BHx2bCZzoquzLFHD+JD8CtXxqU1e6de2Q=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=jGknAPEYa3ioJ/6yKtJUTqLfHIAMh4Vd0lUVJ9pw/SX0Sjm4VPN3wREzbxjmCsC4ptFMGOKvsPdiJE8x3eMHliHeRmumXo1SRacaXfEeTQbZnIIy9aAiqEsYsQklJQ81syTAw4/9amXz78YeIyfnGtM//BBeK1lQo8/onFyFgxo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de; spf=pass smtp.mailfrom=arndb.de; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b=DzshKmml; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=FFaeg9pD; arc=none smtp.client-ip=103.168.172.142 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arndb.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b="DzshKmml"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="FFaeg9pD" Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailflow.phl.internal (Postfix) with ESMTP id 1FF1E1380371; Wed, 10 Dec 2025 10:00:44 -0500 (EST) Received: from phl-imap-17 ([10.202.2.105]) by phl-compute-04.internal (MEProxy); Wed, 10 Dec 2025 10:00:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1765378844; x=1765386044; bh=3F9rY3jf//Lh0+TVIlNn2mQE5tkdRIgO4uaCG8qXxwI=; b= DzshKmmljMPyM50jQ9SVmMASZThstQGAviKNTwGGMubBeP6vTNpoZiFOnTDa+mbq QMK6UhvmVSzRW8N1dhWdh7oGbWI39vPUHgKyu8wtxD1GU8ywJd5419vg5gvvoA6w WJ6zp3/OEBRRt380augwsi2v5q4BtKvGjSQBzVx5R7BvpUCSRJA2WQ6M06vlSNWG vs0+yBcPzriBYwmrNAvspvF2qRxTsCfjKRqeNj4EriFDBiBYJewCCT/HQ+TGa40u 9kW+vCKIVrDykGb7WS7ndr1+t8qwLOj3zupJ/ne+EOMutXEUZEPkWYsFP/fZ5RGN jKLpHFPkzNKK/5oOvSIFWg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1765378844; x= 1765386044; bh=3F9rY3jf//Lh0+TVIlNn2mQE5tkdRIgO4uaCG8qXxwI=; b=F Faeg9pDGg1ojnzuso4MjEzDybQD+KL+e+olDujx3OnYvU9BU4kTqH04Na/U5wbF3 JHwqaHqrgHdlhl88wVoLNetC3vPn7IbRxKec/EJwN6+QJFhBTyrSvC849WSIkdl7 +r/3fe04NeU16iK47SQiGDmTwisWXL+QpaYX2fdYk6XpWaZfOzebsflsh5sfu4X2 moc5ItNt9TrgBOeLvJx/Ivm/d3diF76F9WJCQ0YyooJmNeyWZQxjjQ/d8CNnzyen XoscxqJB1hyCwektD6lQ32LTiJhdc3ZZNZLlDiFfVwenVLuiRifJFqkEqKIK/C9A sj18k8A5pV+0ET5DZkUsQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgddvvdejgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefoggffhffvvefkjghfufgtgfesthejredtredttdenucfhrhhomhepfdetrhhnugcu uegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrghtthgvrh hnpefhtdfhvddtfeehudekteeggffghfejgeegteefgffgvedugeduveelvdekhfdvieen ucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrrhhnug esrghrnhgusgdruggvpdhnsggprhgtphhtthhopedugedpmhhouggvpehsmhhtphhouhht pdhrtghpthhtohepmhgvsegsrhhighhhrghmtggrmhhpsggvlhhlrdgtohhmpdhrtghpth htohepughirghnuggvrhhssegthhhrohhmihhumhdrohhrghdprhgtphhtthhopehsihhm ohhnrgesfhhffihllhdrtghhpdhrtghpthhtoheprghirhhlihgvugesghhmrghilhdrtg homhdprhgtphhtthhopehjvghsshiihhgrnhdttddvgeesghhmrghilhdrtghomhdprhgt phhtthhopegrrhhnugeskhgvrhhnvghlrdhorhhgpdhrtghpthhtoheplhhinhhushifse hkvghrnhgvlhdrohhrghdprhgtphhtthhopehmrhhiphgrrhgusehkvghrnhgvlhdrohhr ghdprhgtphhtthhopehnvghilhdrrghrmhhsthhrohhngheslhhinhgrrhhordhorhhg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 2770CC40054; Wed, 10 Dec 2025 10:00:43 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ThreadId: AWQo6ABWGaON Date: Wed, 10 Dec 2025 16:00:22 +0100 From: "Arnd Bergmann" To: "Brigham Campbell" , "Arnd Bergmann" , "Linus Walleij" , "Neil Armstrong" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "Dave Airlie" , "Simona Vetter" , "Doug Anderson" Cc: "Jessica Zhang" , "Anusha Srivatsa" , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Message-Id: <2ac20c84-2544-408f-a29a-8ae88ef3969c@app.fastmail.com> In-Reply-To: References: <20251204094550.1030506-1-arnd@kernel.org> Subject: Re: [PATCH] drm/panel: novatek-nt35560: avoid on-stack device structure Content-Type: text/plain Content-Transfer-Encoding: 7bit On Wed, Dec 10, 2025, at 05:54, Brigham Campbell wrote: > On Thu Dec 4, 2025 at 2:45 AM MST, Arnd Bergmann wrote: >> Change this to a pointer as was liley intended here. > > Shoot, you're absolutely right that I didn't mean to create a copy of > the struct on the stack when I wrote that code. Thanks for the fix! I'll > try to be more careful with struct usage and the stack in the future. > > Can I ask how you got the build process to emit those warnings? I didn't > see it when I developed my patch. I'm doing randconfig tests to check a large number of possible configurations. I also have the CONFIG_FRAME_WARN logic replaced with lower configuration specific default to catch more regressions in this particular area. Arnd