mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Marco Scardovi <scardracs@disroot.org>
Cc: corentin.chary@gmail.com, denis.benato@linux.dev,
	 Hans de Goede <hansg@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	 luke@ljones.dev, platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] platform/x86: asus-armoury: add power limits quirk for G614FM
Date: Fri, 18 Sep 2026 20:06:12 +0300 (EEST)	[thread overview]
Message-ID: <2ac49a94-be85-1a2f-a43a-a376d2545a01@linux.intel.com> (raw)
In-Reply-To: <20260828065904.11355-1-scardracs@disroot.org>

On Fri, 28 Aug 2026, Marco Scardovi wrote:

> add power limits quirk entry for ASUS G614FM laptop.
> The limits are extracted from the device's ThrottleGear XML configuration.
> 
> Signed-off-by: Marco Scardovi <scardracs@disroot.org>
> ---
>  drivers/platform/x86/asus-armoury.h | 31 changes(+/-)
>  1 file changed, 31 insertions(+), 0 deletions(-)
> 
> --- a/drivers/platform/x86/asus-armoury.h
> +++ b/drivers/platform/x86/asus-armoury.h
> @@ -1056,6 +1056,37 @@
>  			.requires_fan_curve = true,
>  		},
>  	},
> +		{
> +			.matches = {
> +				DMI_EXACT_MATCH(DMI_BOARD_NAME, "G614FM"),

So far, this file has only used DMI_MATCH() ?

The entry seems to be in wrong place.

And indentation level is inconsistent as well.

> +			},
> +			.driver_data = &(struct power_data) {
> +				.ac_data = &(struct power_limits) {
> +					.nv_dynamic_boost_max = 15,
> +					.nv_dynamic_boost_min = 5,
> +					.nv_temp_target_max = 87,
> +					.nv_temp_target_min = 75,
> +					.ppt_pl1_spl_max = 120,
> +					.ppt_pl1_spl_min = 30,
> +					.ppt_pl2_sppt_def = 140,
> +					.ppt_pl2_sppt_max = 165,
> +					.ppt_pl2_sppt_min = 65,
> +					.ppt_pl3_fppt_def = 140,
> +					.ppt_pl3_fppt_max = 165,
> +					.ppt_pl3_fppt_min = 65,
> +				},
> +				.dc_data = &(struct power_limits) {
> +					.nv_temp_target_max = 87,
> +					.nv_temp_target_min = 75,
> +					.ppt_pl1_spl_max = 65,
> +					.ppt_pl1_spl_min = 25,
> +					.ppt_pl2_sppt_max = 65,
> +					.ppt_pl2_sppt_min = 25,
> +					.ppt_pl3_fppt_max = 75,
> +					.ppt_pl3_fppt_min = 35,
> +				},
> +		},
> +	},
>  	{
>  		.matches = {
>  			DMI_MATCH(DMI_BOARD_NAME, "GA401Q"),
> 

-- 
 i.


      reply	other threads:[~2026-09-18 17:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-28  6:59 Marco Scardovi
2026-09-18 17:06 ` Ilpo Järvinen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2ac49a94-be85-1a2f-a43a-a376d2545a01@linux.intel.com \
    --to=ilpo.jarvinen@linux.intel.com \
    --cc=corentin.chary@gmail.com \
    --cc=denis.benato@linux.dev \
    --cc=hansg@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luke@ljones.dev \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=scardracs@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®