Re: [PATCH v2 4/6] dt-bindings: power: rockchip: add regulator support

[Robin Murphy <robin.murphy@arm.com>]

On 2024-09-19 10:12 am, Sebastian Reichel wrote:
> Add optional support for a voltage supply required to enable a
> power domain. The binding follows the way it is handled by the
> Mediatek binding to keep things consistent.
> 
> This will initially be used by the RK3588 GPU power domain, which
> fails to be enabled when the GPU regulator is not enabled.

Note that this applies equally to RK3399 and quite possibly others too, 
it's just that so far it's always been bodged by making the relevant 
regulator always-on (e.g. [1]).

Cheers,
Robin.

[1] https://lore.kernel.org/all/20210619121446.7802-1-knaerzche@gmail.com/

> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> Acked-by: Rob Herring (Arm) <robh@kernel.org>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> ---
>   .../devicetree/bindings/power/rockchip,power-controller.yaml   | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml b/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
> index 0d5e999a58f1..0b4c5b174812 100644
> --- a/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
> +++ b/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
> @@ -131,6 +131,9 @@ $defs:
>             A number of phandles to clocks that need to be enabled
>             while power domain switches state.
>   
> +      domain-supply:
> +        description: domain regulator supply.
> +
>         pm_qos:
>           $ref: /schemas/types.yaml#/definitions/phandle-array
>           items: