From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.216.97 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794870790; b=3xH4rP8BMsWAGTVryj36DaoIyR4yLnFxIwfN0fGprQxL/W24V64935NaELGMWqkg4NNU GRkIqez7qVtXfEHGU2Di2GQ3+qOzpEitEjl10Qs5moWUFiFKgKFxn/koajuwzfbU5yTOY ZBOjLxLt+3rC0Au28gaIIe7PagS2KqYEP21Dqo/skD5XeS19W0tlgLPv0SI9yUYGx7Cew A+1ac4viWEFYzlcLfWYLZ8q/Kk1HRdWLre3USMEMtNYEq5rbgla/UBegCZM9QQzP0OAqN ZrNS5Lnk/ZoznELhCjMDfK8ixW7du8P39CPe7Vyj0l/ySlkGTmhO8auVVx7QlzY2TlA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794870790; h=DMARC-Filter:Received:X-Google-DKIM-Signature:X-Gm-Message-State: X-Gm-Gg:X-Received:Received:X-Relaying-Domain:X-CFilter-Loop:Received: DKIM-Signature:X-Received:X-Received:Received:Message-ID:Date: MIME-Version:User-Agent:Subject:To:Cc:References:Content-Language: From:Autocrypt:In-Reply-To:Content-Type:Content-Transfer-Encoding: X-DetectorID-Processed; bh=39KnhmpTvzW3NJqrAH4c7S3DWPwV9FJJvA+CtiAQvpY=; b=svmSg22EWKiSwaheS3jdA7eErHywDpzUO1JxPFOzv9RsIJB1zdmCn7UHPYCkje/cXpPv HX1AJCoMAiQjcztXQj4goZ+XYnPeQlebm/tJ7U0ZIGe3lt9iz5EQJME91o4+Sm7oyd6oN Xci9S3/wp0omvLo7+4E3ZXUUnKcTuN6yA/Sz2d9c0xEJoo31WZ7ZVv6Zse10hF/FRP9Qb 27VmiZ0mXW8xllnHcwrGgTrQ6QYRuruK409YKHfOKLe5/62LzTvsQjWFPEJ6X1jfGQ/I3 1T7NgT/nU1ddkdj+WMWrrq53CybaVWhElywad4iNCX/+W0CWwOAF2YyTg4HOVHkuKuA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass header.d=broadcom.com header.i=@broadcom.com header.a=rsa-sha256 header.s=google header.b=Ks84OXuH; arc=none smtp.remote-ip=209.85.216.97 Received: from mail-pj1-f97.google.com (mail-pj1-f97.google.com [209.85.216.97]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BEAF606A32A for ; Mon, 16 Nov 2026 23:13:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 2BEAF606A32A Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.a=rsa-sha256 header.s=google header.b=Ks84OXuH Received: by mail-pj1-f97.google.com with SMTP id 98e67ed59e1d1-3b0e61a4decso4437348a91.2 for ; Mon, 16 Nov 2026 15:13:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794870788; x=1795475588; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=39KnhmpTvzW3NJqrAH4c7S3DWPwV9FJJvA+CtiAQvpY=; b=L/4i0wU6x0M/OIRyl79/GzQ2lyxA3T0yDis1uKnrbf62QOMYIffrRq1j8iYG91HJSY 9ud4VchXb+jnqlt3ElWP0RmnYTqPL7lBpKqjapFWipBSNKAT5p7MPNwuSVUKHs7n0oj9 GphpelPXt7D/quiEn17zwz4KWc9xTmocdB7aLYOSbn0548pb2lZuNanlPQS3ryOSzSVg o0lOmUDNM8aiMCyxFv2dCxKgRPonxn/6p+txuoqFtSimy1hFd+rcI2pT4bPdtBoguAxV QHHDgAv9uqM/NrYCp+ndBjvXpQ0tX9z4lyj17Htt9lhmVerd1uC6W1kRSo/wlNIpZ6IS +Xxg== X-Gm-Message-State: APuU4Z+74ngXVjtowpGrhtdKbZnhB2EQHTUdxTMuZSd/rNRvWRlxkgKI Epnsz5ya3YdXN6YvuVT/Vj8K0T82Svu/kAHoA0dDPrpWW32k/+cAIiIKl7kdhWnk8R53a/JHsTZ vdrdNhvKojumuvJrWmczZCLJ2WUC1HDVB8oqMDf1+3wAI62PAfzqMC3N+Qg5TxPEAGYCVdUgata AmO5Cfotpjp/2N6+IpiX15Pk/TV8GPQlnldUverSKMYlWPaLQf3uo9givKjtqi81YawScU3Es+p ONKtF0CtQQXzZn44JHzRbLf X-Gm-Gg: AZFdTZfGEXE/4OIfYeQM3Kn2P/obj581wNit06awTCAG68mqCI+HJcYdio20i/x6WjW iT5zk7QUY0iL6F1D4sE+YiORn4rhnLiKIiAQxx5knLZean5ltx4lqyXX924HrHaGXDR8WP6g0Al fMUvO4jY5D3tohuSVBJk7rqr+rNxSNHGugDAZ8iuYe82qWxa45cWaUVUPJLbNJHQt3Q5rWER47m 9Hghu9cMQdHcbynGv5Kh2z4+lgAYv2tW3/OMH/OZ0QdGcMO2R4ZTMMV+F1rpsosjbPMqQ7tLI+G MZk+CIN5EHufXZSn4iQTAy9jt3nAeUop+OPHdbRJkLQa2IcE/J2l9/1G281qnmacXZ5TlbEfNgN lIBua6z+MqDAh8nMmgn2kctRC4yCe5A73ZTanlJ/7ce6isqF1bxbCvOSjTASrQ6aMhcM9jtKVUj 5tVIlydKj+vt0cKknCFmUfSLs+efXzQOb771+RD4ir X-Received: by 2002:a17:90a:c10f:b0:3b0:ae41:2707 with SMTP id 98e67ed59e1d1-3b1b0ccebdbmr10126106a91.45.1794870788131; Mon, 16 Nov 2026 15:13:08 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-26.dlp.protect.broadcom.com. [144.49.247.26]) by smtp-relay.gmail.com with ESMTPS id 98e67ed59e1d1-3b3abb97be4sm544799a91.1.2026.11.16.15.13.07 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Nov 2026 15:13:08 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-920f97bcad4so10599206d6.0 for ; Mon, 16 Nov 2026 15:13:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1794870787; x=1795475587; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=39KnhmpTvzW3NJqrAH4c7S3DWPwV9FJJvA+CtiAQvpY=; b=Ks84OXuHKcDj1m0yqe2j4zQcIXuj7e0bt67frusWZUnW2uI2jckkhYFxJvypHWImpV PXMf8rXIHKj8yjqz5p8qurErMp8qkmaRM7uuRBsuBNBmJAi3WkvGrcHOY+QtOkB59qjp sH7wmu6bTin/bfJxp028Qws+PMsF4InONId9c= X-Received: by 2002:a05:6214:2623:b0:921:201:e835 with SMTP id 6a1803df08f44-9210201ebefmr2038106d6.27.1794870786530; Mon, 16 Nov 2026 15:13:06 -0800 (PST) X-Received: by 2002:a05:6214:2623:b0:921:201:e835 with SMTP id 6a1803df08f44-9210201ebefmr2037266d6.27.1794870785971; Mon, 16 Nov 2026 15:13:05 -0800 (PST) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-91f23d7ba48sm96715216d6.28.2026.11.16.15.12.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Nov 2026 15:13:05 -0800 (PST) Message-ID: <2ad1cc65-0381-478c-959e-9bee1a597110@broadcom.com> Date: Mon, 16 Nov 2026 15:12:57 -0800 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] irqchip: Convert chained handlers to guard_chained_irq() To: Peng Fan , Thomas Gleixner , Radu Rendec , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Ryan Chen , Benjamin Herrenschmidt , Joel Stanley , Andrew Jeffery , Billy Tsai , Tan Siewert , Eddie James , Ray Jui , Scott Branden , Broadcom internal kernel review list , Caleb James DeLisle , Marc Zyngier , Miodrag Dinic , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Herve Codina , Huacai Chen , WANG Xuerui , Jiaxun Yang , Vladimir Zapolskiy , Piotr Wojtaszczyk , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Samuel Holland , Qin Jian , Changhuang Liang , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Nishanth Menon , Tero Kristo , Santosh Shilimkar , Linus Walleij , Michal Simek , Anirudha Sarangi , Tushar Nimkar Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org, linux-aspeed@lists.ozlabs.org, linux-rpi-kernel@lists.infradead.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, loongarch@lists.linux.dev, linux-riscv@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, git@amd.com, linux-arm-msm@vger.kernel.org, Peng Fan References: <20261114-irqchip-cleanup-api-v1-1-4a9d598b0bdb@nxp.com> Content-Language: en-US, fr-FR From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: <20261114-irqchip-cleanup-api-v1-1-4a9d598b0bdb@nxp.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 11/14/26 07:06, Peng Fan wrote: > From: Peng Fan > > Use the scope-based guard_chained_irq() helper in all chained handlers > under drivers/irqchip/ so that chained_irq_exit() is always invoked when > the handler returns. Handlers that duplicated the exit call on an error > path or jumped to a common exit label simply return now and rely on the > guard. > > No functional changes. > > Signed-off-by: Peng Fan > --- > With [1] now merged in irq/drivers, convert the chained IRQ handlers in > drivers/irqchip/ to use guard_chained_irq(). This removes the explicit > chained_irq_exit() calls and the gotos that only existed to reach them, > reducing boilerplate. > > I use a script to do the job, and after that, do mannual checking. > > No functional changes. > > [1] https://lore.kernel.org/all/179417458323.2093942.14330197609841896598.tip-bot2@tip-bot2/#t > --- > drivers/irqchip/irq-bcm2836.c | 4 +--- > drivers/irqchip/irq-bcm6345-l1.c | 4 +--- > drivers/irqchip/irq-bcm7038-l1.c | 4 +--- > drivers/irqchip/irq-bcm7120-l2.c | 4 +--- > drivers/irqchip/irq-brcmstb-l2.c | 4 +--- For those drivers above: Reviewed-by: Florian Fainelli -- Florian