mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Reinette Chatre <reinette.chatre@intel.com>
To: Peter Newman <peternewman@google.com>
Cc: <fenghua.yu@intel.com>, <Babu.Moger@amd.com>, <bp@alien8.de>,
	<dave.hansen@linux.intel.com>, <eranian@google.com>,
	<gupasani@google.com>, <hpa@zytor.com>, <james.morse@arm.com>,
	<linux-kernel@vger.kernel.org>, <mingo@redhat.com>,
	<skodak@google.com>, <tglx@linutronix.de>, <tony.luck@intel.com>,
	<x86@kernel.org>
Subject: Re: [PATCH v5 2/3] x86/resctrl: Implement rename op for mon groups
Date: Wed, 19 Apr 2023 09:11:15 -0700	[thread overview]
Message-ID: <2ad5f754-e0f1-899c-b7e4-0f35f47fd50b@intel.com> (raw)
In-Reply-To: <CALPaoCh=1Qq5sqWpY8We8zykmmvk81YVnigtZftqMH6FefnQjw@mail.gmail.com>

Hi Peter,

On 4/19/2023 2:38 AM, Peter Newman wrote:
> On Tue, Apr 18, 2023 at 11:53 PM Reinette Chatre
> <reinette.chatre@intel.com> wrote:
>> On 3/30/2023 6:55 AM, Peter Newman wrote:
>>> If a container manager is additionally tracking containers' bandwidth
>>> usage by placing tasks from each into their own monitoring group, it
>>
>> The above sentence seems to be missing something after the "for each".
>> It seems to still parse if "for each" is removed.
> 
> Did you mean "from each"?

I did, yes. Thanks for converting it to what I intended to write.

> In any case, I'll further disambiguate to
> this in my next update:
> 
> "If the container manager is using monitoring groups to separately
> track the bandwidth of containers assigned to the same control group,
> it must first move the container's tasks to the default monitoring
> group of the new control group before it can move these tasks into the
> container's replacement monitoring groups under the destination
> control group."

Looks good to me. Thank you.

Reinette

  reply	other threads:[~2023-04-19 16:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-30 13:55 [PATCH v5 0/3] Subject: x86/resctrl: Implement rename to help move containers' tasks Peter Newman
2023-03-30 13:55 ` [PATCH v5 1/3] x86/resctrl: Factor rdtgroup lock for multi-file ops Peter Newman
2023-03-30 13:55 ` [PATCH v5 2/3] x86/resctrl: Implement rename op for mon groups Peter Newman
2023-04-18 21:52   ` Reinette Chatre
2023-04-19  9:38     ` Peter Newman
2023-04-19 16:11       ` Reinette Chatre [this message]
2023-03-30 13:55 ` [PATCH v5 3/3] Documentation/x86: Documentation for MON group move feature Peter Newman
2023-03-30 17:33   ` Moger, Babu
2023-03-31  8:12     ` Peter Newman
2023-03-31 20:51       ` Moger, Babu
2023-04-18 21:53   ` Reinette Chatre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2ad5f754-e0f1-899c-b7e4-0f35f47fd50b@intel.com \
    --to=reinette.chatre@intel.com \
    --cc=Babu.Moger@amd.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=eranian@google.com \
    --cc=fenghua.yu@intel.com \
    --cc=gupasani@google.com \
    --cc=hpa@zytor.com \
    --cc=james.morse@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peternewman@google.com \
    --cc=skodak@google.com \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®