From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751445AbdBWQe7 (ORCPT ); Thu, 23 Feb 2017 11:34:59 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:27888 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751156AbdBWQez (ORCPT ); Thu, 23 Feb 2017 11:34:55 -0500 Subject: Re: [PATCH] RDS: IB: fix ifnullfree.cocci warnings To: kbuild test robot References: <201702232002.caFuWJ4l%fengguang.wu@intel.com> <20170223124700.GA9908@lkp-hsx03.lkp.intel.com> Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com From: Santosh Shilimkar Organization: Oracle Corporation Message-ID: <2adadc3d-8a23-cb40-3232-bea9a7555363@oracle.com> Date: Thu, 23 Feb 2017 08:35:17 -0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20170223124700.GA9908@lkp-hsx03.lkp.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/23/2017 4:47 AM, kbuild test robot wrote: > net/rds/ib.c:115:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. > > NULL check before some freeing functions is not needed. > > Based on checkpatch warning > "kfree(NULL) is safe this check is probably not required" > and kfreeaddr.cocci by Julia Lawall. > > Generated by: scripts/coccinelle/free/ifnullfree.cocci > > Signed-off-by: Fengguang Wu > --- Acked-by: Santosh Shilimkar