Re: [PATCH v9 0/2] add VCP mailbox driver

["Jjian Zhou (周建)" <Jjian.Zhou@mediatek.com>]

On Mon, 2025-10-13 at 14:31 +0800, Jjian Zhou wrote:

This email is just a reminder to review the patch:

https://patchwork.kernel.org/project/linux-mediatek/patch/20251013063146.17919-3-jjian.zhou@mediatek.com/

> Hi everyone,
> 
> This is v9 of my VCP mailbox driver.
> 
> Changes since v9:
> - Add "Reviewed-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@collabora.com>"
> 
> Changes since v8:
> - Rebase onto next-20251008 and fixed build breaks.
> 
> Changes since v7:
> - mtk-vcp-mailbox.c:
>   - Change type u32 to u16.
>   - Change BIT(ipi_info->index) to if.
>   - Put the platform_set_drvdata between "of_device_get_match_data"
>     and "platform_get_irq".
> - mtk-vcp-mailbox.h
>   - Modify the definition to MTK_VCP_MBOX_SLOT_MAX_SIZE.
> 
> Changes since v6:
> - mtk-vcp-mailbox.c:
>   - Replace mtk_vcp_mbox_priv with mtk_vcp_mbox.
>   - Move mbox_controller to the first member.
>   - Define "struct mbox_chan chan"; Remove allocate one during the
> probe.
>   - Remove API get_mtk_vcp_mbox_priv.
>   - Pass the private data since there's only one mailbox.
>   - Modify mtk_vcp_mbox_xlate "return &mbox->chans[0]".
> 
> Changes since v5:
> - binding:
>   - Patch 1 fix 'make dt_binding_check' errors.
>   - Link to v5
>     
> https://patchwork.kernel.org/project/linux-mediatek/patch/20250822021217.1598-2-jjian.zhou@mediatek.com/
> 
> Changes since v4:
> - binding:
>   - Match the binding file name and compatible.
> - mtk-vcp-mailbox.c:
>   - Drop 'dev_dbg(dev, "MTK VCP mailbox initialized\n")'.
> - Since the reviewer hopes to combine the VCP IPC driver and
>   the VCP driver for a unified review, the original three patches
>   have been split into two parts: the VCP mailbox driver and
>   the binding remain together, while the VCP IPC driver is merged
>   with the VCP driver and submitted as one.
> - Link to v4
>   
> https://lore.kernel.org/all/20250820094545.23821-1-jjian.zhou@mediatek.com/
> 
> Changes since v3:
> - binding:
>   - Remove unused lable '|' and 'vcp_mailbox0'.
> - Link to v3
>   
> https://lore.kernel.org/all/20250317110331.2776-1-jjian.zhou@mediatek.com/
> 
> Changes since v1:
> - Link to v1
>   
> https://lore.kernel.org/all/20250305082047.15746-1-jjian.zhou@mediatek.com/
> 
> In the v2 version, there is ongoing discussion about whether the
> VCP's
> IPC should use mailbox or rpmsg. To prevent the discussion records
> from being lost, the previous discussion link is attached.
> 
https://lore.kernel.org/all/CAGXv+5FXqZb_v2dQNgCKbFpJrLhbVk3f0sWrrMCVk3jaWwoBqA@mail.gmail.com/
> 
> 
> Jjian Zhou (2):
>   dt-bindings: mailbox: mediatek,mt8196-vcp-mbox: add mtk vcp-mbox
>     document
>   mailbox: mediatek: Add mtk-vcp-mailbox driver
> 
>  .../mailbox/mediatek,mt8196-vcp-mbox.yaml     |  49 +++++
>  drivers/mailbox/Kconfig                       |   9 +
>  drivers/mailbox/Makefile                      |   2 +
>  drivers/mailbox/mtk-vcp-mailbox.c             | 170
> ++++++++++++++++++
>  include/linux/mailbox/mtk-vcp-mailbox.h       |  32 ++++
>  5 files changed, 262 insertions(+)
>  create mode 100644
> Documentation/devicetree/bindings/mailbox/mediatek,mt8196-vcp-
> mbox.yaml
>  create mode 100644 drivers/mailbox/mtk-vcp-mailbox.c
>  create mode 100644 include/linux/mailbox/mtk-vcp-mailbox.h
> 
> --
> 2.46.0
>