From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 665F530DEB8 for ; Wed, 24 Jun 2026 12:10:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782303017; cv=none; b=iEx2AQ50yTkEazLC3ZD388K88ROn1dnAR7oM637qh4tLWNL1N1RkHWojVVoVeJBj/MrEOqkVtAsGJKy+h1oao/fC3vB92jghg4I+Hq2q4cY8q39M9SUR5GcZszunZUqJ2cw9xB9pFYgSy+Kp3pBqfwOqkuP5OfFjA8ZxYEqZYgc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782303017; c=relaxed/simple; bh=2HZp2JT9DhRDsJHSxYxJaK9WQOpNgY3tItvlO3AM2L8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FV3bRIAix/+ykcfEhxNE4SHqX4/MjOLijxHNeU1iwv2C3QMrc3Dux1hUMvQtD0mF9gRy9GeJmvxqJyLEy4sgqSQuqEaX04ndGd6csDQzFpF4HZkIPorzdq9YUAC4II5jvUFLR/Pri+3vkNfYw/v/L+1B8rO0beNtEVBHgeHV/B4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=LRzC8JcG; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fP+0hIxl; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="LRzC8JcG"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fP+0hIxl" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65OANdH53047175 for ; Wed, 24 Jun 2026 12:10:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Svb2pofDTe/NUHQV6a8z7yIDtgbyrcfcpozTS755gfU=; b=LRzC8JcG1/q1Rtda FFrgDWx/lkeAfrDPvm85ZYBQH/rKin1tAvlb45wtqlLVbDFHhQm/CblfdKSDpME3 nQxAeIUIzVN8ZWPpYBNSV2NOrqFz9sJCTDFfE1Ot2JMLPUEgkK2h/ZHrEyO3q8pT HqzqQGIFG6sIhy4KrqXYAsqr58tu64rO1WzVjxSB+advWQ7c0khm6detfr5UDqAv MRNkXkGlJk/YBmq/nPlRJU+Y5kH30w5x5FMi4Fi3at7611KRo50hSPGhHgNbYd1n 46sKFt6VoLL7fROw109cDikRL/6HOHjCaG3Vo3ps64hfjT24fiopQj6bhaUKbXXp miHiBQ== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f05ar2425-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 24 Jun 2026 12:10:14 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-8ded0d4d805so2514546d6.1 for ; Wed, 24 Jun 2026 05:10:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782303014; x=1782907814; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Svb2pofDTe/NUHQV6a8z7yIDtgbyrcfcpozTS755gfU=; b=fP+0hIxlSj4SsHHJEqTgkSpwHJy8195VBkK5MbJTGv1T29p/8qsaE0A0UaWS/uSfUB K54xgxxPgsrBz/G0KxYdidIplmpmWTGq3+CBbxoKYPtSOsRs7ZR0yaP1OI4W5CP+aGAp 8lXcOr3Y4peMqOITdEbeWaXK8ARiylBbRa0HLKLue3m+JMhVD/Dh9fgTEaS8umsLieXv 8FOXjhpXqLs7a3yVMXnDDSWCFxjPd6XwKGrlqjpQzguFpsNAo4QWeVBVmrF+B0pDhrsK cE/NO/fhnuodq0UR4NcL4BAu3ZuCQmsWg+gy1q/3p+k4dXn+Mu3z5adLB2GI6gpBFSgB INPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782303014; x=1782907814; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Svb2pofDTe/NUHQV6a8z7yIDtgbyrcfcpozTS755gfU=; b=e13AOVfQ356EmgKeNfDGAcMqesXtBX3EupBSccXoa+/Y8D4BU8LuIj8SR5o34F94W+ eQ+NM6zu6/RqbArtqy0RVR4gBS9l1wHq4Hf3EZJorU+0YJD6vjNlJGv/giR6jalohMxJ stiiNniZrCCyTVxnFJIHAjzZFxYyX9tipPQXKPbz99PeHjAD50cr9yPY2LCuCyXQV6JE XcQEfOlHW6Xcd6Chu+3JscfoZSB7LUBEdVHoMMAD5UPBASQLn7+oMnXGuL+F9/AegiYl zQ7Pfi593bR+qZQe2lpoOCT+1Lw53YfxGOTaZSjKfvw5Yuv9+lqrU4Hwoa+qTNaMeD/X NPcA== X-Forwarded-Encrypted: i=1; AFNElJ+abeqmpkt3DNhuE8VXN+U2k4aCUZ7Qb/01cfrbk6XgB0dhsXqk3Tb3FNV0a0vD1+ZsW3tG9PgRLgb1jPI=@vger.kernel.org X-Gm-Message-State: AOJu0YwJALhq5zQQ3NlD3C497l5X7p4Yu/q0HNOJWA4nWCYdK2Dozo63 P4rjyuijjJT/dquLZieX7DUcw9kgDynhTOYts+k8bYWTmEimcu7360aP0rPVIJx1M7IiUDH+aUF HOYOavd3Z2dWQSsDaJbbJzvMlB9XXAstzRf8i1z89CcsGA6H89QP3Ye9z1wshqUOhiB8= X-Gm-Gg: AfdE7cka8kVHmZwWO9I+VwH/ajfzlOi5KwPxfUk2op8Gp60zbuQBcMhBPjPLgOajC/U KqdmHpjFzPNRYOGHE7pD8GiIrjjV3IID2X8bI6LWWNrfKUIBlV3B62CboO5s9wdraYtsmwWeIps juT/gPqVbSITnYncH96vcS1uAkCs0MJ43BC2HFD6epEkyf5us8WU2jcYlHF6IjFEPOgyQ2QnXAJ vsGSxpAXM0sDOadzTqK7uPlL+JqYZRa4F+6DUfm0YdtMwI2d+G/NRLUhAN4ZlU7+vRNg03NfoRi y4ExQABD+pJNPccZeOfj8osWQWWGgsuZpM0pw1fPgDN+suf9ORJg2b1eyzSQV09MQfh0qRak98q bNM7UqZXI1vIDOWDFBpitm9158yqG6mp7ECU= X-Received: by 2002:a05:622a:1813:b0:517:71b8:ee37 with SMTP id d75a77b69052e-51a4f371215mr90458351cf.0.1782303013744; Wed, 24 Jun 2026 05:10:13 -0700 (PDT) X-Received: by 2002:a05:622a:1813:b0:517:71b8:ee37 with SMTP id d75a77b69052e-51a4f371215mr90457751cf.0.1782303013008; Wed, 24 Jun 2026 05:10:13 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c0c610e5275sm639417266b.45.2026.06.24.05.10.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Jun 2026 05:10:12 -0700 (PDT) Message-ID: <2aed327e-abf6-401a-a05b-ba3f4a5cd7f3@oss.qualcomm.com> Date: Wed, 24 Jun 2026 14:10:10 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/4] arm64: dts: qcom: Add HONOR MagicBook Art 14 device tree To: Konstantin Shabanov , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260620175210.19563-1-mail@etehtsea.me> <20260620175210.19563-4-mail@etehtsea.me> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260620175210.19563-4-mail@etehtsea.me> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: jcXB30uSdktL9L10iPUQgRwjhfnbUJGY X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI0MDA5OSBTYWx0ZWRfX+nxyD6WSo/TH qwajqYFQrjwfmAqiG4DGFvYTZTFOdCQRc6v9VYUXUzzW600qCa4dfJPb1VBDkPsfqHZLXRtT9kd NBlPnibvQ3FvbT2oWbQyLgKfcZxjy8s= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI0MDA5OSBTYWx0ZWRfX9qVrf68pD8FP I9TKrx4jDm1q6F7Y3Cye4kFCdz31HNn6+lggMjbpDP6O8Gds4Iv1A/J8giZ8jfbdZzBeyOXXEvC T4DRuyVLQ3AlaZxSRblr6HI8D20aw5+PEcp8PDfLUNIceqbH5KiSudXdBi2siHZhCrxP15haLQc 6A4qN/C4B687XVvBqWvQIzwaPDplMi/lHgVtJ9BOC+YxELQ8HKoqH+kwjM+LUMPCbTtsSqtIHzU /VBHGj5ZXrpWBfK+AO9gNmxIAK/9Q5DbyA6f2BBe4c0oZr6r9vDgGT6gPFOu4iuq6ezJlD+lsni bLv3wk+V6o0JdMv8UATtAubsYH2DeaJmu708oB2TAUjc+jSfr1AnQDIQFTlBLwHGGs0R8ORYDZh lSAjn/NdLwYjpcSgcjAp1rPP6EmB8Q== X-Proofpoint-GUID: jcXB30uSdktL9L10iPUQgRwjhfnbUJGY X-Authority-Analysis: v=2.4 cv=EuLiaycA c=1 sm=1 tr=0 ts=6a3bc926 cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=4Qiz8VOyNOBCKGrP_ZoA:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-24_03,2026-06-23_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 adultscore=0 malwarescore=0 phishscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606240099 On 6/20/26 7:51 PM, Konstantin Shabanov wrote: > Introduce support for the HONOR MagicBook Art 14 laptop. > This version is based on the initial work by Kirill A. Korinsky [1] > and Valentin Manea [2]. [...] > +&iris { > + firmware-name = "qcom/x1e80100/HONOR/MRO-XXX/qcvss8380.mbn"; Is that a model name, or a placeholder? [...] > +&tlmm { > + gpio-reserved-ranges = <34 2>, /* Unused */ > + <44 4>; /* SPI (TPM) */ > + > + hall_int_n_default: hall-int-n-state { > + pins = "gpio92"; > + function = "gpio"; > + bias-disable; > + }; nit: pins would be best sorted by their pin index [...] > + ts0_default: ts0-default-state { > + int-n-pins { > + pins = "gpio51"; > + function = "gpio"; > + bias-disable; > + }; > + > + reset-n-pins { > + pins = "gpio48"; > + function = "gpio"; > + output-high; not a nit: drop output-foo properties from TLMM pins, the driver that consumes them should take care of setting their state [...] > +/* MP0 goes to the USB-A port(USB3) and FPC */ ultra nit: add a space before '(', please Konrad