From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751608AbdEBO35 (ORCPT ); Tue, 2 May 2017 10:29:57 -0400 Received: from mout.web.de ([212.227.17.12]:62034 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750955AbdEBO3y (ORCPT ); Tue, 2 May 2017 10:29:54 -0400 Subject: [PATCH 5/6] md: Adjust six function calls together with a variable assignment in faulty_status() From: SF Markus Elfring To: linux-raid@vger.kernel.org, Neil Brown , Shaohua Li Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: <2af19638-e678-3386-f45e-ddaee2c6e9e1@users.sourceforge.net> Date: Tue, 2 May 2017 16:29:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:sbFppziDLsHHi3SLAtgjdWdoQR+gQuwlSs+jcnJK0A50HDK9MMH L4WFGe2EyfBr41Q+rc4GhcESrg0+Fbpkaiyg63ZXTtOtwebzCyBMt7A8xbQJUp40DLNBY5b h7g+i64peaXYGk7/z9R4ATUEGHm1bqmrOBB48pBcBJ53XLnDjacTAX1DjJbxANMtB0SCsre 6+mNF/sI5SYJGR0JPy+Fw== X-UI-Out-Filterresults: notjunk:1;V01:K0:WZf//dcg5Y4=:rdekTXzG7A5auXXKfscE9E ynEOkzNI6zibtYzmSZxfaQms+7YLk+aGfJSBl7VLafvxmVdfAUUW+i976Ahx8CUuNfqj5hM+N 1BOad0i3dvjPgtoj6wQget4eIeLXUG9tMmNZJzEEiRTo9y9Bc2kc4Pm731tOORB5TXhjq46tC xbpfPPYII4ZQxO8j1+PwajSzZYzwn3OUxcOhBODAc2eGR50ekuObbVz6w/B4iLsCjmj1UNuBU hAVxk2NA8KwrEhJ0zwSYg7hZbMAFNOZ5xzt+iUad3vTMWnCt+vAro0KchOKeqRHx39Klxvsac 3lIuO2QezkIJ6blUc8sgMVYkBmKlZCWIKJDB/5Xt9V3raYuwFZ6ekl+zZZvDG8+v1xAPf3a5f CrNgJvsXeOHqQUywcacuhqfVJEdTGrBqrn4Nf6XYVS5xovtI5/oG/TPBN+IkwJUyehfHAcJkp vgq3Vy+g2OVApVU8gck84NVQn+/VfYe7rO3rqnsy0dF/UyQ+2vl8C21rHGocO1Piq9rBwJcF1 aFXTC+lksSuWqrVRA8JN8oYYlO7h8aPr6y4FvxUJnAalcL7REEWyz4K0TkMzo+eUhrLFMF/Rk YeVaDPCKAfpPep2ai0XuPl6vpcVgyNgt2znXzB5mHmPNuEiurp799AKboQbPsw6NuiX6c9vJ4 lnKHLELNfxVRb3aU8WOP0RUVpMtgSwEVcNrPLuXOq4XM1A/WSrW+3bUpuYHlqutjb2dDULVq8 9pvSNWBpjQJT3nO5p9GTYOBnXmk7F4ncQv+fBXE6pJXB2o9G3iDuzwNNnFJr+tcAKdI562koE USIO53B Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Tue, 2 May 2017 15:35:35 +0200 The script "checkpatch.pl" pointed information out like the following. ERROR: do not use assignment in if condition Thus fix the affected source code places. Signed-off-by: Markus Elfring --- drivers/md/faulty.c | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/drivers/md/faulty.c b/drivers/md/faulty.c index f5536c91be5c..2573009b1265 100644 --- a/drivers/md/faulty.c +++ b/drivers/md/faulty.c @@ -231,28 +231,33 @@ static void faulty_status(struct seq_file *seq, struct mddev *mddev) struct faulty_conf *conf = mddev->private; int n; - if ((n=atomic_read(&conf->counters[WriteTransient])) != 0) + n = atomic_read(&conf->counters[WriteTransient]); + if (n != 0) seq_printf(seq, " WriteTransient=%d(%d)", n, conf->period[WriteTransient]); - if ((n=atomic_read(&conf->counters[ReadTransient])) != 0) + n = atomic_read(&conf->counters[ReadTransient]); + if (n != 0) seq_printf(seq, " ReadTransient=%d(%d)", n, conf->period[ReadTransient]); - if ((n=atomic_read(&conf->counters[WritePersistent])) != 0) + n = atomic_read(&conf->counters[WritePersistent]); + if (n != 0) seq_printf(seq, " WritePersistent=%d(%d)", n, conf->period[WritePersistent]); - if ((n=atomic_read(&conf->counters[ReadPersistent])) != 0) + n = atomic_read(&conf->counters[ReadPersistent]); + if (n != 0) seq_printf(seq, " ReadPersistent=%d(%d)", n, conf->period[ReadPersistent]); - - if ((n=atomic_read(&conf->counters[ReadFixable])) != 0) + n = atomic_read(&conf->counters[ReadFixable]); + if (n != 0) seq_printf(seq, " ReadFixable=%d(%d)", n, conf->period[ReadFixable]); - if ((n=atomic_read(&conf->counters[WriteAll])) != 0) + n = atomic_read(&conf->counters[WriteAll]); + if (n != 0) seq_puts(seq, " WriteAll"); seq_printf(seq, " nfaults=%d", conf->nfaults); -- 2.12.2