mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Viresh Kumar <viresh.kumar@linaro.org>
To: tglx@linutronix.de
Cc: linaro-kernel@lists.linaro.org, fweisbec@gmail.com,
	linaro-networking@linaro.org, Arvind.Chauhan@arm.com,
	linux-kernel@vger.kernel.org,
	Viresh Kumar <viresh.kumar@linaro.org>
Subject: [PATCH V2 15/36] hrtimer: don't emulate notifier call to initialize timer base
Date: Fri,  4 Apr 2014 12:05:58 +0530	[thread overview]
Message-ID: <2af2580fcd9edf7faacfd33bdfdda79feb64384e.1396592516.git.viresh.kumar@linaro.org> (raw)
In-Reply-To: <cover.1396592516.git.viresh.kumar@linaro.org>
In-Reply-To: <cover.1396592516.git.viresh.kumar@linaro.org>

In hrtimers_init() we need to call init_hrtimers_cpu() for boot cpu. For this,
currently we are emulating a call to hotplug notifier. Probably this was done
initially to get rid of code redundancy. But this sequence always called a
single routine, i.e. init_hrtimers_cpu(), and so calling that routine directly
would be better. This would get rid of emulating a notifier call, few typecasts
and the extra steps we are doing in notifier callback.

So, this patch calls init_hrtimers_cpu() directly from hrtimers_init().

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
 kernel/hrtimer.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/kernel/hrtimer.c b/kernel/hrtimer.c
index 833db9f..5b0cbe7 100644
--- a/kernel/hrtimer.c
+++ b/kernel/hrtimer.c
@@ -1753,8 +1753,7 @@ static struct notifier_block hrtimers_nb = {
 
 void __init hrtimers_init(void)
 {
-	hrtimer_cpu_notify(&hrtimers_nb, (unsigned long)CPU_UP_PREPARE,
-			  (void *)(long)smp_processor_id());
+	init_hrtimers_cpu(smp_processor_id());
 	register_cpu_notifier(&hrtimers_nb);
 #ifdef CONFIG_HIGH_RES_TIMERS
 	open_softirq(HRTIMER_SOFTIRQ, run_hrtimer_softirq);
-- 
1.7.12.rc2.18.g61b472e


  parent reply	other threads:[~2014-04-04  6:49 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-04  6:35 [PATCH V2 00/36] timers/hrtimers: Cleanups & Fixes Viresh Kumar
2014-04-04  6:35 ` [PATCH V2 01/36] hrtimer: replace 'tab' with 'space' after 'comma' Viresh Kumar
2014-04-04  6:35 ` [PATCH V2 02/36] hrtimer: Fix comment mistake over hrtimer_force_reprogram() Viresh Kumar
2014-04-04  6:35 ` [PATCH V2 03/36] hrtimer: fix routine names in comments Viresh Kumar
2014-04-04  6:35 ` [PATCH V2 04/36] hrtimer: remove {} around a single liner 'for' loop in migrate_hrtimers() Viresh Kumar
2014-04-04  6:35 ` [PATCH V2 05/36] hrtimer: Coalesce format fragments in printk() Viresh Kumar
2014-04-04  6:35 ` [PATCH V2 06/36] hrtimer: remove dummy definition of hrtimer_force_reprogram() Viresh Kumar
2014-04-04  6:35 ` [PATCH V2 07/36] hrtimer: replace sizeof(struct hrtimer) with sizeof(*timer) Viresh Kumar
2014-04-04  6:35 ` [PATCH V2 08/36] hrtimer: move unlock_hrtimer_base() upwards Viresh Kumar
2014-04-04  6:35 ` [PATCH V2 09/36] hrtimer: call hrtimer_set_expires_range() from hrtimer_set_expires_range_ns() Viresh Kumar
2014-04-04  6:35 ` [PATCH V2 10/36] hrtimer: use base->index instead of basenum in switch_hrtimer_base() Viresh Kumar
2014-04-04  6:35 ` [PATCH V2 11/36] hrtimer: no need to rewrite '1' to hrtimer_hres_enabled Viresh Kumar
2014-04-04  6:35 ` [PATCH V2 12/36] hrtimer: use base->hres_active directly instead of hrtimer_hres_active() Viresh Kumar
2014-04-04  6:35 ` [PATCH V2 13/36] hrtimer: don't check state of base->hres_active in hrtimer_switch_to_hres() Viresh Kumar
2014-04-04  6:35 ` [PATCH V2 14/36] hrtimer: reorder code in __remove_hrtimer() Viresh Kumar
2014-04-04  6:35 ` Viresh Kumar [this message]
2014-04-04  6:35 ` [PATCH V2 16/36] hrtimer: Create hrtimer_get_monoexpires() Viresh Kumar
2014-04-04  6:36 ` [PATCH V2 17/36] hrtimer: don't check if timer is queued in __remove_hrtimer() Viresh Kumar
2014-04-04  6:36 ` [PATCH V2 18/36] hrtimer: rewrite switch_hrtimer_base() to remove extra indentation level Viresh Kumar
2014-04-04  6:36 ` [PATCH V2 19/36] hrtimer: rewrite remove_hrtimer() " Viresh Kumar
2014-04-04  6:36 ` [PATCH V2 20/36] hrtimer: replace base by new_base to get resolution: __hrtimer_start_range_ns() Viresh Kumar
2014-04-04  6:36 ` [PATCH V2 21/36] hrtimer: create base_on_this_cpu() Viresh Kumar
2014-04-04  6:36 ` [PATCH V2 22/36] hrtimer: clear active_bases as soon as the timer is removed Viresh Kumar
2014-04-04  6:36 ` [PATCH V2 23/36] hrtimer: create for_each_active_base() Viresh Kumar
2014-04-04  6:36 ` [PATCH V2 24/36] hrtimer: Use for_each_active_base() to iterate over active clock bases Viresh Kumar
2014-04-04  6:36 ` [PATCH V2 25/36] hrtimer: call hrtimer_get_softirq_time() only if cpu_base->active_bases is set Viresh Kumar
2014-04-04  6:36 ` [PATCH V2 26/36] hrtimer: take lock only once for a cpu_base in hrtimer_run_queues() Viresh Kumar
2014-04-04  6:36 ` [PATCH V2 27/36] hrtimer: call switch_hrtimer_base() after setting new expiry time Viresh Kumar
2014-04-04  6:36 ` [PATCH V2 28/36] hrtimer: remove 'base' parameter from remove_timer() and __remove_timer() Viresh Kumar
2014-04-04  6:36 ` [PATCH V2 29/36] hrtimer: remove 'base' parameter from switch_hrtimer_base() Viresh Kumar
2014-04-04  6:36 ` [PATCH V2 30/36] hrtimer: remove 'base' parameter from enqueue_hrtimer() Viresh Kumar
2014-04-04  6:36 ` [PATCH V2 31/36] hrtimer: remove 'base' parameter from hrtimer_{enqueue_}reprogram() Viresh Kumar
2014-04-04  6:36 ` [PATCH V2 32/36] hrtimer: make switch_hrtimer_base() return void Viresh Kumar
2014-04-04  6:36 ` [PATCH V2 33/36] hrtimer: make lock_hrtimer_base() " Viresh Kumar
2014-04-04  6:36 ` [PATCH V2 34/36] hrtimer: make enqueue_hrtimer() " Viresh Kumar
2014-04-04  6:36 ` [PATCH V2 35/36] timer: simplify CPU_UP_PREPARE notifier code path Viresh Kumar
2014-04-04  6:36 ` [PATCH V2 36/36] timer: don't emulate notifier call to initialize timer base Viresh Kumar
2014-04-30  8:51 ` [PATCH V2 00/36] timers/hrtimers: Cleanups & Fixes Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2af2580fcd9edf7faacfd33bdfdda79feb64384e.1396592516.git.viresh.kumar@linaro.org \
    --to=viresh.kumar@linaro.org \
    --cc=Arvind.Chauhan@arm.com \
    --cc=fweisbec@gmail.com \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linaro-networking@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®