From: Markus Elfring <Markus.Elfring@web.de>
To: Wen Yang <wen.yang99@zte.com.cn>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, Yi Wang <wang.yi59@zte.com.cn>,
Anirudha Sarangi <anirudh@xilinx.com>,
John Linn <John.Linn@xilinx.com>,
"David S. Miller" <davem@davemloft.net>,
Michal Simek <michal.simek@xilinx.com>
Subject: Re: [1/2] net: xilinx: add a helper function for axienet_probe
Date: Tue, 9 Apr 2019 08:36:00 +0200 [thread overview]
Message-ID: <2b04afef-29bc-2fe2-cb23-467d823a6ad4@web.de> (raw)
In-Reply-To: <1554788881-22647-1-git-send-email-wen.yang99@zte.com.cn>
> The "Find DMA Node, Map DMA Register, and Decode DMA IRQ" code snippets
> in Axienet_Probe are independent. Tidy up axienet_probe a little by
> factoring these out into a helper function.
Would the following wording be more appropriate for the commit description?
in axienet_probe() are independent.
Tidy this function implementation a little up by factoring these calls out
into a helper function.
Regards,
Markus
prev parent reply other threads:[~2019-04-09 6:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 5:48 [PATCH 1/2] " Wen Yang
2019-04-09 5:48 ` [PATCH 2/2] net: ethernet: ti: eliminated some duplicate code Wen Yang
2019-04-09 7:30 ` [2/2] " Markus Elfring
2019-04-09 6:36 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b04afef-29bc-2fe2-cb23-467d823a6ad4@web.de \
--to=markus.elfring@web.de \
--cc=John.Linn@xilinx.com \
--cc=anirudh@xilinx.com \
--cc=davem@davemloft.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=netdev@vger.kernel.org \
--cc=wang.yi59@zte.com.cn \
--cc=wen.yang99@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®