mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Nemanov, Michael" <michael.nemanov@ti.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Kalle Valo <kvalo@kernel.org>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	<linux-wireless@vger.kernel.org>, <netdev@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Sabeeh Khan <sabeeh-khan@ti.com>
Subject: Re: [PATCH v5 01/17] dt-bindings: net: wireless: cc33xx: Add ti,cc33xx.yaml
Date: Tue, 12 Nov 2024 08:45:50 +0200	[thread overview]
Message-ID: <2b0e95be-8192-416f-8655-631d6cecc336@ti.com> (raw)
In-Reply-To: <y4ffzjekeccqg2tv7d54ilwbz3nhm4jkcq3fyg5tmpbupsqirn@dq3kjtwkllds>

On 11/8/2024 2:02 PM, Krzysztof Kozlowski wrote:
> On Thu, Nov 07, 2024 at 02:51:53PM +0200, Michael Nemanov wrote:
>> Add device-tree bindings for the CC33xx family.
>>
>> Signed-off-by: Michael Nemanov <michael.nemanov@ti.com>
>> ---
>>   .../bindings/net/wireless/ti,cc33xx.yaml      | 59 +++++++++++++++++++
>>   1 file changed, 59 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/net/wireless/ti,cc33xx.yaml
>>
> 
> <form letter>
> This is a friendly reminder during the review process.
> 
> It seems my or other reviewer's previous comments were not fully
> addressed. Maybe the feedback got lost between the quotes, maybe you
> just forgot to apply it. Please go back to the previous discussion and
> either implement all requested changes or keep discussing them.
> 
> Thank you.
> </form letter>
> 
> Best regards,
> Krzysztof
> 

Are you referring to

> diff --git a/Documentation/devicetree/bindings/net/wireless/ti,cc33xx.yaml b/Documentation/devicetree/bindings/net/wireless/ti,cc33xx.yaml

...

> +
> +properties:
> +  $nodename:
> +    pattern: "^wifi@2"

?

If so, I replied here
https://lore.kernel.org/linux-wireless/8024aa1c-5bd1-40d8-b0c3-14b5fcd992e2@ti.com/#t
But if you don't think it's worthwhile I'll remove it.

Regards,
Michael.

  reply	other threads:[~2024-11-12  6:46 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-07 12:51 [PATCH v5 00/17] wifi: cc33xx: Add driver for new TI CC33xx wireless device family Michael Nemanov
2024-11-07 12:51 ` [PATCH v5 01/17] dt-bindings: net: wireless: cc33xx: Add ti,cc33xx.yaml Michael Nemanov
2024-11-08 12:02   ` Krzysztof Kozlowski
2024-11-12  6:45     ` Nemanov, Michael [this message]
2024-11-19  9:15       ` Krzysztof Kozlowski
2024-11-19 12:10         ` Nemanov, Michael
2024-11-08 12:07   ` Krzysztof Kozlowski
2024-11-07 12:51 ` [PATCH v5 02/17] wifi: cc33xx: Add cc33xx.h, cc33xx_i.h Michael Nemanov
2024-11-07 12:51 ` [PATCH v5 03/17] wifi: cc33xx: Add debug.h Michael Nemanov
2024-11-07 12:51 ` [PATCH v5 04/17] wifi: cc33xx: Add sdio.c, io.c, io.h Michael Nemanov
2024-11-07 12:51 ` [PATCH v5 05/17] wifi: cc33xx: Add cmd.c, cmd.h Michael Nemanov
2024-11-08 16:25   ` Markus Elfring
2024-11-07 12:51 ` [PATCH v5 06/17] wifi: cc33xx: Add acx.c, acx.h Michael Nemanov
2024-11-07 12:51 ` [PATCH v5 07/17] wifi: cc33xx: Add event.c, event.h Michael Nemanov
2024-11-07 12:52 ` [PATCH v5 08/17] wifi: cc33xx: Add boot.c, boot.h Michael Nemanov
2024-11-07 12:52 ` [PATCH v5 09/17] wifi: cc33xx: Add main.c Michael Nemanov
2024-11-08 11:42   ` Johannes Berg
2024-11-11 11:38     ` Kalle Valo
2024-11-12 15:34     ` Nemanov, Michael
2024-11-12 15:39       ` Johannes Berg
2024-11-14 17:44     ` Nemanov, Michael
2024-12-01  9:47     ` Nemanov, Michael
2024-12-01 17:09     ` Nemanov, Michael
2024-11-07 12:52 ` [PATCH v5 10/17] wifi: cc33xx: Add rx.c, rx.h Michael Nemanov
2024-11-07 12:52 ` [PATCH v5 11/17] wifi: cc33xx: Add tx.c, tx.h Michael Nemanov
2024-11-07 12:52 ` [PATCH v5 12/17] wifi: cc33xx: Add init.c, init.h Michael Nemanov
2024-11-07 12:52 ` [PATCH v5 13/17] wifi: cc33xx: Add scan.c, scan.h Michael Nemanov
2024-11-07 12:52 ` [PATCH v5 14/17] wifi: cc33xx: Add conf.h Michael Nemanov
2024-11-07 12:52 ` [PATCH v5 15/17] wifi: cc33xx: Add ps.c, ps.h Michael Nemanov
2024-11-07 12:52 ` [PATCH v5 16/17] wifi: cc33xx: Add testmode.c, testmode.h Michael Nemanov
2024-11-07 12:52 ` [PATCH v5 17/17] wifi: cc33xx: Add Kconfig, Makefile Michael Nemanov
2025-04-29 16:38 ` [PATCH v5 00/17] wifi: cc33xx: Add driver for new TI CC33xx wireless device family Ezra Buehler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2b0e95be-8192-416f-8655-631d6cecc336@ti.com \
    --to=michael.nemanov@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=kuba@kernel.org \
    --cc=kvalo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=robh@kernel.org \
    --cc=sabeeh-khan@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®