From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7905D346E51 for ; Wed, 18 Mar 2026 10:32:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773829967; cv=none; b=HyDQmqMCIy9ozeij1RbK3aBw5UWuOfunTZPg3/L7mEyrm6o6AQFt3Hv3C1tRVFuhkopN5JqVQUJKmAufTMrvfMTD3/uQ9M23UdnLqmp5LJIP5erh3o6efRwHKpHxj4BP27SZBnaKUE8e9kMLj8S7Gcs54VlA8LnBjwdNElPxDoo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773829967; c=relaxed/simple; bh=okJA4/r2gaoYw0ua1vM28wt9Waeo3cqzGJKL6uO/3H8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qOX99wrKstpOxHdry41b2X+WCdsqU2dI/wGNuMmDdHaVt8wv+2n4i2OGU0VoG66/+OFW5T7CK5BcF3DVmeMIRkpTYHjw7gSVFHe/cXXcIWdrTofVRUEbPiMJQwzAcnD9XMyAsHQUPADpnTWJSlsWOtp13h2kCUAm2SxHNxpjQzE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IH10axvH; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=aziNxNNS; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IH10axvH"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="aziNxNNS" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62I8m4D42296910 for ; Wed, 18 Mar 2026 10:32:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= bzdMmpvsAIDS69rtM/Jnx1k+GVl/CMYeNLOiAyJ+tQ0=; b=IH10axvHmTzUaSmy dW9JcmNBz/0KEF0nuyDz0CuUzLHAa7qX5Uof1O9v92D0cjqwvHthaWuHA74EH3S4 IYeXyNiiAMZEN871whbNdWqym44KsJFceV1SD56b4C22sPJvEI2IrVR49w0ac9Pk 4IU0IQjL1KUT+OKvuPp39IXC5hUxlwuOiJP6j+eIq7+02SXpls4hmdLab21JSz5L LqRhArWwkESLXg8AA+10ypJbzCMWqO5ZxzUNMOVpCJz6YxWF/DJBpA56ChJk+/e5 YWyhPRV3dKQeTYNw0jQ0W70pSsskI17iWBrWWka8SJWk4xAHW/hjlQ1s+DRpsCo/ rITurA== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cya83ux9g-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 18 Mar 2026 10:32:45 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-c737b6686ddso468947a12.3 for ; Wed, 18 Mar 2026 03:32:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773829965; x=1774434765; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=bzdMmpvsAIDS69rtM/Jnx1k+GVl/CMYeNLOiAyJ+tQ0=; b=aziNxNNSDndEdb2qj9wtU/AADXmbNJWmKkFrDFzpodGADxd8IPs9DuEY6wDV6Lmhu9 UmyuY4mfRrSde0SnUFMHzCVYKJm5HbQ1GzEQeFvTu1HHeA43opqgK9c1QZHaMxq9iKWf WK4nFi47bl5sLFSI4yOrGkDHUf3WE2rMD0H0GOAQH/nDrAb70LsRPpxyjlle+dXe0Pey 1Nmsx3ZG05xBpjTHL670evQ9uhGKBmg5VSiHvZmqbyCfTtu5w3oGHLVq3Emky8IShogi a03527tb4J7Jn7xK4eCWdFpz62wwEqrDnEgzWfLFCDBaevLdCYLe/FLdwF4qJZXiC34J BPCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773829965; x=1774434765; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bzdMmpvsAIDS69rtM/Jnx1k+GVl/CMYeNLOiAyJ+tQ0=; b=SJIYoAY7OUAz0jrDywxvkc6ifr4nIeOjsu6slwK3Q5vpTkzWMvaAxfktPVWSQoEmAI V5ao0BbG4qMbBQh9K5kym8gRh/04iEuMDQU21DIfZBaP6vzOSVhlCvRRenCdHQKJnynZ 5jor56foQ0OyVZuwNXShW4XQub4CSko5YrYMH4vXbKeSU3ZLVuhQTOoaCHv5LiT2FRnt 3UfKR6QbYoC59w/9a82SMjZc6gLNSCgktYIgBV/LITEy9aL84irxMD6KA23KsuAML21B cNwWsZDT43SBIrYzdQ80riSXlv8Bmnv1h6KtxxfNOLI72OQV2lp9K1WGtj0l1GFXyKj9 JmGA== X-Forwarded-Encrypted: i=1; AJvYcCUvRfVzsPf1i4AX6X8lixu2dN4p6ePBnxPtgm5L7+xr9ejT5TCsl6n0HMDhkQSSS5zMwF7JGtfMdxSU/zw=@vger.kernel.org X-Gm-Message-State: AOJu0Ywk41WU9tcMDmgB0voqA45Sz3XBP20mVjNIfrSr37guIPI23CBW Qv+/7C/8+ahixXItHoEl3j9151WthcInBbd2IW5a37A1yyjxdoYiYPpCiDtcc1K731bEQXO8VnD QBFN3c8DaXZu3Z4Sncv3ngshNvuGAfdysGAS9QiAhYG8zgzEG6N92K4E/k8bOe5ZbnWM= X-Gm-Gg: ATEYQzyJxyGvPtfpXtDWOSc3A/1AMiFW+7HBwEfAnLdDF/qIkI5JIqtfGY4AErZnhkE 7CSopG6RaSnFfB0p9tgmL8A50FNQe46CvJRlwSya3ZPIQjEbuVu9PwuWfcAA0oaukLkq/PSEflK 7N1YOoxR9uPrBvl22wQnDU/tzcoJ1JRA7XkFEHQV/0aAyxMawg/cGSf/5K9NNyXnNnyQ+K6KlAA 0/r7JxIBPmu+fDrH6+6UWBztUzb/jRrhLEIUtE2FtdGptuBbJYeWC5RhEGejVmcoN6VXZgVgX7O AXGoF5iskKANtkGTqTkZzOQ69IhNpMSdZhQkSbwnN7EZkB5zmAwAkCVkvkxVX6Z2UnR008hkOzP S7X/YYnFPefBCjdPM5AVA1nAU2Qc1mHbYGd9owun4vOBG4cX3zwY= X-Received: by 2002:a05:6a00:8007:b0:829:8a84:b9fc with SMTP id d2e1a72fcca58-82a6ac11ccbmr2421995b3a.8.1773829965000; Wed, 18 Mar 2026 03:32:45 -0700 (PDT) X-Received: by 2002:a05:6a00:8007:b0:829:8a84:b9fc with SMTP id d2e1a72fcca58-82a6ac11ccbmr2421972b3a.8.1773829964545; Wed, 18 Mar 2026 03:32:44 -0700 (PDT) Received: from [10.217.223.121] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82a6b56de13sm2877864b3a.20.2026.03.18.03.32.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Mar 2026 03:32:44 -0700 (PDT) Message-ID: <2b144a3b-4edb-4ee6-9ed8-625b75686955@oss.qualcomm.com> Date: Wed, 18 Mar 2026 16:02:35 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 02/12] dt-bindings: crypto: qcom,ice: Require power-domain and iface clk To: Krzysztof Kozlowski , Dmitry Baryshkov Cc: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich , Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio , Kuldeep Singh References: <20260317-qcom_ice_power_and_clk_vote-v3-0-53371dbabd6a@oss.qualcomm.com> <20260317-qcom_ice_power_and_clk_vote-v3-2-53371dbabd6a@oss.qualcomm.com> <7dqo6qbpwgltnf7xfgiogfdpb6f34fpwsxuksdpphjqjljzsr6@hwqv7wjarob5> Content-Language: en-US From: Harshal Dev In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: LwXY69Maf7cZoLX4gUlZWJ3qZ5vQw_3r X-Proofpoint-GUID: LwXY69Maf7cZoLX4gUlZWJ3qZ5vQw_3r X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE4MDA4OSBTYWx0ZWRfX93lgCezaC4Hn QZamgR6RjLeAFzioO6pImYZQzR2fsyu5x2FUySPJ5qkmqP+1ZdGg50Ujbv72OonIdwBMAF7UwZU o6ttHty46te7iox/t1M2XDIhUgb6NPuKVe6E7TqztZEopgb6JufLHycRNY8LaKw/qEA/VQLgyK6 CGU6uAHS8BOTxFN7dyP9Qs0R+xDQ4r/EMZUEkJdYefbG1rQwMLmVLJeW/HyxFvvXfFXcC+hNHUT ow6CPrv7PiDjQ/kZse28iUsN1fNKX3guUHc2sBveu+ZD1d35wqLz9L1cFgu+Ko+Ohicj8cs9xwh JV5IWfIVbhsE3dxB8jqbewUhuBeb2KmHh7+boMUp8q3LcFW3nNOhiNBaEaPKP56Lz46/USFCB9G yLSx/CyPFXTbpYHeM0cKwuLHI/bYt/xtQF+PS1FLWrK/A+ePQqKCe3cE0LqFTkWGLMK6bSqm/HO 5ok5fwKX2JBvXp489zg== X-Authority-Analysis: v=2.4 cv=Y8n1cxeN c=1 sm=1 tr=0 ts=69ba7f4d cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=Rh5YJenaxsb_U_NeXlQA:9 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-18_01,2026-03-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 bulkscore=0 impostorscore=0 phishscore=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603180089 On 3/18/2026 12:57 PM, Krzysztof Kozlowski wrote: > On 17/03/2026 16:13, Dmitry Baryshkov wrote: >> On Tue, Mar 17, 2026 at 02:50:41PM +0530, Harshal Dev wrote: >>> Update the DT bindings for inline-crypto engine to require the power-domain >>> and iface clock for Eliza and Milos. >> >> Again, this mostly duplicates the subject (and your last paragraph). >> Either drop it or move it there. >> >>> >>> If the 'clk_ignore_unused' flag is not passed on the kernel command line, >>> the unused 'iface' clock could be disabled by the kernel before ICE can >>> probe. This leads to unclocked ICE hardware register accces being observed >>> during ICE driver probe. On the other hand, If the 'pd_ignore_unused' flag >>> is not passed on the kernel command line, the unused UFS_PHY_GDSC power >>> domain could be disabled by the kernel before ICE probes. This results in >>> a 'stuck' clock issue being observed when ICE attempts to enable the >>> 'core' clock. >> >> What's the difference from the previous patch? > > > I asked to POST A PATCH targeting current RC. One patch. Current RC, not > next. Ack, I will merge the changes in this patch into the previous patch to ensure we have one consolidated fix for the current RC. Regards, Harshal > > > Best regards, > Krzysztof