From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932774AbcKNO71 (ORCPT ); Mon, 14 Nov 2016 09:59:27 -0500 Received: from mail-wm0-f50.google.com ([74.125.82.50]:35430 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932301AbcKNO7Z (ORCPT ); Mon, 14 Nov 2016 09:59:25 -0500 Subject: Re: [PATCH v3 0/9] Qualcomm video decoder/encoder driver To: Javier Martinez Canillas , Hans Verkuil References: <1478540043-24558-1-git-send-email-stanimir.varbanov@linaro.org> Cc: Stanimir Varbanov , Mauro Carvalho Chehab , Andy Gross , Bjorn Andersson , Stephen Boyd , Srinivas Kandagatla , Linux Media Mailing List , Linux Kernel , linux-arm-msm@vger.kernel.org From: Stanimir Varbanov Message-ID: <2b178a80-2fa1-de90-a675-470150d07cf9@linaro.org> Date: Mon, 14 Nov 2016 16:59:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 11/11/2016 02:11 PM, Javier Martinez Canillas wrote: > Hello Hans, > > On Fri, Nov 11, 2016 at 8:49 AM, Hans Verkuil wrote: >> Hi Stanimir, >> >> Overall it looks good. As you saw, I do have some comments but nothing major. >> >> One question: you use qcom as the directory name. How about using qualcomm? >> >> It's really not that much longer and a bit more obvious. >> >> Up to you, though. >> > > It seems qcom is more consistent to the name used in most subsystems > for Qualcomm: > > $ find -name *qcom > ./arch/arm/mach-qcom > ./arch/arm64/boot/dts/qcom > ./Documentation/devicetree/bindings/soc/qcom > ./sound/soc/qcom > ./drivers/pinctrl/qcom > ./drivers/soc/qcom > ./drivers/clk/qcom > > $ find -name *qualcomm > ./drivers/net/ethernet/qualcomm Also qcom is the vendor prefix used in [1] [1] Documentation/devicetree/bindings/vendor-prefixes.txt -- regards, Stan