From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92FDD42F6F5 for ; Mon, 6 Jul 2026 21:26:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783373165; cv=none; b=Y739LapxaijFwy2/2++tp4GpcUJxC9UdL5z/OSOkORGcCsJNk+xOFUhMMfRKDffYbmggH+pQQl+KMLnwzcp4kAX4OOz+HzWCG+gMJqUJoMd8Q4fix/Hykf4p52nPOuTNijhQOiGD0iLiNnSaIpPpqtf2ICFMRMiaLLF9ItpchUY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783373165; c=relaxed/simple; bh=GHu8E+ZzIjl1pCy9QBxel1fS5I4F/Qa4IkmUrQYcut0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TPeGGI4KqoSC4j/9RbkmWuKZYZGto8VCIemMFjy6Mh8L6zc2bgcJINqZNRRPfWeShYXlJAZSkLQ6NBwi+ud8nGgAgrK/SfWKzV+lD36xfvv8Tlif3XEHvJENArxhWVGWpgh/k86l9gzzKapmfL4NFMQQU5HLbqmvEH3b3B5aVQ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=r017DZ2y; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="r017DZ2y" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-493c2c0b9a8so31224165e9.1 for ; Mon, 06 Jul 2026 14:26:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783373162; x=1783977962; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ihP68MSIVTxfpMWP1SL0q+2pdJ2V1J6RQAuUgDHhRvQ=; b=r017DZ2y+ltqd6XNJksy7oeelsuhCj80XVAzVCweQtH04ubhbpawn9W3jgTJnJaDOG NV6qtsLtB58SVVjHIqrdA3SlRn1yakUCPEj6MrUMLS+lSIsOxUM281NYOzHuG9vRh+Ao EIWsWlE5kLwdjVcA6le3Zc3tXQnVgjRW8tsjR0yCfXaWscd59BmyPJbPOtWHLorzgqkE B599hS+4Gk4Io0jYLyR7e1x/jFt+a9U3lWuo5biaddnUzlNBHHVzfTZMVZfprle38qyp ZlQLDtVCb4u0mDi9K9drLpI6qliiP3mj2yv5NAdkOAQsNzM3LU1j/NttTxTEQrhnSYA8 ZfZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783373162; x=1783977962; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ihP68MSIVTxfpMWP1SL0q+2pdJ2V1J6RQAuUgDHhRvQ=; b=aAaa0RycRRQAVQ5KJOGsP+d6VoB5k+hJNe5iE10oV6BEDSyYHwU7kN+EKZdFHnhFMe Wd0oQC3LL6zlqXE/DV8NFbQEtkkFF8f8R0TNcvHr3YcPuxbxkqjz36bGdKQr9XC1rxR5 YmRnUhzmhw3wYVt8PU89AKaIAJEawdgDMzDa6dC/pRMr55n0cz/lAqtsNnPJVxSkZ0Wu w5UAz9XHoOg21OUqafFRapFwFbrkLj3gBN3IxBJre5aPBA+w0Nt4bD9d9o7p08M91sOH wtpaqRlnDI/kuosdexmZVGfMEBUDrc4vSgtupeFjD1rOQZ/fdAnXr6I3yiF2xdTeBNMu hNzw== X-Forwarded-Encrypted: i=1; AHgh+RpJVDGKYjrriC1HTuyLcUpJO5Ea1V6NQ+Pl9/iWR89bQssSZx8XjxNKhBJXl5W5FNfGvmj7hSO5AVwe1K8=@vger.kernel.org X-Gm-Message-State: AOJu0Yx4/W+xjhKmHmHFBQ6oQJPpIhAoiTS6Q3+lI/o+aWn0cBs+Kih/ QzNj1b+T16guyevZQbKotO1E9VjcQ0AN5EGBRmrRW1g6XLgIfgGbP52R X-Gm-Gg: AfdE7clumXMbGndG6LXQl32r20GftroFN5irit56feTgUO0K5q/9ocwhjKFw09vJ0B8 EFP3kwlcn9f/OqnV/QzVS8sp2R84DfwhQ9/Ayn5VbZ15iqgDRAhtdJ8rL37oKjwDdh4wRyOwHkZ iJC+E3El9bVHfqae1GAY0VjbV7eSgB8S0GUE8hu48Ogbs7n7yQh4+MTuAi0BFu745LwDsr6scUQ K0dtcZQFHSctGkUI5melGgKb4LexR6ZAe37vkYE3s6p8Ct5CdVLsc8F/bODzisT7L5OvN8h5X6o jSBmGIH8BMrjEpl2KlpT1aDVyskWZPZsvr0nc9LRPu5t+vdBa7oSnTB/wliOqVLTUirFgRHszUs KSYTl3QY3fyZ8Qo4ako6PHXInZhJLwvIBn6KjlD/70mr8V9TO6ID0Bxh788wupUA4w5fT7SyOky 2VL0CiRLzHh3OpOtjlolCUHT+R X-Received: by 2002:a05:600c:1d0c:b0:493:bed9:b53d with SMTP id 5b1f17b1804b1-493df09b330mr24203455e9.31.1783373161558; Mon, 06 Jul 2026 14:26:01 -0700 (PDT) Received: from [192.168.1.10] ([95.43.220.235]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-493e01c8159sm12334715e9.1.2026.07.06.14.25.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Jul 2026 14:26:01 -0700 (PDT) Message-ID: <2b192691-54d8-4449-a18c-b87266c6c73c@gmail.com> Date: Tue, 7 Jul 2026 00:25:58 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/4] dt-bindings: phy: motorola,cpcap-usb: add chrg_det interrupt To: Conor Dooley Cc: Vinod Koul , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Aaro Koskinen , Andreas Kemnade , Kevin Hilman , Roger Quadros , Tony Lindgren , Linus Walleij , Bartosz Golaszewski , linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org References: <20260705101105.1798069-1-ivo.g.dimitrov.75@gmail.com> <20260705101105.1798069-2-ivo.g.dimitrov.75@gmail.com> <20260706-visitor-calorie-b805ac5af970@spud> Content-Language: en-GB From: Ivaylo Dimitrov In-Reply-To: <20260706-visitor-calorie-b805ac5af970@spud> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 6.07.26 г. 20:14 ч., Conor Dooley wrote: > On Sun, Jul 05, 2026 at 01:11:02PM +0300, Ivaylo Dimitrov wrote: >> The CPCAP USB PHY driver uses the CPCAP charger detection interrupt >> for DCP detection. > > This is not currently true, the driver does not look for this interrupt > at the time of this patch. > Right, this is bad wording caused by the fact that initially the driver patch came before the binding patch. >> Update the binding and example DTS to use the corresponding >> "chrg_det" interrupt name. > > Sounds to me like this new interrupt is optional, since until now it has > not been needed? The patch however makes it mandatory. I think your > driver patch also makes it mandatory, which will break older > devicetrees. > Oh, it is indeed not needed for proper DCP/SDP detection, after some experiments I was able to teach the driver to do proper detection by using current interrupts only. > What makes this ABI break okay? > Will send new series with schema/DT patches dropped. Thanks and regards, Ivo > Thanks, > Conor. > >> >> Signed-off-by: Ivaylo Dimitrov >> --- >> .../devicetree/bindings/phy/motorola,cpcap-usb-phy.yaml | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/phy/motorola,cpcap-usb-phy.yaml b/Documentation/devicetree/bindings/phy/motorola,cpcap-usb-phy.yaml >> index 0febd04a61f4..523a8f8480d0 100644 >> --- a/Documentation/devicetree/bindings/phy/motorola,cpcap-usb-phy.yaml >> +++ b/Documentation/devicetree/bindings/phy/motorola,cpcap-usb-phy.yaml >> @@ -30,6 +30,7 @@ properties: >> - description: se1 interrupt >> - description: dm interrupt >> - description: dp interrupt >> + - description: charger detection interrupt >> >> interrupt-names: >> description: Interrupt names >> @@ -43,6 +44,7 @@ properties: >> - const: se1 >> - const: dm >> - const: dp >> + - const: chrg_det >> >> io-channels: >> description: IIO ADC channels used by the USB PHY >> @@ -91,10 +93,10 @@ examples: >> interrupts-extended = < >> &cpcap 15 0 &cpcap 14 0 &cpcap 28 0 &cpcap 19 0 >> &cpcap 18 0 &cpcap 17 0 &cpcap 16 0 &cpcap 49 0 >> - &cpcap 48 1 >> + &cpcap 48 1 &cpcap 13 0 >> >; >> interrupt-names = "id_ground", "id_float", "se0conn", "vbusvld", >> - "sessvld", "sessend", "se1", "dm", "dp"; >> + "sessvld", "sessend", "se1", "dm", "dp", "chrg_det"; >> io-channels = <&cpcap_adc 2>, <&cpcap_adc 7>; >> io-channel-names = "vbus", "id"; >> vusb-supply = <&vusb>; >> -- >> 2.39.5 >>