From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 795A678F2F for ; Mon, 24 Aug 2026 13:17:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787577448; cv=none; b=esp0fXBlE0wc/ayO++MIRDPynUz1/U2RDgRlZD621au73UBlFGaTckCUyAN5blcysxK8vV/662khZva2u0h9NfDYqsLiziktWWT5+cHdKJZdF4Fq40wvxrWs5Gx3JAz+PhscLzKvGaxHbPmoNd5422izf8bua0sBOWOj8pWXpE4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787577448; c=relaxed/simple; bh=0sFqc3IUFqEyflaLicdgPilz7QNbaGGF7EcNt2ZorYo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JnjM+4kPyQZM6LbvLug4lQ6aSX+Rzs62OjfFjRxSjj4aqrO75yeinQ9Up2t9HvLFzCgpECpGfwBKDo70yiMOKNLqXg5Wx2vHBL7KxSNBoon/ulI+RI+GcIQG/yBp/JMkYF6i275q/5USubOhZ0ldhZlbLGI5V792+p241DLHRmQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=MyvUv0+u; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HUkz64nh; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="MyvUv0+u"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HUkz64nh" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67OCuvKo2949874 for ; Mon, 24 Aug 2026 13:17:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Tnp3mVv+VBCQVYi3QP6h/5zemYCms26RoK5XuVNMynM=; b=MyvUv0+uT9xblodW inR2ESKXfi2i/MYmnxDGXmaD3+heVXlWTgBUZeHI7tFtAWm7XN4ZI/JR2uMkiP3d b0rJRPNuYQrNyonn6A6ZWFyN5/T9MX3s8KV+ct56VBCBA8lBJ7LyDQq1W58W4UDx 5Shl7HTW3K4NfqUd4iUOj4Z67MPaNRXGPo435us9kTQPybq+T+v2mUVuIhsJlgAa ItJcbwMqI1NhkCyFGqDSExToB0D9PzMbgEY/4WvXmSog9Y8Dy1MZ3JWjiB6gffda egZ3i3M8yIPotzB2BwPPzwlze2DLNSbWok1s9w50Gfcd+hxUQof7OKNztKnMG7/c 5bsdnQ== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g8j7r19xc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 24 Aug 2026 13:17:26 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-93495488976so61760685a.3 for ; Mon, 24 Aug 2026 06:17:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787577445; x=1788182245; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Tnp3mVv+VBCQVYi3QP6h/5zemYCms26RoK5XuVNMynM=; b=HUkz64nhN2pb8VVHwS6PQx8JgBkiUfMTELR1hVB5eTXilXVUBb9vYUCQIw+ItODqZs f7IfqqwG/ZwoTvGAjcKjRfwILwf6paMC+a+hr9NEEX59jhVuK3X5Ryhnw+e+0B+1uxa0 a1eZihaI+8rjRfBAVooIkLsql/7DejjYQtL6nTQm2bmehKhjFDxmNFF6/1oYhvvYenJk pZCE0EExWE6uIFwOiCiUjsPaaJEmETzwhnb5/rAx99o10I298ryVVhdSkVJV5j237rYH I5XGQ7BUG9RyVlKzO02tYLgwCjV5i9MW7Yr9tv2TgJSI3dYFB+S559QhAIAkZ1ApSRKy gMAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787577445; x=1788182245; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Tnp3mVv+VBCQVYi3QP6h/5zemYCms26RoK5XuVNMynM=; b=hmYyVb/iFJpBsLLJRp9n2rGV98IHfwKLug39YX0+A3NEpiWYHy2aoLG4b5ScuY5wTg GiWmWDIA4X/Q2UZWQQqQAR3UadTEwrA5HYHUtnj1l/0iGHnNbGXhAlZSvSTSsIURifAb CPTYrCRReGWWl1PqUCYuWvO3f40QQyOfl49ztr7hLnc77TwZVfVMxJq2zdldQm7zBB7/ 0DpVX9SgbdzSBHW3C3VjAENFN7p9JLZxbYhAG+TcSLUOqYqdvtuwLrf6sO02XFlz/AWX KoM1nfkpVNL+7vldOmTOtdf4EHe7if+cEc2Qjam92eoXIypT/JvXES8p+1+Of+4snvNF /idw== X-Forwarded-Encrypted: i=1; AHgh+RpfmUAlJENvZVgh3EPvdjsN8/qO2O3KRKr9DkLuN3DH6crvZrAyRyz7GASC02WCk7GkeTCJ8yJFWAfsgPM=@vger.kernel.org X-Gm-Message-State: AFuF++mJnCQxRpXUd3J2uUf09hrep1Ba9jdshiBGIxfC5K+wi4nl4LJW oCZppcbFVeHnQqR3wW0V43Vu8u3hYrQqYLPlPqLqkktmtQXdJhwP0VeAEQhTi5M2AVrktkoPPl5 83bxAR/dv3tHwWOa2a7kzBW1W7VIhBjtGbriL39wdj+AWzEMIqT1H3W7NbttHJUQUmq8= X-Gm-Gg: AR+sD12KoCN+j8cB4n/PCbjoaOvU0IXV7NX3VYL2Pb0a29GLxqz1SjWSO38BSzM/xy1 lo/7oXoP5j6/81sr8Bvh3awP4DCXtHt5E6wdNk742I1aIwDdVpIVoxCw92Acf8h4cm363vmQ7Gd grXsyq4rukMdk0Lxb7CktcE3d5Nv1c0nDzxFvLtUXPP66CmYMeNjtaFUzpDSbbQY7cLY01F5WmF AHnrW14bXYFVCOJSYBbUCl08cf0MIPFD1hZJiBTo54aTIeoL2dEnmb/P7WrPsI5XOBEQW0GF+M0 b//rrFa5GPcYpzpofxNuXc5idsVxXnphH5z1zNNw/kxD+4LBWrsJJg7Rm9zfGIKZJPN/7tNAGfF fJpVSVDHYgfnv2q46eJbQIdsZ X-Received: by 2002:a05:620a:2806:b0:92e:6485:f640 with SMTP id af79cd13be357-937395ae7ecmr1681795185a.4.1787577445634; Mon, 24 Aug 2026 06:17:25 -0700 (PDT) X-Received: by 2002:a05:620a:2806:b0:92e:6485:f640 with SMTP id af79cd13be357-937395ae7ecmr1681791585a.4.1787577445186; Mon, 24 Aug 2026 06:17:25 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b48ce294a8sm1757332e87.81.2026.08.24.06.17.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Aug 2026 06:17:24 -0700 (PDT) Message-ID: <2b1e73f4-a476-4dc8-83f2-42be1008c1fc@oss.qualcomm.com> Date: Mon, 24 Aug 2026 15:17:20 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] drm/msm/dp: clear force_link_train flag when link training succeeds To: Saurabh Anand , Vinod Koul , Neil Armstrong , Manivannan Sadhasivam , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Ritesh Kumar , Vishnuvardhan Prodduturi , Mani Chandana Kuntumalla , Mahadevan P References: <20260824-qcom-dp-typec-reconnect-fixes-v1-0-2825e5bf8a96@oss.qualcomm.com> <20260824-qcom-dp-typec-reconnect-fixes-v1-2-2825e5bf8a96@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260824-qcom-dp-typec-reconnect-fixes-v1-2-2825e5bf8a96@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI0MDExMSBTYWx0ZWRfX+IQQZiBhXYQn Gs1vr75AkCpqUzmubt70+JtLviCoXBy/LSHHH/CrVSlfUvaYu5pCStqfh4XGpDSb/eYYls5g4MJ Y3ttJ/L03x7Y8Gf+opa5Q6TFFzyD5jYotY+a6+scp1JQxY6rKkVlZuRIAABGNdKZhMUNw6MzYqH ik2WUBvaL7chpz688/wAeal6rRPJAZvHSp/NLM5toTHpJ6b9g3X/nhnZmlkIq6w9bhyBmimZJ5W qysBl3tvHQuGM3Fy2ACMz5iw7X0JlMnHF9xCw//7gwS2KOKOjfl5teap0okXIoewo5esNxJDs9S a0wDCybq8iBDO8Q9bUs3OS16e3XTyj9tGf7vw0zXBLBebtIVQbD6vNMSYVzo8ql2Ukh/FJq3BPo Nj2yBf+T/2jsCO9+vCsh/jEz3otq1iybdeFd5mIIlgxoehpvyu8rlsoUBCDCKIVg3oZtBRc89gl ctCtNvdTWVO+IiXDxHA== X-Proofpoint-Spam-Info: AW1haW4tMjYwODI0MDExMSBTYWx0ZWRfX1x9ft31oECKG xgMlX2bfM2n9In6IU9C9Mb3rmSncOikCkpU2TJsAqw4tKH1buR65cUypElt5FauaSPvmBgUmFLA +DEn/p+Mcj5eoaD4nnHyqMVs7ZrIOmc= X-Proofpoint-GUID: xr4QsCWxk8pXTHVbaQIvOApkl0cxQn2Q X-Authority-Analysis: v=2.4 cv=IL8yzAvG c=1 sm=1 tr=0 ts=6a8c4466 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=NP0x2mC5TxarURSXHOEA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-ORIG-GUID: xr4QsCWxk8pXTHVbaQIvOApkl0cxQn2Q X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-24_04,2026-08-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 malwarescore=0 phishscore=0 priorityscore=1501 suspectscore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608240111 On 8/24/26 1:28 PM, Saurabh Anand wrote: > msm_dp_display_prepare_link() sets force_link_train = true before calling > msm_dp_ctrl_on_link(). On success the flag was never cleared, so > msm_dp_ctrl_prepare_stream_on() would unconditionally trigger a second > link retrain even though the link was already trained. > > Clear force_link_train on the success path so that > msm_dp_ctrl_prepare_stream_on() only retrains when the channel EQ check > fails, as intended. > > Signed-off-by: Saurabh Anand > --- > drivers/gpu/drm/msm/dp/dp_display.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c > index bc646d172abe..40e19d506a45 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -649,6 +649,8 @@ static int msm_dp_display_prepare_link(struct msm_dp_display_private *dp) > return rc; > } > > + force_link_train = false; > + > return msm_dp_ctrl_prepare_stream_on(dp->ctrl, dp->panel, force_link_train); This makes the argument of this function useless Konrad