From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: Vladimir Oltean <olteanv@gmail.com>,
"wg@grandegger.com" <wg@grandegger.com>,
Pankaj Bansal <pankaj.bansal@nxp.com>,
"Pankaj Bansal (OSS)" <pankaj.bansal@oss.nxp.com>,
"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
Joakim Zhang <qiangqing.zhang@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: canfdtest on flexcan loopback
Date: Fri, 18 Sep 2020 14:35:59 +0200 [thread overview]
Message-ID: <2b292dde-5385-035d-dc99-031d61ff67c7@pengutronix.de> (raw)
In-Reply-To: <20200918122716.kzxvocxelqwdw7uq@skbuf>
[-- Attachment #1.1: Type: text/plain, Size: 1740 bytes --]
On 9/18/20 2:27 PM, Vladimir Oltean wrote:
>> Is there a bug in v5.4.3? v5.4.66 is current latest v5.4.x
> commit 63d5320a0c9b9867628a3a5a12e7f11d4cc109c2
> Author: Paolo Abeni <pabeni@redhat.com>
> Date: Tue Feb 18 18:15:44 2020 +0100
>
> Revert "net: dev: introduce support for sch BYPASS for lockless qdisc"
>
> [ Upstream commit 379349e9bc3b42b8b2f8f7a03f64a97623fff323 ]
>
> This reverts commit ba27b4cdaaa66561aaedb2101876e563738d36fe
>
> Ahmed reported ouf-of-order issues bisected to commit ba27b4cdaaa6
yes, that's probably the the issue.
This concluded into using an old LTS kernel, is worse than using the latest
kernel :)
> ("net: dev: introduce support for sch BYPASS for lockless qdisc").
> I can't find any working solution other than a plain revert.
>
> This will introduce some minor performance regressions for
> pfifo_fast qdisc. I plan to address them in net-next with more
> indirect call wrapper boilerplate for qdiscs.
>
> Reported-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> Fixes: ba27b4cdaaa6 ("net: dev: introduce support for sch BYPASS for lockless qdisc")
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> Signed-off-by: David S. Miller <davem@davemloft.net>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> net/core/dev.c | 22 ++--------------------
> 1 file changed, 2 insertions(+), 20 deletions(-)
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-09-18 12:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <VI1PR04MB4093944944C574B138371F51F12F0@VI1PR04MB4093.eurprd04.prod.outlook.com>
2020-09-16 11:01 ` Vladimir Oltean
2020-09-16 11:04 ` Vladimir Oltean
2020-09-16 11:32 ` Marc Kleine-Budde
2020-09-16 11:45 ` Vladimir Oltean
2020-09-16 12:01 ` Marc Kleine-Budde
2020-09-16 12:14 ` Vladimir Oltean
2020-09-17 12:59 ` Vladimir Oltean
2020-09-17 13:10 ` Marc Kleine-Budde
2020-09-18 12:27 ` Vladimir Oltean
2020-09-18 12:35 ` Marc Kleine-Budde [this message]
2020-09-17 2:28 ` Joakim Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b292dde-5385-035d-dc99-031d61ff67c7@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pankaj.bansal@nxp.com \
--cc=pankaj.bansal@oss.nxp.com \
--cc=qiangqing.zhang@nxp.com \
--cc=vladimir.oltean@nxp.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®