mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Csókás Bence" <csokas.bence@prolan.hu>
To: Tudor Ambarus <tudor.ambarus@linaro.org>,
	<linux-spi@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Cc: Varshini Rajendran <varshini.rajendran@microchip.com>,
	Mark Brown <broonie@kernel.org>,
	Nicolas Ferre <nicolas.ferre@microchip.com>,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	Claudiu Beznea <claudiu.beznea@tuxon.dev>
Subject: Re: [PATCH v2] spi: atmel-quadspi: Create `atmel_qspi_ops` to support newer SoC families
Date: Wed, 30 Oct 2024 13:37:52 +0100	[thread overview]
Message-ID: <2b310b54-c215-40fa-b6d4-81faf75a8c9e@prolan.hu> (raw)
In-Reply-To: <7cc95e52-7509-44eb-8e30-d518283e7d87@linaro.org>

Hi,

On 2024. 10. 30. 12:09, Tudor Ambarus wrote:
> I think it's fine to split sama7g5 addition in smaller steps. But please
> add the sama7g5 support in the same patch set, otherwise this patch
> doesn't make sense on its own.

Well, actually, we're using SAMA5D2. My goal was just to somewhat 
harmonize upstream with the vendor kernel so that we may contribute 
other patches that we have made on top of the latter, or in the future, 
take patches from upstream and apply it to our vendor kernel-based tree. 
This patch was only meant to lay the groundworks for future SAMA7G5 
support. I can of course send the "other half" of the original patch if 
needed, but I wouldn't want it to hold up this refactor.

> Also, if you think you significantly changed the code of authors, I
> think it's fine to overwrite the authorship. Otherwise, try to keep the
> authorship and specify your contributions above your S-o-b tag.

I don't know if it counts as "significantly changed", I split out parts 
of a patch that were relevant for our device, and made small adjustments 
to make it correctly apply to master. I didn't find a descriptive enough 
tag for this, so I just went with Cc:, but if so desired, I could change 
it to a S-o-b, Co-authored-by, Suggested-by etc.

Bence


  reply	other threads:[~2024-10-30 12:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-30  8:44 Csókás, Bence
2024-10-30 11:09 ` Tudor Ambarus
2024-10-30 12:37   ` Csókás Bence [this message]
2024-10-30 12:49     ` Tudor Ambarus
2024-11-04 12:48     ` Alexander Dahl
2024-11-04 12:56       ` Csókás Bence
2024-11-05  7:47         ` Hari.PrasathGE
2024-11-15 13:23           ` Csókás Bence

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2b310b54-c215-40fa-b6d4-81faf75a8c9e@prolan.hu \
    --to=csokas.bence@prolan.hu \
    --cc=alexandre.belloni@bootlin.com \
    --cc=broonie@kernel.org \
    --cc=claudiu.beznea@tuxon.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=nicolas.ferre@microchip.com \
    --cc=tudor.ambarus@linaro.org \
    --cc=varshini.rajendran@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®