From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D340C77B73 for ; Mon, 10 Apr 2023 13:36:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229792AbjDJNgB convert rfc822-to-8bit (ORCPT ); Mon, 10 Apr 2023 09:36:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229536AbjDJNf6 (ORCPT ); Mon, 10 Apr 2023 09:35:58 -0400 Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BBE624C09; Mon, 10 Apr 2023 06:35:54 -0700 (PDT) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id EF6EC24E171; Mon, 10 Apr 2023 21:35:44 +0800 (CST) Received: from EXMBX164.cuchost.com (172.16.7.74) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 10 Apr 2023 21:35:45 +0800 Received: from EXMBX168.cuchost.com (172.16.6.78) by EXMBX164.cuchost.com (172.16.6.74) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 10 Apr 2023 21:35:44 +0800 Received: from EXMBX168.cuchost.com ([fe80::3c2d:dee5:4938:3fc4]) by EXMBX168.cuchost.com ([fe80::3c2d:dee5:4938:3fc4%16]) with mapi id 15.00.1497.044; Mon, 10 Apr 2023 21:35:44 +0800 From: JiaJie Ho To: Herbert Xu CC: "David S . Miller" , Rob Herring , Krzysztof Kozlowski , Palmer Dabbelt , Emil Renner Berthing , Conor Dooley , "linux-crypto@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-riscv@lists.infradead.org" Subject: RE: [PATCH v4 4/4] crypto: starfive - Add hash and HMAC support Thread-Topic: [PATCH v4 4/4] crypto: starfive - Add hash and HMAC support Thread-Index: AQHZa3+jdYvISdTjqUmPzN0mADxyja8jpS2AgACU6YD//5HogIAAsqtQ//+FIACAAIes4A== Date: Mon, 10 Apr 2023 13:35:44 +0000 Message-ID: <2b33000067d54d9e83d5a81ef102d2a9@EXMBX168.cuchost.com> References: <20230410073752.39506-1-jiajie.ho@starfivetech.com> <20230410073752.39506-5-jiajie.ho@starfivetech.com> <6df549e9-d0f6-23ca-882f-527c4e40b553@starfivetech.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [161.142.156.149] x-yovoleruleagent: yovoleflag Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > The sequence of event would be: > > 1. Wait for DMA transfer to complete. > > 2. Set bit in device CSR to indicate final block has been transferred. > > OK, 2 should be done in the DMA callback function. > > > 3. Device will send IRQ once result is ready. > > 4. Read out final digest value from device. > > 4 should be done from a tasklet scheduled from the IRQ handler. > I'll update the driver accordingly. Thanks again for the advice. Regards, Jia Jie