mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: Kees Cook <keescook@chromium.org>, Petr Mladek <pmladek@suse.com>,
	Vijay Balakrishna <vijayb@linux.microsoft.com>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	John Ogness <john.ogness@linutronix.de>,
	stable@vger.kernel.org, Tony Luck <tony.luck@intel.com>,
	"Paul E. McKenney" <paulmck@kernel.org>,
	linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] printk: ringbuffer: Fix truncating buffer size min_t cast
Date: Fri, 11 Aug 2023 10:29:37 -0300	[thread overview]
Message-ID: <2b358118-e7b9-1f6d-aa38-306f537a5d93@igalia.com> (raw)
In-Reply-To: <20230811054528.never.165-kees@kernel.org>

Great finding! Thanks a lot for the report and the fix - oneliners are
usually the most challenging to debug.

Tested it in the Steam Deck, and it works perfectly - I saw eventually
one line or two filled with NULLs, now they're gone.
Feel free to add:

Tested-by: Guilherme G. Piccoli <gpiccoli@igalia.com> # Steam Deck

  parent reply	other threads:[~2023-08-11 13:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-11  5:45 Kees Cook
2023-08-11  6:16 ` Vijay Balakrishna
2023-08-11 13:29 ` Guilherme G. Piccoli [this message]
2023-08-11 16:53 ` Tyler Hicks
2023-08-14  6:20 ` John Ogness
2023-08-14  7:40 ` Sergey Senozhatsky
2023-08-14 10:42 ` David Laight
2023-08-14 12:56   ` Petr Mladek
2023-08-14 13:33     ` David Laight
2023-08-14 11:40 ` Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2b358118-e7b9-1f6d-aa38-306f537a5d93@igalia.com \
    --to=gpiccoli@igalia.com \
    --cc=john.ogness@linutronix.de \
    --cc=keescook@chromium.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulmck@kernel.org \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=senozhatsky@chromium.org \
    --cc=stable@vger.kernel.org \
    --cc=tony.luck@intel.com \
    --cc=vijayb@linux.microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®