From: "Andrew Jeffery" <andrew@aj.id.au>
To: "Billy Tsai" <billy_tsai@aspeedtech.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Joel Stanley" <joel@jms.id.au>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
"Ryan Chen" <ryan_chen@aspeedtech.com>
Cc: BMC-SW@aspeedtech.com
Subject: Re: [RESEND PATCH] ARM: dts: aspeed-g6: Fix gpio memory region
Date: Thu, 01 Oct 2020 10:02:21 +0930 [thread overview]
Message-ID: <2b3c4303-ef63-4c34-be00-ff59abc32e69@www.fastmail.com> (raw)
In-Reply-To: <b7bcc925-b0da-446f-84a7-1a564a1f4f83@www.fastmail.com>
On Thu, 1 Oct 2020, at 09:42, Andrew Jeffery wrote:
> Hi Billy,
>
> On Wed, 30 Sep 2020, at 18:36, Billy Tsai wrote:
> > Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
> > ---
> > arch/arm/boot/dts/aspeed-g6.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi
> > index 97ca743363d7..b9ec8b579f73 100644
> > --- a/arch/arm/boot/dts/aspeed-g6.dtsi
> > +++ b/arch/arm/boot/dts/aspeed-g6.dtsi
> > @@ -357,7 +357,7 @@
> > #gpio-cells = <2>;
> > gpio-controller;
> > compatible = "aspeed,ast2600-gpio";
> > - reg = <0x1e780000 0x800>;
> > + reg = <0x1e780000 0x500>;
>
> We took the 0x800 value from the memory space layout table in the datasheet for
> the 2600. Should that be updated too? Or are you just limiting the region to
> the registers currently described rather than the allocated address space?
Ah, actually, I see what's going on. We really have this layout (taking some liberties):
0x1e785000 - 0x1e785500: PGPIO 3.3V
0x1e785500 - 0x1e785600: SGPM1
0x1e785600 - 0x1e785700: SGPM2
0x1e785700 - 0x1e785740: SPGS1
0x1e785740 - 0x1e785780: SPGS2
0x1e785800 - 0x1e786000: PGPIO 1.8V
Ryan: Can you change the address space layout table to reflect this? That way it
still functions as a quick - but accurate - reference.
Andrew
next prev parent reply other threads:[~2020-10-01 0:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 5:11 [PATCH] ARM: dts: aspeed-g6: Add sgpiom/sgpios node Billy Tsai
2020-09-30 9:06 ` [RESEND PATCH] ARM: dts: aspeed-g6: Fix gpio memory region Billy Tsai
2020-10-01 0:12 ` Andrew Jeffery
2020-10-01 0:32 ` Andrew Jeffery [this message]
2020-10-01 1:11 ` Ryan Chen
2020-10-01 0:36 ` [PATCH] ARM: dts: aspeed-g6: Add sgpiom/sgpios node Andrew Jeffery
2020-10-05 1:55 ` Billy Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b3c4303-ef63-4c34-be00-ff59abc32e69@www.fastmail.com \
--to=andrew@aj.id.au \
--cc=BMC-SW@aspeedtech.com \
--cc=billy_tsai@aspeedtech.com \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=ryan_chen@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®