From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pz2-f1.google.com (mail-pz2-f1.google.com [74.125.228.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C213A3CF21F for ; Sat, 8 Aug 2026 14:29:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.1 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786199372; cv=none; b=MlvTiIC9FFIoQ4aVywTWuBoF+nMmQIZfbgkxVo4+A3pKTGCnb9J8/CxsDlEQZRgo7I753jJZB38Bw/OTQH31j13KKCWasb/L9sJlYzHXmqaY/av73qh1dmWG+qCaVUEqrzcPEgGC9iZlBOu2hd3IlTwansplnyjNMpq/svFncnw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786199372; c=relaxed/simple; bh=bptTALW6R8bnxOtse24KWu7lJf0Yrq1VbtD7l4NArTk=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=bk9wrVGdvQzeImhr3/EDFDSQd8tJ50U1+JFzjpXxzw3WW/Mf0Pi6yD5Wm1JZJyB3vPSkznO3BhW7fP3FPReadraEDSvKAMmIvTgJxdjCzaHedflFWgqni6hcyLz2t2z/vlbPa0+eLAL3MaSZPxlDzs8wwb7MxPJEws+XqJTVlMY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nroSgcbN; arc=none smtp.client-ip=74.125.228.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nroSgcbN" Received: by mail-pz2-f1.google.com with SMTP id 41be03b00d2f7-cbb818e57c9so286501a12.0 for ; Sat, 08 Aug 2026 07:29:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786199369; x=1786804169; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:subject:cc:to:from:message-id:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=7CZYGhkXjoLPOZDdCP+ZBeQkJbqW9Nm3A99Ju9rkXbI=; b=nroSgcbNcOl6BQloJQbxOFJup1KvPh/sBQAH7PcNgzFpPpDhzEyl8lqwwDPKGuRovi dcOqFz9UwKVeYgx+Kf/Vd8Z1cODVRXJOwKNu16pQkuaP+0twPQ8RbxaLSjTX52XpwPZd Xz8uFeeQFkdnAdqxGSRVfv1+k0by4+KO7nolBgy89P4epgJnbZzn2SYB15Y/YkDK4fw2 I0J2vM9vFXBnv8Mn+4teJbNoyIQkgOhwN9c0mT0YBLLZYMrjThkK681xkl3twQLS2v4T tXLGkBrEH9auq/aM3sPxdmk48KnmEhyANyM0EE6ZDOxjJxktl7YNJSHJryJjel/JIiue YEQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786199369; x=1786804169; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:subject:cc:to:from:message-id:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=7CZYGhkXjoLPOZDdCP+ZBeQkJbqW9Nm3A99Ju9rkXbI=; b=B6kD3fyh7lFGLcUokiEH3tKmFjPMuxiLfeRVG6e++/I2Q1lc6zG8r53KqvpRdNBKd8 xN/99ViAbLCDOi9m5xa7N7Td6fxbzVWE1K5tAFQqtuwpZV65pIUekiVg64QOhR6uzE2/ n2p7acIHdp2wU6lAQ5oa1Zd4P1K+PHFqv7/bJvo+QJm4HGszFUFzqz4U8fdlGtBHPDFs nPPoIZ/gNQtpYyqHoXkVGPEi7qlhTg6NI0T69Pn6nIB+arky+uJ0Ba3b9LyvO5a994iA XXJZUMnPZSx2JAta4tidGbvcX7I2AvfqD9gS/Jw4OHuYxtBvnwl07uYfcoNkfcBMzcLs XxJQ== X-Forwarded-Encrypted: i=1; AHgh+Rrx5GLzdqWkR0VHv5x5cRm+LXEY1slMRbd808bYleTNg53RTt+kUElSEOXyKBipq5Lhmf1qiJUMCGFIRTE=@vger.kernel.org X-Gm-Message-State: AOJu0YxaDFPxPKlWCBGlPfFh4lNUhzr3dx3Ryyno5su5OXhsPmuAuEZI 6cPIU3gFkkrDl6dR/VLWNHseH/xZ94pk2ECz1vwggPlUwHdcdpnVMwh8 X-Gm-Gg: AR+sD13wgpff1+4hkSWEdPwIt4hZlLIFpoYAt1hHzZ3iRPL1euxin5SZuVD9/MD/a1c WES+/sIV801CROSRbMzbRGKDjZ5sk+CSHteLRE1LdRApjO0pkH5+9SZT2IIGzW2C0azA9oqSVKV 0gbKTzYtBa4G9ffyJWnNM8ZviqpBJokT6WEC1LwSBktF+wTtCEqK+2IrVilmLVnhVP332oOOFMv AtKw7clrhvTos5FaB3vzlIfbjLuZv1TSZ+3Kw3m1VeaUr3vREYG1+TmpzptwqYsUEJMBlMX0ljM WlzUl3ExBzVPB8BQZvB4bOAU5+9deVSlU/SZwl+nvFh0X4KDvi9VBoqJlpnOR3As9Mia0s4AiyI PL+hXWvJFmddMWEkvC4a6kCXAsU07phqsWJzR03+tLiqLkz9zqxu8JfdTuVbOCLAlqXk3LJihkL v4LJ24UbgN+/bYMWdzjs0PBrAVU7R2QdhAgha7DUE= X-Received: by 2002:a05:6a00:278b:b0:848:7b92:8e74 with SMTP id d2e1a72fcca58-84f2e0dc994mr36524222b3a.39.1786199369200; Sat, 08 Aug 2026 07:29:29 -0700 (PDT) Received: from localhost ([2403:2c80:17:1e::20db]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84f5a3cad9dsm2140077b3a.23.2026.08.08.07.29.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Aug 2026 07:29:28 -0700 (PDT) Date: Sat, 08 Aug 2026 22:29:25 +0800 Message-ID: <2b3c661bf7e1d437f81e4b7da13be25d.codykang.hk@gmail.com> From: Cody Kang To: Rob Herring Cc: David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Krzysztof Kozlowski , Conor Dooley , Yixun Lan , Vinod Koul , Neil Armstrong , Haylen Chu , Michael Turquette , Stephen Boyd , Brian Masney , Philipp Zabel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , dri-devel@lists.freedesktop.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-clk@vger.kernel.org Subject: Re: [PATCH RESEND 04/17] dt-bindings: soc: spacemit: allow eDP/DP PHY PLL pixel clocks on K3 APMU In-Reply-To: <20260807230824.GA2220945-robh@kernel.org> References: <20260725-k3-display-v1-0-6de34d80e86c@gmail.com> <20260725-k3-display-v1-4-6de34d80e86c@gmail.com> <20260807230824.GA2220945-robh@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Hi Rob, On Fri, 07 Aug 2026 18:08:24 -0500, Rob Herring wrote: > On Sat, Jul 25, 2026 at 12:51:13AM -0400, Cody Kang wrote: > > The APMU's eDP pixel-clock muxes select the DP PHY PLLs as parents, so the > > K3 syscon takes two clock inputs the other variants do not have. > > > > Gate them behind the K3 compatible instead of widening the shared clock > > list, so a non-K3 syscon cannot silently accept clocks it has no mux for. > > > > Signed-off-by: Cody Kang > > --- > > .../bindings/soc/spacemit/spacemit,k1-syscon.yaml | 30 +++++++++++++++++++++- > > 1 file changed, 29 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/soc/spacemit/spacemit,k1-syscon.yaml b/Documentation/devicetree/bindings/soc/spacemit/spacemit,k1-syscon.yaml > > index d3a7c93c3c54..b8fc6632a392 100644 > > --- a/Documentation/devicetree/bindings/soc/spacemit/spacemit,k1-syscon.yaml > > +++ b/Documentation/devicetree/bindings/soc/spacemit/spacemit,k1-syscon.yaml > > @@ -31,14 +31,18 @@ properties: > > maxItems: 1 > > > > clocks: > > - maxItems: 4 > > + minItems: 4 > > + maxItems: 6 > > > > clock-names: > > + minItems: 4 > > items: > > - const: osc > > - const: vctcxo_1m > > - const: vctcxo_3m > > - const: vctcxo_24m > > + - const: edp0_pll_pxclk > > + - const: edp1_pll_pxclk > > > > "#clock-cells": > > const: 1 > > @@ -95,6 +99,30 @@ allOf: > > - clocks > > - clock-names > > - "#clock-cells" > > + # Only the K3 APMU exposes the two eDP/DP PHY PLL pixel clocks as extra > > + # inputs (parents of its eDP pixel-clock muxes); every other variant has > > + # the four base oscillator inputs only. > > + - if: > > + properties: > > + compatible: > > + contains: > > + const: spacemit,k3-syscon-apmu > > + then: > > + properties: > > > + clocks: > > + minItems: 4 > > + maxItems: 6 > > + clock-names: > > + minItems: 4 > > + maxItems: 6 > > + else: > > + properties: > > + clocks: > > + minItems: 4 > > + maxItems: 4 > > + clock-names: > > + minItems: 4 > > + maxItems: 4 > > 4 is already the minimum, so it can be dropped on all of these. Thanks for the review. Will drop them in v2. Cody