From: Deepak Singh Rawat <drawat@vmware.com>
To: YueHaibing <yuehaibing@huawei.com>,
VMware Graphics <linux-graphics-maintainer@vmware.com>,
Thomas Hellstrom <thellstrom@vmware.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>
Cc: <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH -next] drm/vmwgfx: Remove set but not used variable 'restart'
Date: Thu, 14 Feb 2019 11:58:37 -0800 [thread overview]
Message-ID: <2b3f7531e6bf4a2d9b6fdd1af07c6400712b3127.camel@vmware.com> (raw)
In-Reply-To: <20190214020804.22935-1-yuehaibing@huawei.com>
Thanks for doing this. Will include this one with next vmwgfx pull
request.
Reviewed-by: Deepak Rawat <drawat@vmware.com>
On Thu, 2019-02-14 at 02:08 +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c: In function
> 'vmw_cmdbuf_work_func':
> drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:514:7: warning:
> variable 'restart' set but not used [-Wunused-but-set-variable]
>
> It not used any more after commit dc366364c4ef ("drm/vmwgfx: Fix
> multiple
> command buffer context use")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c
> b/drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c
> index 70dab55e7888..ed15655eacd2 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c
> @@ -511,17 +511,14 @@ static void vmw_cmdbuf_work_func(struct
> work_struct *work)
> container_of(work, struct vmw_cmdbuf_man, work);
> struct vmw_cmdbuf_header *entry, *next;
> uint32_t dummy;
> - bool restart[SVGA_CB_CONTEXT_MAX];
> bool send_fence = false;
> struct list_head restart_head[SVGA_CB_CONTEXT_MAX];
> int i;
> struct vmw_cmdbuf_context *ctx;
> bool global_block = false;
>
> - for_each_cmdbuf_ctx(man, i, ctx) {
> + for_each_cmdbuf_ctx(man, i, ctx)
> INIT_LIST_HEAD(&restart_head[i]);
> - restart[i] = false;
> - }
>
> mutex_lock(&man->error_mutex);
> spin_lock(&man->lock);
> @@ -533,7 +530,6 @@ static void vmw_cmdbuf_work_func(struct
> work_struct *work)
> const char *cmd_name;
>
> list_del_init(&entry->list);
> - restart[entry->cb_context] = true;
> global_block = true;
>
> if (!vmw_cmd_describe(header, &error_cmd_size,
> &cmd_name)) {
>
>
>
prev parent reply other threads:[~2019-02-14 19:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 2:08 YueHaibing
2019-02-14 19:58 ` Deepak Singh Rawat [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b3f7531e6bf4a2d9b6fdd1af07c6400712b3127.camel@vmware.com \
--to=drawat@vmware.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-graphics-maintainer@vmware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=thellstrom@vmware.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®