mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: richard -rw- weinberger <richard.weinberger@gmail.com>
To: Tim Abbott <tabbott@ksplice.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [REGRESSION] um: CONFIG_STATIC_LINK=y broken
Date: Tue, 22 Dec 2009 02:10:06 +0100	[thread overview]
Message-ID: <2b41c200912211710m11f1ebbbjc3d30c67e9e49944@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.1.10.0912211944050.19919@dr-wily.mit.edu>

Adding the ALIGN(PAGE_SIZE) causes the segfault.
But I cannot tell you why. :-(

Cheers,
//richard

2009/12/22, Tim Abbott <tabbott@ksplice.com>:
> On Tue, 22 Dec 2009, richard -rw- weinberger wrote:
>
>> This is the bad changeset:
>
> Thanks for tracking that down.  INIT_TEXT_SECTION is:
>
> #define INIT_TEXT_SECTION(inittext_align)                               \
>         . = ALIGN(inittext_align);                                      \
>         .init.text : AT(ADDR(.init.text) - LOAD_OFFSET) {               \
>                 VMLINUX_SYMBOL(_sinittext) = .;                         \
>                 INIT_TEXT                                               \
>                 VMLINUX_SYMBOL(_einittext) = .;                         \
>         }
>
> So there are only 3 code changes here:
> (1) wrapping _sinittext and _einittext in VMLINUX_SYMBOL
> (2) Adding the AT(ADDR(.init.text) - LOAD_OFFSET)
> (3) The added ALIGN(PAGE_SIZE) before the start of .init.text.
>
> I don't yet see why any of these would be problematic; would you be
> willing to try them and figure out the precise cause?
>
> I suspect it'd be easiest for you to try those individual changes
> interactively, but if it's not trivial for you, I'd be happy to generate a
> patch series splitting out this change into pieces for you to bisect.
>
> 	-Tim Abbott
>

  reply	other threads:[~2009-12-22  1:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-22  0:21 richard -rw- weinberger
2009-12-22  0:27 ` Tim Abbott
2009-12-22  0:39   ` richard -rw- weinberger
2009-12-22  0:53     ` Tim Abbott
2009-12-22  1:10       ` richard -rw- weinberger [this message]
2009-12-22  2:13         ` Tim Abbott
2009-12-22 11:42           ` richard -rw- weinberger
2010-01-04 20:08 Tim Abbott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2b41c200912211710m11f1ebbbjc3d30c67e9e49944@mail.gmail.com \
    --to=richard.weinberger@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tabbott@ksplice.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®