From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63FA823EA94 for ; Thu, 2 Jul 2026 13:35:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782999327; cv=none; b=bEnw9kbUKKoGxgGQQHoJYHZGu9xU3I0VJhe20hInK5Ah3bAVlrtdnbPdvFhoWGbd3RJEu860H4w+c8HuKlAzAEh3pPSmL7EOy+15fT57oFk892Kwe91cPaAWUhU4zPn3xgYAFoAg0Nu8yOnf9eNHllALjC2Sa2dFW3ZqNhMuzx0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782999327; c=relaxed/simple; bh=E1/9DIDIMVTroh6AZSTdy0KhiA6AI5YzqTm9giWRgZE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gOx3YXut4Iu5LlmEtLp6Lp7fje+o26O/lMcjZNaItsNQxk0elHNklvVWKJMZClklE9cktB+80u5ftNTKY+mmy5n4TjqnLImCEuTgU1IzSA80227NR2OC+pMWNyPO8F0QfGHe7doYvu/MIMoNcAPbnWYgr0hh2ZrImtY29Tuu+H0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=X4VR7ffB; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=EMsWFrj3; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="X4VR7ffB"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EMsWFrj3" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 662D0bEt374302 for ; Thu, 2 Jul 2026 13:35:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= iP2L90DYVRpyRK2MWL9L9i4kUeULtc7huFI/8WNOEOU=; b=X4VR7ffBpKxKPjAV GAgRko8DSXI4y62ewp/0IhUfj/Yvv6lsC8NLfTDi8rf7PAqyoUnqgtL8IpQpbGF5 heHLgxa7V37vo+/RfGsoF+choyY4DWvUK3evZ+KSO3pLOvyziTpRiMAuvcLzA7/x X02PzURiKbChtswGdXkxMJnmOx0qE0rY5AVxklDJQmVdFGbrEmdPw4U11URLWkB0 +gk5utfZanMaK9xEcxoyPJYbAF0HbV44bbL6v9ViZrJ9FJTOC+WbR7nQ1o8SVbSl tMqreavqMJq55igFmCbwuAvkYfEY6oMo0ifFAyRyXCP1LKtniX7nM/Uc0vOAE63/ BdY1XQ== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f5npr8ure-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 02 Jul 2026 13:35:25 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-92e61b38eddso346611285a.2 for ; Thu, 02 Jul 2026 06:35:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782999324; x=1783604124; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=iP2L90DYVRpyRK2MWL9L9i4kUeULtc7huFI/8WNOEOU=; b=EMsWFrj3i0JcZ0hs3z+3/zxo0co42g5COc1dGKSdR7YGuJicZ7iWEb6v1nwJBDAibI P+W+HLEEsxoBDUSx6Wmw6zOGJdcLzhYEgH+HFLUJyvH+amR10hF7Y13awXk8a8+y8Y2Q venSReUDCG04u5f9q+Cxek+9Uh6ckt13Kt+cjByYjCcO9LEW1xb8g5l3SGHRR07IqgQV xHKO/5myr5d3zN6QEb3nBNsbIqIJbGqV7G+CrGlDnyqGJkof2e+x1rLHMy+CdpWZNs0V 9rrqWRdXBxTthwrKz/D4Bao1z99x4RLZpc+Rib8DuYs0lUaRbCspRKI+39hKgUj9NR5K p9mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782999324; x=1783604124; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=iP2L90DYVRpyRK2MWL9L9i4kUeULtc7huFI/8WNOEOU=; b=icZGSw3ozPwSLTYdZ/MtewqpM0j89FYrE3zgarAV/8DL+YFCJl6VVoMxq1rc2AUWkd u1YQ8h4Qa82KM3FLtwFnK5aHWPwyTH+uuldJqxPAbeDplO5mA43yzDeL+3nY8hxpa3Wf l9KsaeR5rYPlmRdKbCNyYT4YzpxDZ14n6K6uKXkSTprsA85vSjNEYS7APm0SlcuxgJzE sU3BQGWD3A/XK6znBOgZygPq+Up/yRVSD7GSvCUQHK1FXLmnhGbt0aQaSqqZFuskoUIV sGj/ut45OLhYXSiBEmR5D/SQpeTftT2DLdf2tpPIgDisVD6HpdoFAXxnI+oUF+LTCwWB /a1w== X-Forwarded-Encrypted: i=1; AFNElJ+a5Xk4CmuU0mOnLn3ZWMpDvvqj77qYFjTRUwI/lt/y/q0+zyAoLlQP64/HSQLF3yGROPayGkZ1rCGVlFk=@vger.kernel.org X-Gm-Message-State: AOJu0Yyhm+jq6nqyMuUGOEzUwMZfiaOxrflpxm+n61kehI3jCSYcveeT eLlJdXSWZ04zQ/AkyOzUI3CVeIYhwnUs4b4XDZI8dExd0roHnI2wFP0fAdo3pSUyuolgbkvNhVL 3zfBOlxviA3mI+saGPv+U5mIxkrqXPIQMIkdKwr3HBczbtaedaF62yLGM+61aWuFyVo0= X-Gm-Gg: AfdE7cmmWjgxoKBIQH15QjCDYnZFadXPLUaM5AkTYxtlYiC2zhG0/YE1bJmHG0BYu49 6JyYm0SLLTcKDFALXh8tvTd+KGVkpJvr/OPrBftwlujKwuHody8SAx9/TWKf/H6DTCLwT180Z4Y R5yjSz97rgnyoV+AI8x19zt8LK0L+43CF2vn9WmsiRfKSRbVn7oueZ1IpmRdPIm7gajDjY8b2u2 tgXq2wRTTsdDZXC7V7LWyb6yyVjByYHPDD6Egp69EvLY4oraHkfuilzYcvGaFxGNqgQMj+gaVrG HeQXLTpTQQAFTG0PXHe05JlAutjHQlWyDNT0yZhvmV0bAJaTNwZhmI1nmoQ3chqb5BRnvey2EC8 aszQS8MejWXiunqg7LgC4jHsgQaPcKyrP+BjpAhbhcPOn0H7nTUSDCHTKtQk7NLyLS1a626qi5g == X-Received: by 2002:a05:620a:2a12:b0:91c:d0b6:13f5 with SMTP id af79cd13be357-92e782408a0mr785674785a.19.1782999323789; Thu, 02 Jul 2026 06:35:23 -0700 (PDT) X-Received: by 2002:a05:620a:2a12:b0:91c:d0b6:13f5 with SMTP id af79cd13be357-92e782408a0mr785670185a.19.1782999323377; Thu, 02 Jul 2026 06:35:23 -0700 (PDT) Received: from ?IPV6:2a05:6e02:1041:c10:7d20:e20f:a77f:4ef7? ([2a05:6e02:1041:c10:7d20:e20f:a77f:4ef7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493c635c41dsm95373005e9.5.2026.07.02.06.35.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2026 06:35:22 -0700 (PDT) Message-ID: <2b51d68d-9f13-4b21-a0cd-32b78ceb5755@oss.qualcomm.com> Date: Thu, 2 Jul 2026 15:35:21 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] arm64: dts: qcom: x1e78100-t14s: Add thermal zones for keyboard skin and charging sensors To: Konrad Dybcio , sre@kernel.org, hansg@kernel.org, ilpo.jarvinen@linux.intel.com, linux@roeck-us.net, andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: bryan.odonoghue@linaro.org, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org References: <20260701103714.22583-1-daniel.lezcano@oss.qualcomm.com> <20260701103714.22583-3-daniel.lezcano@oss.qualcomm.com> <6bcfcd62-d831-4262-9ce9-66e12a72b3f2@oss.qualcomm.com> Content-Language: en-US From: Daniel Lezcano In-Reply-To: <6bcfcd62-d831-4262-9ce9-66e12a72b3f2@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: 9K7cd3YqVwMN01OeStRVwlgjCLDvvjDf X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAyMDE0MiBTYWx0ZWRfXwaByNsQ4iBXk Ac2RQFs+ZvZVintvEpn0eMT0ILLewZdwgWpf7xehlf4YNgvZ94qT3DsFPFLg4V1uvcv/4QmXhsw X+uxeRktx8/duhwj6nrLN98swhDb6bs= X-Authority-Analysis: v=2.4 cv=NsvhtcdJ c=1 sm=1 tr=0 ts=6a46691d cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=3fF9mxJG-zv1VSP5w2IA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-GUID: 9K7cd3YqVwMN01OeStRVwlgjCLDvvjDf X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAyMDE0MiBTYWx0ZWRfX+c+dG8gVy727 7+r3IMDUHvbQp/pfF/Cu4uW+pWtQLDlMqLLFB+m0nQZ9M0FePCBY/5YzdnHLSoV2Hn1RBvV9NXb xID3aQTT33hQW8nLXPGSh7i16RALm1Meoycbd2F1qCXqwLbDDHGf5XQ5r5nBh1Oj+8zyTEDJM+o lwX8RRcOPpeLtZK22az7AiJR6XRNUi4uNZDoitSR7TmOpegc93G6uihQfwU59u0/bEK1+0gZfXd c0QT9mlE2nvCRnfqtYAHthpZWWEHsg+9Xkg27/UEXdBnNmIFsmzWvwXMLx5amEUOyySBMZhWA2f F2sX3GZouOQXaOkRORTdegM7LzDyOaIob8olSFOzYpRZPpvWzO4Ffmi0UTQQRG+FlHuKupWCNGB D9pusAmMUh38x8JnU9BICHTt5rhP/f4Mhh9XXp15kAEODFZVKrWNqaEjnY5TLr1MJjN2/K+rdcB lCmfonK1OxFyFEbkqgw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-02_01,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 phishscore=0 suspectscore=0 malwarescore=0 adultscore=0 clxscore=1015 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607020142 On 7/2/26 14:17, Konrad Dybcio wrote: > On 7/1/26 12:37 PM, Daniel Lezcano wrote: >> The Lenovo ThinkPad T14s embedded controller exposes several platform >> temperature sensors that are already used by the firmware for thermal >> management. >> >> Expose the EC as a thermal sensor provider and describe the keyboard >> skin and charging circuitry sensors as thermal zones in the device >> tree. > > [...] > >> +&thermal_zones { >> + ec-keyboard-thermal { >> + polling-delay = <5000>; >> + polling-delay-passive = <1000>; >> + >> + thermal-sensors = <&ec 1>; > > Do you think it'd be worth to add dt-bindings defines to avoid raw > numbers here? No it is not worth. Usually we put raw numbers and they are untouched. > [...] > >> + cooling-maps { >> + map0 { >> + trip = <&ec_charging_psv0>; >> + cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, >> + <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, >> + <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, >> + <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, >> + <&cpu4 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, >> + <&cpu5 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, >> + <&cpu6 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, >> + <&cpu7 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, >> + <&cpu8 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, >> + <&cpu9 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, >> + <&cpu10 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, >> + <&cpu11 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; >> + }; >> + }; >> + >> + }; > > Stray \n above > > Otherwise: > > Reviewed-by: Konrad Dybcio Thanks for your review