From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Henrik Grimler <henrik@grimler.se>
Cc: Raymond Hackley <raymondhackley@protonmail.com>,
agross@kernel.org, andersson@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
nikita@trvn.ru, robh+dt@kernel.org, stephan@gerhold.net,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH] arm64: dts: qcom: msm8916/39-samsung-a2015: Add flash LED
Date: Sat, 2 Sep 2023 13:57:26 +0200 [thread overview]
Message-ID: <2b52c9b2-adf1-4622-9d0d-fe6599523174@linaro.org> (raw)
In-Reply-To: <ZOz4460Q/JQcMcU1@L14.lan>
On 28.08.2023 21:43, Henrik Grimler wrote:
> Hi Konrad,
>
> On Sat, Aug 26, 2023 at 02:09:38PM +0200, Konrad Dybcio wrote:
>> On 22.08.2023 17:01, Raymond Hackley wrote:
>>> Hi Konrad,
>>>
>>>> What about the other subdevices registered with the RT5033 MFD?
>>>
>>> Currently the MFD is not able to control the flash LED, due to missing
>>> driver for it.
>>> Alternatively we control it with GPIO pins. With driver leds-sgm3140, the
>>> binding is not under the RT5033 MFD.
>> Hm.. I have mixed feelings..
>>
>> Does the led controlled onboard this chip have some super complex
>> functionality that is going to be exposed through a specific driver
>> and that is not exposed through the sgm3140 driver?
>
> The rt5033-led&sgm3140 situation was discussed in msm8916-mainline
> matrix room before, here is a summary for list.
>
> Using the full rt5033-led driver (old patchset here [1]) has some
> benefits, like:
> * led can have different intensity levels
> * led can (supposedly) be used in strobe mode
>
> Using sgm3140 driver mostly works fine, but there could potentially be
> situations where led stops working and a reboot to stock android
> kernel is required to get it working again. So far that has only been
> reproduced by first booting a kernel with full rt5033-led driver
> (based on [1]), and then booting a kernel using sgm3140 driver
> instead.
>
> [1] https://lore.kernel.org/linux-leds/1448446948-13729-1-git-send-email-ingi2.kim@samsung.com/
2015, whoops..
Looks like the reviewers were mostly happy (style comments for the
most part), so perhaps it'd be worth to bring it back?
As for this patch, I'll be happy to take it if you can confirm the
rt5033-leds driver won't require bindings changes (i.e. the node
you're adding today would work fine as-is if you removed sgm3140
and probed the separate driver), at least in the form that it was
posted in the link above..
Konrad
prev parent reply other threads:[~2023-09-02 11:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 14:07 Raymond Hackley
2023-08-22 14:30 ` Konrad Dybcio
2023-08-22 15:01 ` Raymond Hackley
2023-08-26 12:09 ` Konrad Dybcio
2023-08-28 19:43 ` Henrik Grimler
2023-09-02 11:57 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b52c9b2-adf1-4622-9d0d-fe6599523174@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=henrik@grimler.se \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikita@trvn.ru \
--cc=raymondhackley@protonmail.com \
--cc=robh+dt@kernel.org \
--cc=stephan@gerhold.net \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®