From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC87030149F for ; Sun, 26 Jul 2026 11:00:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785063617; cv=none; b=lkgsRcQfmPaanebyTfHHwiFMw2blc/F5o2QhgfHmGm4/ECzkwOCkrCcKoHes36MhlHBScX1xUkHFAypQFLMLjD1Uy2yggsup7U34S2YbfNYQyt4oU8A9x3yVzoyPQIDWpw8CWbz1W517h2LphHRKGhIEzECsX8vIihkt00Y/Skg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785063617; c=relaxed/simple; bh=byvuZJYZYd2MSiuhVWfo6h4n7bx3BOovOl/DMV0oaKE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=X8OxkfvGwhsrRxORTlre3OUD5BuRNJbWuBeLOyjHim92X5cMrdGrvJ9tFJG+N8tkJR144MAx3iAviE07wTFDcVtLkZrNsgvwtrwnYn+oMREp9G6r4PGNzknk3iKA5IGhHDZ8B/Vm8/uv3EB1/679UjGRTgEyaZuercgLHp5qDH0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rCGr6Y4U; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rCGr6Y4U" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-495757ccbc1so16477015e9.2 for ; Sun, 26 Jul 2026 04:00:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785063614; x=1785668414; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=GUYubJZOlyk7ZUcTegsKcSoPhTLrbF/NRujnb44b+Dg=; b=rCGr6Y4UG+COIj/r0LxXFvd4seBVaJpB2QAidIeeG1M5q0gjyDRYR2uRWywZyCusXH uzHxt/j0Ov6RADBdoYJMD+wPOXyxnnHh6Uu+8xXJ/SLV0ahrhe04DR0NrDc0KhKcXTbU eMkdqJBJwgHp1P547cQA9uzuQ0pKI13pJ20ghmNmN/LWgSkv/V2d6gJRU4bCBamD468l GGDsnlDawzjTg2aGbatkBvNG7LF58NflJUfF9XFOUJLpKGfY3fm6SMPgDOsgkQjDezR7 8E+2ELVkZgYerPnXncqxPAS+RU4rixklFmzW59UvZqPZWf/SFIg6L7DaQ7CKGNhf/rlV vHOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785063614; x=1785668414; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=GUYubJZOlyk7ZUcTegsKcSoPhTLrbF/NRujnb44b+Dg=; b=GYu3yi5U9OBP5KWuCHWwy8K8bR6vUNTCwrKfS4xJkzxJVGINKeSbae83/3JOVNLcZF cNOU7YBnJJUeLePYn/W6FDziU7/FY6HGib56FzHTE65uw7xX200dnwQ30X86TKAm4KnV zuMq0EfH7B92yLa6LxpzJOSyPfHNfGOL9Q2irZUcxN2K5ts8MlYLz3sMCA/RiTsY0kEA CCfTpY2Ldkw74eHsv2GQLg3IS2ZQlJbMKYDwbDvWxlYbmIMSnwqBxZWZVRnm7fvn281G VeuXv3iILuvTCJDEj4PeSdIZ+KRSIJwCbQWL+JV3ODieQ1jiOotmOwwrJg+krEGgWKgo wLkg== X-Forwarded-Encrypted: i=1; AHgh+Rof0S3bo5qC1SWN2mjHv4MtoCp1MBhBLyBeX/aaAZyqwqxBpiZKRppQ437OS7GlgcNhgatu1xArwgMQqAg=@vger.kernel.org X-Gm-Message-State: AOJu0YyPkUN1RdEc/Yf+R+NwgXr0AAgCuBhEpvXS0PqYHXC0AJDMgqYM F8nRVXMElL229stMoFlQZ4I7bLjkRyo3q6PvY45Nc0aUrH/APrb3t3/i X-Gm-Gg: AR+sD11v3ewMsTNCxClUh+R9gx7ZnJZPZAOQXwrAwzdtBE9PmZa2qZarByIIBIlhJZx YMSf7d7S2UJCyR9X7M5dwCtvr7oWorFn+GFMaA8AaKiP7/cNuWr66KpyjozPnu7HUgh24tbVAVB ri/G8xb2ERxl+ckaKEU0IcwmwHjwQ3ytZyeoWF7X6h2zb4BF9Sj7wCQRKvt060u+xLngb45Kj3o gCnzge/soJGaRuueW8LgS4oISFLjFA+4tclInpKZJyBZuvMZ0sSBBFxfgEKxs/Zb0jqBCwaRrEk 6ADoNwYgrCePExpm6rKMW80gT2s4rG62SCP7dOmyYyb9F332U73h24vdm8+THaJuZawAhhRBFJp 71g7b3ORlUOjpSe3lhOfXVOlx5WhnqqbfaAnJBcdvcfDEf89zrUZPwdsJAdRmAAzYgVsg+YKeu+ 4baq5zgX7TNkzvmJRLh+Gx X-Received: by 2002:a05:600c:350c:b0:493:f639:9b2f with SMTP id 5b1f17b1804b1-496b5ddd7dfmr62118035e9.39.1785063613640; Sun, 26 Jul 2026 04:00:13 -0700 (PDT) Received: from [192.168.1.110] ([223.122.38.120]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-496b4ee0e91sm132606545e9.4.2026.07.26.04.00.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 26 Jul 2026 04:00:13 -0700 (PDT) Message-ID: <2b553c1a-a2d3-44d8-8e98-976835e3d436@gmail.com> Date: Sun, 26 Jul 2026 19:00:06 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/7] spmi: apple: use IRQ for RX FIFO if possible Content-Language: en-MW To: Sasha Finkelstein , Sven Peter , Janne Grunau , Neal Gompa , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Alba Mendez References: <20260725-t603x-spmi-v1-0-e1a29fcd2d38@chaosmail.tech> <20260725-t603x-spmi-v1-6-e1a29fcd2d38@chaosmail.tech> From: Nick Chan In-Reply-To: <20260725-t603x-spmi-v1-6-e1a29fcd2d38@chaosmail.tech> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sasha Finkelstein 於 2026/7/25 晚上9:48 寫道: > From: Alba Mendez > > The IRQ fires as soon as the reply is available, which is usually takes > a few us instead of the 10ms sleep interval for polling > > Signed-off-by: Alba Mendez > Signed-off-by: Sasha Finkelstein > --- > drivers/spmi/spmi-apple-controller.c | 97 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 96 insertions(+), 1 deletion(-) > > diff --git a/drivers/spmi/spmi-apple-controller.c b/drivers/spmi/spmi-apple-controller.c > index d8509f027df6..d627187b3ac0 100644 > --- a/drivers/spmi/spmi-apple-controller.c > +++ b/drivers/spmi/spmi-apple-controller.c [...] > @@ -195,6 +277,7 @@ static int apple_spmi_probe(struct platform_device *pdev) > > spmi = spmi_controller_get_drvdata(ctrl); > mutex_init(&spmi->fifo_lock); > + init_completion(&spmi->fifo_rx); > > spmi->regs = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(spmi->regs)) > @@ -206,11 +289,23 @@ static int apple_spmi_probe(struct platform_device *pdev) > ctrl->write_cmd = spmi_write_cmd; > ctrl->cmd = spmi_cmd; > > + irq = platform_get_irq_optional(pdev, 0); > + if (irq < 0 && irq != -ENXIO) > + return irq; > + if (irq >= 0) { > + ret = apple_spmi_init_irq(pdev, spmi, irq); > + if (ret) > + return ret; > + } > + > ret = devm_spmi_controller_add(&pdev->dev, ctrl); > if (ret) > return dev_err_probe(&pdev->dev, ret, > "spmi_controller_add failed\n"); > > + dev_dbg(&pdev->dev, irq >= 0 ? "Initialized with IRQ" : > + "Initialized without IRQ, falling back to polling"); > + This does not compile with clang: drivers/spmi/spmi-apple-controller.c:453:22: error: initializer element is not a compile-time constant 453 | dev_dbg(&pdev->dev, irq >= 0 ? "Initialized with IRQ" : | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 454 | "Initialized without IRQ, falling back to polling"); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > return 0; > } > > Best Regards, Nick Chan