From: alexious@zju.edu.cn
To: "Andy Shevchenko" <andy.shevchenko@gmail.com>
Cc: "Hans de Goede" <hdegoede@redhat.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Kate Hsuan" <hpa@redhat.com>,
"Dan Carpenter" <error27@gmail.com>,
"Brent Pappas" <bpappas@pappasbrent.com>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: atomisp: ssh_css: Fix a null-pointer dereference in load_video_binaries
Date: Thu, 18 Jan 2024 23:10:55 +0800 (GMT+08:00) [thread overview]
Message-ID: <2b56b7f3.66be.18d1d200910.Coremail.alexious@zju.edu.cn> (raw)
In-Reply-To: <CAHp75Vdz4FRF5=zFiKarOkA6ezOTP=CbwU2-_fpSCpuaZgb+VA@mail.gmail.com>
> On Wed, Jan 17, 2024 at 8:34 AM <alexious@zju.edu.cn> wrote:
> > > On Fri, Jan 12, 2024 at 10:49 AM Hans de Goede <hdegoede@redhat.com> wrote:
> > > > On 1/12/24 09:34, Zhipeng Lu wrote:
>
> > > > > Fixes: ad85094b293e ("Revert "media: staging: atomisp: Remove driver"")
> > > Besides that, are you sure the Fixes refers to the correct commit?
> >
> > Well, I think I referred to the correct commit, which introduce the whole module and leave this bug.
> >
> > If I did miss something please let me know.
>
> Yes, the driver was before that commit in the kernel. Was it without
> the bug? No, because you are referring to a clear revert. So, find the
> real commit that had brought that into the kernel.
You are correct, I just did some git blame on the latest version but
forgot about the commit blamed was a revert commit.
A v2 version of this patch will be sent later to fix this issue.
Thank you for pointing out my mistake.
Regards,
Zhipeng
>
> --
> With Best Regards,
> Andy Shevchenko
prev parent reply other threads:[~2024-01-18 15:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-12 8:34 Zhipeng Lu
2024-01-12 8:49 ` Hans de Goede
2024-01-12 18:27 ` Andy Shevchenko
[not found] ` <17d22c9e.4900.18d162090d8.Coremail.alexious@zju.edu.cn>
2024-01-17 20:50 ` Andy Shevchenko
2024-01-18 15:10 ` alexious [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b56b7f3.66be.18d1d200910.Coremail.alexious@zju.edu.cn \
--to=alexious@zju.edu.cn \
--cc=andy.shevchenko@gmail.com \
--cc=bpappas@pappasbrent.com \
--cc=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=hpa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®