From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 017F41FCCED for ; Tue, 4 Mar 2025 10:15:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741083351; cv=none; b=SmvkiyNeZJ8uuUNRG+UDxKFBThlvgJf6uxJyZ2O1P5r/zmG5+mh/iCWUthPQWuG+duFGqvFDPCmxzf20fuEzLfIX8yblp4wkdTyfRJcMe6x4iAAd5eD0wE+hKGKGvQcgDkR9ySOSA9Sz04mpp6WwKX4D5SoUbPtFwoapI/YoyQc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741083351; c=relaxed/simple; bh=586x6KaLpuRws9oiXO3+ufXeNdlCPivVZ8T7Ww4YYog=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=kiIWyCGhV93725kb3y0TgHxgi+Nr8BffZsfyedWjWakQivMs3OjFGk8WSAgmV9GNInnnpJAQZ4rOVaumSqwvXYZGM2W5MIVERrAxUxij0em6AzxP16tiy2O5tIR2n605FnsMhefByJIRWVzIc6fu1l8bt66HuXxSQUTcBVWzCcA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=suOU9Eep; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="suOU9Eep" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4393dc02b78so34899615e9.3 for ; Tue, 04 Mar 2025 02:15:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741083348; x=1741688148; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=kIp1cph66/HGjo1LcKFC/SHdEMb7MTb3g/6N0/oA0e8=; b=suOU9EepyK8t7trCsQTS2KSUHIf44nBYyVaoRxw03VkjxaCCeuGEqXeUNypjS6VmK/ gU1zjtJNuG3IWxp9CQbsmWjRXUkRfE6klqTHJSbiU3oJw3exAWU5ZQOWVOJIhwVR+gL2 ScfofBvncgV4z6ySEqFCv2gDACgyo963VA75zmCBKW27BpHTVGeauih7xUVVGuHyt8hz zJ7wjjFAKVMeHVL484sNQ7Cy8ff7qCAqvdIvL1afXVb703TdFHxV3ifGOWW2T7ezJuuK 4cJ4OfpMEsllMObHgOKJM3VF9p264XV98nRstwhmpxZEUrrF146BSZPrXSSSg6Mr6uRL //sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741083348; x=1741688148; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=kIp1cph66/HGjo1LcKFC/SHdEMb7MTb3g/6N0/oA0e8=; b=o2azb8xlyD8iCJPajzBK0tkOsLdPgZeMedljGOURASobLyoVgPDg4/OjydLh4tvAnK I2LB8nuH8Thjzjx8vOvoRf3A8NqyJKD+vgGl5CoPGkZVupMoD4iiMHqQH2M2urtGMNYx qPESgOek9p3x1gdJVukMrnIpkI7myv9c3sAJWBK692vW7XVPPlcoUVrFChu2KI8aMqtd o1zXd8eeFy2NlBKvZVZUV0ElBIAiPdZ4ZYjiku+FSz7oCtfBrWi2cruP44bINRK9Nndt GEczd+JEt4cOzI+Q2VZTPN3OO+b+Gqnr75dozz/qE+TyS+rKvO3LZO2MXMKSVNQYLBRQ ZXuA== X-Forwarded-Encrypted: i=1; AJvYcCVFgbTJz5bzzyshyBJHkYdyHbDeI7cmWl6/VW9fDaw9VG9UL5+Oq+MqoHQDpEOAYB2pP6Zg64A0Ez6m1jk=@vger.kernel.org X-Gm-Message-State: AOJu0Yzn325EYEqAur9P5UBciQ61s2l7HcdK1S02spqX1vCEEm7m/Tam c1J+/ODBpptvuLqtufIVXOSg4SgpQX7DU3ZtbqN2914aj9EBO3MUKJtuyGi2YEo= X-Gm-Gg: ASbGncuCbOj3u3z3sYyyrg+obKmvux4JTcdtGC1Wx81FUC1Msquxq2C4QRYCpetgzv3 rQgjseSfi0TMa1D/9glQOpQMZ4b0s+0Umz9w15WHnK0nVO+dymqXjxrMuy6FTfw5hiaw784CD/X djP828h0ckHycWfhyw/By2lEH70LWXc1uYEHbjzz8Nw7wJeu5XKkLiamSUvbp9MAS+l1+ZZivrN 82ZLT49J+uBsPq9QF8vGM43pbyIOcMtNuSDz+QUzXu27wxrGWdZoYVvJJJP+6s5e2wCQCQWj9Ez qP4hCZw2J4VUWSMHPf8V4Uu2dmMn3npDtCMdyHPgS9Q8nG3w1l/YWKxK X-Google-Smtp-Source: AGHT+IGey+kjBPOhuoeEklMVdzB91lv2feUrKYSiI7u29mC2m39dGVaqOGpmY1/H5pbh0BrYF7k6rg== X-Received: by 2002:a05:6000:4029:b0:390:efe7:20fa with SMTP id ffacd0b85a97d-390efe72244mr11536252f8f.47.1741083348262; Tue, 04 Mar 2025 02:15:48 -0800 (PST) Received: from [192.168.1.101] ([37.167.169.83]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43bc18452c3sm69076095e9.25.2025.03.04.02.15.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Mar 2025 02:15:47 -0800 (PST) Message-ID: <2b5c44c8-4eca-45d2-9599-a4d00bf44f5e@linaro.org> Date: Tue, 4 Mar 2025 11:15:46 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH] pmdomain: amlogic: fix T7 ISP secpower To: xianwei.zhao@amlogic.com, Ulf Hansson , Kevin Hilman , Jerome Brunet , Martin Blumenstingl Cc: linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org References: <20250303-fix-t7-pwrc-v1-1-b563612bcd86@amlogic.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20250303-fix-t7-pwrc-v1-1-b563612bcd86@amlogic.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 03/03/2025 10:06, Xianwei Zhao via B4 Relay wrote: > From: Xianwei Zhao > > ISP and MIPI_ISP, these two have a parent-child relationship, > ISP depends on MIPI_ISP. > > Fixes: ca75e4b214c6 ("pmdomain: amlogic: Add support for T7 power domains controller") > Signed-off-by: Xianwei Zhao > --- > drivers/pmdomain/amlogic/meson-secure-pwrc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pmdomain/amlogic/meson-secure-pwrc.c b/drivers/pmdomain/amlogic/meson-secure-pwrc.c > index 42ce41a2fe3a..ff76ea36835e 100644 > --- a/drivers/pmdomain/amlogic/meson-secure-pwrc.c > +++ b/drivers/pmdomain/amlogic/meson-secure-pwrc.c > @@ -221,7 +221,7 @@ static const struct meson_secure_pwrc_domain_desc t7_pwrc_domains[] = { > SEC_PD(T7_VI_CLK2, 0), > /* ETH is for ethernet online wakeup, and should be always on */ > SEC_PD(T7_ETH, GENPD_FLAG_ALWAYS_ON), > - SEC_PD(T7_ISP, 0), > + TOP_PD(T7_ISP, 0, PWRC_T7_MIPI_ISP_ID), > SEC_PD(T7_MIPI_ISP, 0), > TOP_PD(T7_GDC, 0, PWRC_T7_NIC3_ID), > TOP_PD(T7_DEWARP, 0, PWRC_T7_NIC3_ID), > > --- > base-commit: 73e4ffb27bb8a093d557bb2dac1a271474cca99c > change-id: 20250303-fix-t7-pwrc-f33650b190ef > > Best regards, Reviewed-by: Neil Armstrong