mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Avaneesh Kumar Dwivedi (avani)" <avaneesh.dwivedi@oss.qualcomm.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	Ruchira Revdekar <ruchira.revdekar@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Abel Vesa <abelvesa@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] dt-bindings: arm: qcom: Add Talos Lyra EVK board
Date: Thu, 5 Nov 2026 16:00:40 +0530	[thread overview]
Message-ID: <2b5c5216-40d6-41e1-b79a-76c56c702348@oss.qualcomm.com> (raw)
In-Reply-To: <20261027-whimsical-russet-marmoset-f248ba@quoll>

Re sending as earlier reply was rejected due to HTML formatting.

On 10/28/2026 12:11 AM, Krzysztof Kozlowski wrote:
> On Tue, Oct 27, 2026 at 05:01:55PM +0530, Ruchira Revdekar wrote:
>> From: Avaneesh Kumar Dwivedi <avaneesh.dwivedi@oss.qualcomm.com>
>>
>> Add the qcom,talos-lyra-evk compatible string for the Talos Lyra EVK
>> board. The Talos Lyra EVK pairs the Talos Lyra SoM with a carrier board.
>> The SoM uses the same QCS615/SM6150 SoC as the existing Talos EVK, so
>> qcom,talos-lyra-evk is grouped under the existing talos-evk block rather
>> than introducing a SoM-specific compatible.
> I do not understand this logic at all. Usage of same SoC has nothing to
> do with having or not having SoM compatible. Every SoM uses same
> compatible as some other device, so we should drop all SoM-compatibles
> in the future?.

Thank you Krzysztof for your review comments, and you are right. Sharing 
same soc (QCS615/SM6150) can not be the reason to omit a SoM compatible.

v3 commit was misleading suggesting that this was the reason for change, 
will fix it.

>
> So if you have a SoM then it can be used with different boards, thus it
> should have its own compatible.

In v1 patch, the EVK root compatible list also included Lyra SoM 
compatible. And as per earlier review comment that there is no value in 
EVK claiming compatibility with SoM, we removed SoM compatible from EVK 
compatible chain and added qcom, talos-lyra-evk directly to existing 
QCS615/SM6150 group.

If there is no value in EVK claiming compatibility with SoM, then is it 
fine that i do not have a fallback SoM compatible in Talos Lyra EVK root 
compatible list while I retain qcom, talos-lyra-som compatible for SoM 
itself?

>
> Again, explain properly the hardware if this is the chosen design.

H/w toplogy wise Lyra is reusable SoM containing SoC and module specific 
components. The Talos Lyra EVK consist of this Talos Lyra SoM plugged 
into Talos Lyra carrier board. But The Talos Lyra SoM can be used 
independently with different carrier board.

We will take care of above things in new patch.

>
> Best regards,
> Krzysztof

  reply	other threads:[~2026-11-05 10:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-27 11:31 [PATCH v3 0/3] Add support for " Ruchira Revdekar
2026-10-27 11:31 ` [PATCH v3 1/3] dt-bindings: arm: qcom: Add " Ruchira Revdekar
2026-10-27 18:41   ` Krzysztof Kozlowski
2026-11-05 10:30     ` Avaneesh Kumar Dwivedi (avani) [this message]
2026-10-27 11:31 ` [PATCH v3 2/3] arm64: dts: qcom: talos: Add Talos Lyra EVK SoM platform Ruchira Revdekar
2026-10-27 11:31 ` [PATCH v3 3/3] arm64: dts: qcom: talos: Add Talos Lyra EVK board Ruchira Revdekar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2b5c5216-40d6-41e1-b79a-76c56c702348@oss.qualcomm.com \
    --to=avaneesh.dwivedi@oss.qualcomm.com \
    --cc=abelvesa@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=ruchira.revdekar@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®