From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8884F30D3EF for ; Mon, 13 Jul 2026 16:27:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783960051; cv=none; b=j2PgvT42ILOxKQjI11foDOnpWJog9+tp3yzrlajuXsyOM8CoSqd4j/rkml+DFd9bh+WbS50y3BSmnncutFhjtHJMyG4vZ2EZNKgqyh4UlmpW85+EyX7c7suji0gUpvv9O6xVJELQNQNqm12uZs3Y7QVZ163733c7RXOpM8AXdic= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783960051; c=relaxed/simple; bh=A1f97LTbTJPapjq0Go5CkXQGXKJe1MV3Kq+mFGjV6EY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=b5/dLCvboNZzjV6d4ZTjjP7co51xxo6dutLL+PgBJx+i7vuRWF1rQzivEQ1Pl4IVO2mOhBQWNpRZslwYedGg482iTIEZKXX47TmJ2aRNhjHfNq2RMu/HnThexvtyy5E6vQ7FSP6WTm87ZYsko0W/pe82Etm+jBjAC0VAfv1z4lw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=X0KeW06R; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZBFov73v; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="X0KeW06R"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZBFov73v" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66DF8Bc71968353 for ; Mon, 13 Jul 2026 16:27:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= D5rm8mmecnWku+WMvoOW9pOIxP97XIThL4X10qRCnxE=; b=X0KeW06Rfdm3sDZY MbtyRXJ3yJfOdc3lYbRUbKZsLN8UiuUw65hnbBs4KB4cfvFDT87bUIRirqTFmGYr +eV8KMkm81I2qrBXCTpvMiu9cCR7nd4BQanq+VJXFrKbgPwCOS198Lbk7eNntURM 9jRvmy4iu7UO9YzsA6iAos77W3ysitm14HkDMr47gt/Cc/SDGU2eLVA95uGCsPYz Mur3Q6lmYF3pPSoSTAEDmsoUwt0iMb7FhTNXs3RACCxzEh8mPL0b/fPMz8RPqFPU AyLqCVUHJoYS75cb06T+77insB9F6j6FswiLk56t+Lf6c2fu4EzYeG0saOkqpneB ihDjxA== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fcjn3bh4e-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 13 Jul 2026 16:27:29 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-c89704da8c7so5123349a12.0 for ; Mon, 13 Jul 2026 09:27:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783960049; x=1784564849; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=D5rm8mmecnWku+WMvoOW9pOIxP97XIThL4X10qRCnxE=; b=ZBFov73vh4dKDmAo0MsPku4Bm/z37CY5d6n6/JhZjCmd/AWsZMLf1lNUc3QG6dtJJ4 k4GY+pOUNfa7LvMAli9QfpWrN5a0PUEZMPP89EzJ9tb+8BWNuv2xWyu2iVpxd60Ptj09 DSRIs+ybS70HM6d67aHZwTpJVaiUmicU6b45lpQ8wMfqzFDtlmP2+2nyukTbTU9kdoxa LY7TnSYbgEZIB12bOdnscQiYAcAcEj289n5dxvavKK9v10/GpnJElyaxL4yC+zjSbwMe MngXft6L2JU903weUg9plxMQcjlavH/f5kFVTkZOKUo9fU/ctR8IeDyHHHXvDs6IBZEY tDZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783960049; x=1784564849; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=D5rm8mmecnWku+WMvoOW9pOIxP97XIThL4X10qRCnxE=; b=k/yzF/S/BlzQHa3NH2DHyz9cBJI/jVPZLZj01GGrmvLVmyZF+cUg0rf6Qp5eFDF6iK J4lAGnAmNutNTrL13YSORIOCdwnA3j3YM3WxgGR2410D1GXJEw7bj4ST1tI7q7P7YLfY +lKftlChN/fnJmW8GFMN4fLWIRvbNSY1Tf73kK9XfGLzL8BH48zam8GGcU4qS1phpPB/ RtiNMZyggFBpjw+bACDVc5kR7jBxbRGu3HKoLZ3mf9rWmGfQ7O1d8vtpVtsi6p9ODyg1 kVysiMyUx2ROK8x5UilwfOMUD3fz8nb6nZI7/Q+ewuuVBGa8IP4RYy15KA5/E63vsAtD bRFg== X-Forwarded-Encrypted: i=1; AHgh+Rpw90mVRWKNPFRHvhRxoC5N6pw7NO95II2S7+bS+uAKLF5bR5znb3GzGRnf7mnuOc8++GJs0lBKJ1qka9I=@vger.kernel.org X-Gm-Message-State: AOJu0YwrPoPQOmatHGdBAQFM6XzRL2yvjssT3w/zL6Aa3iXZSxH4bQYw potS7fPtBtZHyiDPwYVGv6xBLZsvzAx0u/zSGACEXpKvWOu8j10Q7TuilK90lZOkXCWXeJxa5Ql 3hwokZWF8fWQcLZrASDeSwvGVFYPKTsxtn5tp16Q8lRffuWGni+1HVT3Ew1KjtA+rvQY= X-Gm-Gg: AfdE7clRZIs+0V/txpeAV7jSDzwofllECZXx/hTWgYL4LUUP3JvTk1jzWGIbBlL7iMT MmKxc3FnSdSLUMJzQsNZUOztRQQ2JSUwe4X0kPi5JToo0kWkYJ11SwtMu8H+Ro1Fg26D8DGXWxP eE9LNUISUeUSOIt6n53cyYt+dM35BZuU4eo9u2MYzi53Swm73y6Ncjv0VaZj31mxdhtlJeFnUcJ gH13aR57TsF090NHzxRo0D9GuRBDPLZWMwbQHe8QYTh0i4gau4U1jJzrKdZYfkoDzva/ikEGH7z n6qeXX/y/ZYPtUrFbg5tr27HHw6eESiqV7+aRax1gL+s/uACVM6Ri0fZxLincrXAFgqCAkTPutj FdMXugZrFjE6oV3DBN8qkVaNCebaGpSsjVDnM2S4a9yt2w0hEWXwujoUi4Ox0BWyodc3R X-Received: by 2002:a05:6a21:4593:b0:3b4:6a23:6ba with SMTP id adf61e73a8af0-3c1109e034emr11007100637.26.1783960049207; Mon, 13 Jul 2026 09:27:29 -0700 (PDT) X-Received: by 2002:a05:6a21:4593:b0:3b4:6a23:6ba with SMTP id adf61e73a8af0-3c1109e034emr11007082637.26.1783960048822; Mon, 13 Jul 2026 09:27:28 -0700 (PDT) Received: from [192.168.1.11] (15.sub-75-218-246.myvzw.com. [75.218.246.15]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-313c50c70c9sm28567493eec.29.2026.07.13.09.27.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jul 2026 09:27:27 -0700 (PDT) Message-ID: <2b5dfc9a-d2fc-4396-a004-4d3dbe30b408@oss.qualcomm.com> Date: Mon, 13 Jul 2026 09:27:23 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] wifi: ath12k: implement custom wake_tx_queue with flow control To: Jose Ignacio Tornos Martinez , jjohnson@kernel.org Cc: ath11k@lists.infradead.org, ath12k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260710155443.1761760-1-jtornosm@redhat.com> <20260710155443.1761760-3-jtornosm@redhat.com> From: Jeff Johnson Content-Language: en-US In-Reply-To: <20260710155443.1761760-3-jtornosm@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzEzMDE3MCBTYWx0ZWRfXxIH/g1QJcHib JBCpZ2UKJbl9h19nbvFYdo6fg7pojx/852LTFHrH35ahOX3mFqdoI0pajNPScZTcjXQSizxaeqe RiK3mPEzabli8m9H+i7Hb+t1BkLQQpOzjL8a75NVPbkRdjX5kbDWHQLa/0KKvq9VHv1fONtiuhX DELzVWlSfITs+HYnzLoS3mWvRdppjQEgiign/0PIRW/JIrHHnG3QJhPtAv6S1Otg3Us6uOoVWL8 wmGhtvAVIBqYDOTUxd2SilYYnANI/ejbKaZ9ZkCq52I4K8JfXqstHH/LQnrGQOB4/hUQ/fLrNLk KcEVY1yaJxowI9G4dAyBaPkfcLqYCjoOy4RUh+TQDpAt2YLT/4ZFMUWv2FBPRz5p1l6QhbVdGFG HKJ9zmsJ/KzJMqR+8HsX2vDolLO4g+M2FWTeRMD2evWHXbmlcRCLntg2vXLaYvQ8B3ldqzCEyj8 968gENliQqxwoLjwv8Q== X-Proofpoint-ORIG-GUID: dIclN4TB6y-REZ8IIi-u5iv_oFcjXcGm X-Proofpoint-Spam-Info: AW1haW4tMjYwNzEzMDE3MCBTYWx0ZWRfX0jCDV4VH+cfC uXaIidov37u7ggJ758HHwmH2mxupQwXINnLaK2X23fAeYpepxJ9VM8XCRLf/47a0C0ylILLdMCA uAfxllbZk/0X5gGsw4/xSl8Ls1BYzy8= X-Proofpoint-GUID: dIclN4TB6y-REZ8IIi-u5iv_oFcjXcGm X-Authority-Analysis: v=2.4 cv=aaJRWxot c=1 sm=1 tr=0 ts=6a5511f1 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=6VQYfvmiyQ8t40WkS/mQdw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=20KFwNOVAAAA:8 a=pXPxGQ70wQjSudtT1GsA:9 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-13_04,2026-07-10_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 bulkscore=0 clxscore=1015 lowpriorityscore=0 adultscore=0 malwarescore=0 spamscore=0 suspectscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607130170 On 7/10/2026 8:54 AM, Jose Ignacio Tornos Martinez wrote: > Under heavy traffic, ath12k can hang and experiences -ENOMEM errors > ("failed to transmit frame -12") when the hardware TCL ring fills up. > This issue is more commonly observed in VMs with PCIe passthrough but > also occurs on bare metal systems. > > Implement a custom wake_tx_queue operation that: > > 1. Checks hardware ring space before dequeuing packets from mac80211 > 2. Uses per-packet locking to serialize ring access and prevent races > 3. Syncs with hardware state to get accurate free slot count > 4. Returns early during firmware crash in the same way as other tx paths > > This approach follows the pattern used in the iwlwifi driver, adapted > for ath12k's hardware ring architecture. > > This prevents hangs, eliminates -ENOMEM errors, and improves throughput > by optimizing resource usage and preventing unnecessary packet drops. > > Signed-off-by: Jose Ignacio Tornos Martinez Just based upon the description I doubt this will be accepted. The ath12k datapath team is striving to have a lockless fastpath, so adding new locks is problematic. I've BCC'ed the internal developers list so that the team knows to give more constructive feedback. /jeff