From: Guenter Roeck <linux@roeck-us.net>
To: Yikai Tsai <yikai.tsai.wiwynn@gmail.com>
Cc: patrick@stwcx.xyz, "Carsten Spieß" <mail@carsten-spiess.de>,
"Jean Delvare" <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] hwmon: (isl28022) Fix current reading calculation
Date: Mon, 19 May 2025 21:56:30 -0700 [thread overview]
Message-ID: <2b5e38cd-ea1e-4ec3-b8ca-4b7ab9db7b85@roeck-us.net> (raw)
In-Reply-To: <20250519084055.3787-2-yikai.tsai.wiwynn@gmail.com>
On Mon, May 19, 2025 at 04:40:51PM +0800, Yikai Tsai wrote:
> According to the ISL28022 datasheet, bit15 of the current register is
> representing -32768. Fix the calculation to properly handle this bit,
> ensuring correct measurements for negative values.
>
> Signed-off-by: Yikai Tsai <yikai.tsai.wiwynn@gmail.com>
Applied.
Guenter
next prev parent reply other threads:[~2025-05-20 4:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-19 8:40 [PATCH v2 0/1] " Yikai Tsai
2025-05-19 8:40 ` [PATCH v2 1/1] " Yikai Tsai
2025-05-20 4:56 ` Guenter Roeck [this message]
2025-06-10 12:27 ` Geert Uytterhoeven
2025-06-16 12:59 ` Guenter Roeck
2025-06-16 13:00 ` Guenter Roeck
2025-06-16 13:17 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b5e38cd-ea1e-4ec3-b8ca-4b7ab9db7b85@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@carsten-spiess.de \
--cc=patrick@stwcx.xyz \
--cc=yikai.tsai.wiwynn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®