From: Markus Elfring <Markus.Elfring@web.de>
To: "Vincent Jardin" <vjardin@free.fr>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
"Conor Dooley" <conor+dt@kernel.org>,
"Günter Röck" <linux@roeck-us.net>,
"Jonathan Corbet" <corbet@lwn.net>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Shuah Khan" <skhan@linuxfoundation.org>
Cc: linux-doc@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 3/3] hwmon: pmbus: add MPQ8646 driver
Date: Fri, 24 Jul 2026 18:40:31 +0200 [thread overview]
Message-ID: <2b6431b2-62f9-4399-ae20-bc90d4b04b5d@web.de> (raw)
In-Reply-To: <20260724-mpq8646_v0-v5-3-5915b5ae9aa2@free.fr>
…
> +++ b/drivers/hwmon/pmbus/mpq8646.c
> @@ -0,0 +1,1253 @@
…
> +static int mpq8646_dbg_probe_smbus_rword(void *data, u64 val)
> +{
…
> + mutex_lock(&priv->mps_lock);
> + rc = i2c_smbus_read_word_data(priv->client, (u8)val);
…
> + mutex_unlock(&priv->mps_lock);
> + return 0;
> +}
…
Under which circumstances would you become interested to apply a statement
like “guard(mutex)(&priv->mps_lock);”?
https://elixir.bootlin.com/linux/v7.2-rc4/source/include/linux/mutex.h#L253
Regards,
Markus
prev parent reply other threads:[~2026-07-24 16:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 23:55 [PATCH v5 0/3] hwmon: pmbus: add MPS MPQ8646 support Vincent Jardin via B4 Relay
2026-07-23 23:55 ` [PATCH v5 1/3] hwmon: pmbus: event notification with alarms Vincent Jardin via B4 Relay
2026-07-23 23:55 ` [PATCH v5 2/3] dt-bindings: hwmon: pmbus: add MPS MPQ8646 binding Vincent Jardin via B4 Relay
2026-07-27 7:13 ` Krzysztof Kozlowski
2026-07-23 23:55 ` [PATCH v5 3/3] hwmon: pmbus: add MPQ8646 driver Vincent Jardin via B4 Relay
2026-07-24 2:15 ` Guenter Roeck
2026-07-24 10:18 ` Vincent Jardin
2026-07-24 13:23 ` Guenter Roeck
2026-07-24 14:00 ` Guenter Roeck
2026-07-24 16:40 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b6431b2-62f9-4399-ae20-bc90d4b04b5d@web.de \
--to=markus.elfring@web.de \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=vjardin@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®