From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F156C7EE23 for ; Thu, 4 May 2023 15:06:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231179AbjEDPGj (ORCPT ); Thu, 4 May 2023 11:06:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230495AbjEDPGg (ORCPT ); Thu, 4 May 2023 11:06:36 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE56D1FE6 for ; Thu, 4 May 2023 08:05:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683212748; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M9SIzfOyT/36LPUiUVaXy7e6tRKfNiByyzcagojCb80=; b=VaISnwWMc9kKjiwN33z+12GxcydRYqm49vgRpcRxje3Nu1QwY/y+ZZy/LGmxWxVPXKvzz4 KWnXQwnbbIEB+gtBlYMFQdrPfE4Hm9+bf5P8TJVbOxTXS/YMM4yB2O0bYXVn2zFRXEaBJ7 t6ndeLi6aTI/33jSjOZNnFr+rZVfDuw= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-457-ca62_WwiND6-bGYuyAoV5Q-1; Thu, 04 May 2023 11:05:47 -0400 X-MC-Unique: ca62_WwiND6-bGYuyAoV5Q-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-5ef626ad00fso8260896d6.3 for ; Thu, 04 May 2023 08:05:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683212746; x=1685804746; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=M9SIzfOyT/36LPUiUVaXy7e6tRKfNiByyzcagojCb80=; b=F5mMUnJrCfWf2tRYM+MM6wbAU57Yv3QNHJSYzJYNYY5t3LFKumBpxoN3nLT2SWhiVk vn5hHbCMY7jFML3koIlzf+byIIMdPjWaXL940gtz2Izx6OmpPYlOlAZc2HAyPnXIyU90 t3dzPJyRmt5omUpjAEWoJV5jP9KYi/g1uz38ijORZo8xMDiWdEPtqjEwIFlQFcguxRmx IcmqKN3quskW/jhhd1y3tNoFyz4FypmtCRyIWYd64KY1/C2ZBiri1qGpb5OT2lD7W+rj DNKVGwt6b3qthFxCQUB6/9EMEg9CmdUBGa1qGDrpPGqrpcC4rudwi0iq4novJXIvsUDJ HHYw== X-Gm-Message-State: AC+VfDyghw9TG6A7DqMb0KsjC/PGrxz6HyfCoyUWm2iZsycUhIIicZ6Z AzPtsuuND/zkI+nPKzBIJE6UYaHBgrMfxiKUpUbB+97RK4SMTOMVgHxMFDBWjvm5IqOPKvn0L/0 klAv5OCClW/ahk0CDQLlko8B6 X-Received: by 2002:a05:6214:625:b0:61b:5bcd:db57 with SMTP id a5-20020a056214062500b0061b5bcddb57mr14789679qvx.48.1683212746697; Thu, 04 May 2023 08:05:46 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4ojJH3+qlpvL2ycgU482FJ67VO+1fJXqXVmFYjHvv90cAsNY46tRE4C0IiONAFYmsDYhANVA== X-Received: by 2002:a05:6214:625:b0:61b:5bcd:db57 with SMTP id a5-20020a056214062500b0061b5bcddb57mr14789645qvx.48.1683212746351; Thu, 04 May 2023 08:05:46 -0700 (PDT) Received: from ?IPV6:2a01:cb19:853d:fa00:c28a:3e3d:34f3:3891? ([2a01:cb19:853d:fa00:c28a:3e3d:34f3:3891]) by smtp.gmail.com with ESMTPSA id m18-20020a0cbf12000000b0060f5a75b750sm8507842qvi.99.2023.05.04.08.05.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 May 2023 08:05:45 -0700 (PDT) Message-ID: <2b6567ca-3e0e-02ea-0f5e-f7121c8d4b2c@redhat.com> Date: Thu, 4 May 2023 17:05:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] vfio/pci: demote hiding ecap messages to debug level Content-Language: en-US To: Oleksandr Natalenko , linux-kernel@vger.kernel.org Cc: Alex Williamson , Eric Auger , Jason Gunthorpe , Abhishek Sahu , Kevin Tian , Cornelia Huck , Bo Liu , "K V P, Satyanarayana" , kvm@vger.kernel.org References: <20230504131654.24922-1-oleksandr@natalenko.name> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= In-Reply-To: <20230504131654.24922-1-oleksandr@natalenko.name> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/4/23 15:16, Oleksandr Natalenko wrote: > Seeing a burst of messages like this: > > vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x19@0x1d0 > vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x25@0x200 > vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x26@0x210 > vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x27@0x250 > vfio-pci 0000:98:00.1: vfio_ecap_init: hiding ecap 0x25@0x200 > vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x19@0x1d0 > vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x25@0x200 > vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x26@0x210 > vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x27@0x250 > vfio-pci 0000:b1:00.1: vfio_ecap_init: hiding ecap 0x25@0x200 > > is of little to no value for an ordinary user. > > Hence, use pci_dbg() instead of pci_info(). > > Signed-off-by: Oleksandr Natalenko Acked-by: Cédric Le Goater Thanks, C. > --- > drivers/vfio/pci/vfio_pci_config.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vfio/pci/vfio_pci_config.c b/drivers/vfio/pci/vfio_pci_config.c > index 948cdd464f4e..dd8dda14e701 100644 > --- a/drivers/vfio/pci/vfio_pci_config.c > +++ b/drivers/vfio/pci/vfio_pci_config.c > @@ -1643,7 +1643,7 @@ static int vfio_ecap_init(struct vfio_pci_core_device *vdev) > } > > if (!len) { > - pci_info(pdev, "%s: hiding ecap %#x@%#x\n", > + pci_dbg(pdev, "%s: hiding ecap %#x@%#x\n", > __func__, ecap, epos); > > /* If not the first in the chain, we can skip over it */