From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754352AbdBHMaU (ORCPT ); Wed, 8 Feb 2017 07:30:20 -0500 Received: from mail-lf0-f47.google.com ([209.85.215.47]:35889 "EHLO mail-lf0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752921AbdBHMaT (ORCPT ); Wed, 8 Feb 2017 07:30:19 -0500 Subject: Re: [PATCH v2 06/16] net: stmmac: fix some code style problem To: Corentin Labbe , peppe.cavallaro@st.com, alexandre.torgue@st.com, netdev@vger.kernel.org References: <20170208083121.27949-1-clabbe.montjoie@gmail.com> <20170208083121.27949-7-clabbe.montjoie@gmail.com> Cc: linux-kernel@vger.kernel.org From: Sergei Shtylyov Message-ID: <2b6652d7-6a5c-ab68-2e74-c6e83f12a87a@cogentembedded.com> Date: Wed, 8 Feb 2017 14:57:20 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170208083121.27949-7-clabbe.montjoie@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello! On 2/8/2017 11:31 AM, Corentin Labbe wrote: > Checkpatch complains about some code style problem on stmmac_mdio.c. > This patch fix them. Fixes. > Signed-off-by: Corentin Labbe > Acked-by: Giuseppe Cavallaro > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c > index 3fdc6ec..c24bef2 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c [...] > @@ -267,7 +268,7 @@ int stmmac_mdio_register(struct net_device *ndev) > * If an IRQ was provided to be assigned after > * the bus probe, do it here. > */ > - if ((mdio_bus_data->irqs == NULL) && > + if ((!mdio_bus_data->irqs) && Innermost parens not needed (and weren't needed before). > (mdio_bus_data->probed_phy_irq > 0)) { > new_bus->irq[addr] = > mdio_bus_data->probed_phy_irq; MBR, Sergei