From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752216AbeENUxB (ORCPT ); Mon, 14 May 2018 16:53:01 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:42782 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752013AbeENUw7 (ORCPT ); Mon, 14 May 2018 16:52:59 -0400 Subject: Re: [PATCH 18/18] rcu: Use pr_fmt to prefix "rcu: " to logging output To: paulmck@linux.vnet.ibm.com, Joe Perches Cc: Josh Triplett , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Davidlohr Bueso , linux-kernel@vger.kernel.org References: <41d9686471d67f6f98d160e5891bf61061515b6d.1525964386.git.joe@perches.com> <20180514202910.GI26088@linux.vnet.ibm.com> From: Randy Dunlap Message-ID: <2b66d372-dac9-0fad-af44-bfa84d996985@infradead.org> Date: Mon, 14 May 2018 13:52:48 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180514202910.GI26088@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/14/2018 01:29 PM, Paul E. McKenney wrote: > On Thu, May 10, 2018 at 08:45:44AM -0700, Joe Perches wrote: >> Use a consistent logging prefix for all rcu related output. >> >> Signed-off-by: Joe Perches > > I took parts of this (thank you!) but have concerns about other parts. > >> --- >> kernel/rcu/rcu_segcblist.c | 2 ++ >> kernel/rcu/rcuperf.c | 10 ++++--- >> kernel/rcu/rcutorture.c | 46 +++++++++++++++---------------- >> kernel/rcu/srcutiny.c | 2 ++ >> kernel/rcu/srcutree.c | 5 +++- >> kernel/rcu/tiny.c | 3 +++ >> kernel/rcu/tree.c | 8 +++--- >> kernel/rcu/tree_plugin.h | 67 +++++++++++++++++++++++++++------------------- >> kernel/rcu/update.c | 19 ++++++++----- >> 9 files changed, 96 insertions(+), 66 deletions(-) >> >> diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c >> index 648e1c25707d..45d98ff0d5b8 100644 >> --- a/kernel/rcu/rcutorture.c >> +++ b/kernel/rcu/rcutorture.c >> @@ -22,6 +22,7 @@ >> * >> * See also: Documentation/RCU/torture.txt >> */ >> + >> #include >> #include >> #include >> @@ -908,7 +909,7 @@ rcu_torture_writer(void *arg) >> VERBOSE_TOROUT_STRING("rcu_torture_writer task started"); >> if (!can_expedite) >> pr_alert("%s" TORTURE_FLAG >> - " GP expediting controlled from boot/sysfs for %s.\n", >> + " GP expediting controlled from boot/sysfs for %s\n", >> torture_type, cur_ops->name); >> >> /* Initialize synctype[] array. If none set, take default. */ >> @@ -916,27 +917,27 @@ rcu_torture_writer(void *arg) >> gp_cond1 = gp_exp1 = gp_normal1 = gp_sync1 = true; >> if (gp_cond1 && cur_ops->get_state && cur_ops->cond_sync) { >> synctype[nsynctypes++] = RTWS_COND_GET; >> - pr_info("%s: Testing conditional GPs.\n", __func__); >> + pr_info("%s: Testing conditional GPs\n", __func__); >> } else if (gp_cond && (!cur_ops->get_state || !cur_ops->cond_sync)) { >> - pr_alert("%s: gp_cond without primitives.\n", __func__); >> + pr_alert("%s: gp_cond without primitives\n", __func__); >> } >> if (gp_exp1 && cur_ops->exp_sync) { >> synctype[nsynctypes++] = RTWS_EXP_SYNC; >> - pr_info("%s: Testing expedited GPs.\n", __func__); >> + pr_info("%s: Testing expedited GPs\n", __func__); >> } else if (gp_exp && !cur_ops->exp_sync) { >> - pr_alert("%s: gp_exp without primitives.\n", __func__); >> + pr_alert("%s: gp_exp without primitives\n", __func__); Unlike some of the others, the one above is not a sentence, so it doesn't _need_ a period ... except for consistency. But I don't care either way. :) >> } >> if (gp_normal1 && cur_ops->deferred_free) { >> synctype[nsynctypes++] = RTWS_DEF_FREE; >> - pr_info("%s: Testing asynchronous GPs.\n", __func__); >> + pr_info("%s: Testing asynchronous GPs\n", __func__); >> } else if (gp_normal && !cur_ops->deferred_free) { >> - pr_alert("%s: gp_normal without primitives.\n", __func__); >> + pr_alert("%s: gp_normal without primitives\n", __func__); >> } >> if (gp_sync1 && cur_ops->sync) { >> synctype[nsynctypes++] = RTWS_SYNC; >> - pr_info("%s: Testing normal GPs.\n", __func__); >> + pr_info("%s: Testing normal GPs\n", __func__); >> } else if (gp_sync && !cur_ops->sync) { >> - pr_alert("%s: gp_sync without primitives.\n", __func__); >> + pr_alert("%s: gp_sync without primitives\n", __func__); -- ~Randy