From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03EF7C43334 for ; Mon, 27 Jun 2022 12:01:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239802AbiF0MBX (ORCPT ); Mon, 27 Jun 2022 08:01:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52552 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239107AbiF0LxU (ORCPT ); Mon, 27 Jun 2022 07:53:20 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57815BDF for ; Mon, 27 Jun 2022 04:48:49 -0700 (PDT) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4LWmD3026LzkWdZ; Mon, 27 Jun 2022 19:46:58 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 27 Jun 2022 19:48:47 +0800 Subject: Re: [PATCH v2 5/9] mm, hwpoison: make unpoison aware of raw error info in hwpoisoned hugepage From: Miaohe Lin To: Naoya Horiguchi , CC: Andrew Morton , David Hildenbrand , Mike Kravetz , Liu Shixin , Yang Shi , Oscar Salvador , Muchun Song , Naoya Horiguchi , References: <20220623235153.2623702-1-naoya.horiguchi@linux.dev> <20220623235153.2623702-6-naoya.horiguchi@linux.dev> Message-ID: <2b6a6b19-c930-6d27-5929-363802e42596@huawei.com> Date: Mon, 27 Jun 2022 19:48:46 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/6/27 16:32, Miaohe Lin wrote: > On 2022/6/24 7:51, Naoya Horiguchi wrote: >> From: Naoya Horiguchi >> >> Raw error info list needs to be removed when hwpoisoned hugetlb is >> unpoisioned. And unpoison handler needs to know how many errors there >> are in the target hugepage. So add them. >> >> Signed-off-by: Naoya Horiguchi > > snip > >> @@ -2255,7 +2275,7 @@ int unpoison_memory(unsigned long pfn) >> unlock_mutex: >> mutex_unlock(&mf_mutex); >> if (!ret || freeit) { >> - num_poisoned_pages_dec(); >> + num_poisoned_pages_sub(count); > > IIUC, num_poisoned_pages will only be incremented once for hugetlb page. If many > subpages are hwpoisoned, they will reach the "else if (res == -EHWPOISON)" path > in try_memory_failure_hugetlb and thus num_poisoned_pages_inc is ignored. Maybe > that should be changed so subpages can contribute to the num_poisoned_pages > or should we just do num_poisoned_pages_dec here? Or am I miss something? Sorry. I re-read patch 4/9 and I found hugetlb_set_page_hwpoison will increment the num_poisoned_pages for each subpages. Please ignore this question. > > Thanks! > >> unpoison_pr_info("Unpoison: Software-unpoisoned page %#lx\n", >> page_to_pfn(p), &unpoison_rs); >> } >> >