From: "huangguangbin (A)" <huangguangbin2@huawei.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <davem@davemloft.net>, <wangjie125@huawei.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<lipeng321@huawei.com>, <chenhao288@hisilicon.com>
Subject: Re: [RESEND PATCH net-next 2/2] net: hns3: add ethtool priv-flag for TX push
Date: Sat, 29 Jan 2022 09:14:15 +0800 [thread overview]
Message-ID: <2b7029d4-c1a7-93af-1846-7b91703f9edf@huawei.com> (raw)
In-Reply-To: <20220125195508.585b0c40@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
On 2022/1/26 11:55, Jakub Kicinski wrote:
> On Tue, 25 Jan 2022 15:21:49 +0800 Guangbin Huang wrote:
>> From: Yufeng Mo <moyufeng@huawei.com>
>>
>> Add a control private flag in ethtool for enable/disable
>> TX push feature.
>
> I think it's a pretty standard feature for NICs which also support RDMA.
> Mellanox/nVidia has it (or at least it the previous gen HW did),
> Broadcom's bnxt driver does it as well.
>
> Can we make this a standard knob via ethtool? Not entirely sure under
> which switch, maybe it's okay to add it under -g? Perhaps we need a new
> command similar to -k but for features contained entirely to the driver?
> .
>
Hi Jakub,
We consider adding a new command for this feature. We will send RFC after we finish it.
prev parent reply other threads:[~2022-01-29 1:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 7:21 [RESEND PATCH net-next 0/2] net: hns3: add support " Guangbin Huang
2022-01-25 7:21 ` [RESEND PATCH net-next 1/2] net: hns3: add support for TX push mode Guangbin Huang
2022-01-26 3:50 ` Jakub Kicinski
2022-01-26 6:48 ` huangguangbin (A)
2022-01-26 15:55 ` Jakub Kicinski
2022-01-25 7:21 ` [RESEND PATCH net-next 2/2] net: hns3: add ethtool priv-flag for TX push Guangbin Huang
2022-01-26 3:55 ` Jakub Kicinski
2022-01-29 1:14 ` huangguangbin (A) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b7029d4-c1a7-93af-1846-7b91703f9edf@huawei.com \
--to=huangguangbin2@huawei.com \
--cc=chenhao288@hisilicon.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lipeng321@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=wangjie125@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®