From: Lyude Paul <lyude@redhat.com>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>, bskeggs@redhat.com
Cc: kherbst@redhat.com, airlied@linux.ie, daniel@ffwll.ch,
dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] drm/nouveau/gr/gf100-: Clean up some inconsistent indenting
Date: Thu, 05 May 2022 15:09:40 -0400 [thread overview]
Message-ID: <2b71f1e318af9819707de1aa61727f02a7e0a79f.camel@redhat.com> (raw)
In-Reply-To: <20220505081345.89762-1-jiapeng.chong@linux.alibaba.com>
Thanks!
Reviewed-by: Lyude Paul <lyude@redhat.com>
Will push upstream in a moment
On Thu, 2022-05-05 at 16:13 +0800, Jiapeng Chong wrote:
> Eliminate the follow smatch warning:
>
> drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c:1925
> gf100_gr_oneinit_tiles() warn: inconsistent indenting.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c
> b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c
> index 397ff4fe9df8..f16eabf4f642 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c
> @@ -1922,8 +1922,8 @@ gf100_gr_oneinit_tiles(struct gf100_gr *gr)
>
> for (i = 0; i < gr->gpc_nr; i++) {
> init_frac[i] = gr->tpc_nr[gpc_map[i]] * gr->gpc_nr *
> mul_factor;
> - init_err[i] = i * gr->tpc_max * mul_factor - comm_denom/2;
> - run_err[i] = init_frac[i] + init_err[i];
> + init_err[i] = i * gr->tpc_max * mul_factor - comm_denom/2;
> + run_err[i] = init_frac[i] + init_err[i];
> }
>
> for (i = 0; i < gr->tpc_total;) {
--
Cheers,
Lyude Paul (she/her)
Software Engineer at Red Hat
prev parent reply other threads:[~2022-05-05 19:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 8:13 Jiapeng Chong
2022-05-05 19:09 ` Lyude Paul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b71f1e318af9819707de1aa61727f02a7e0a79f.camel@redhat.com \
--to=lyude@redhat.com \
--cc=abaci@linux.alibaba.com \
--cc=airlied@linux.ie \
--cc=bskeggs@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=kherbst@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®