From: simon@mungewell.org
To: "Michael Bauer" <michael@m-bauer.org>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
"Jiri Kosina" <jkosina@suse.cz>
Subject: Re: [PATCH v2] hid: Fix Logitech Driving Force Pro wheel
Date: Thu, 2 Jun 2011 12:35:31 -0400 [thread overview]
Message-ID: <2b85316d7925dad6c55672d7d9738e18.squirrel@host171.canaca.com> (raw)
> Changes from initial patch:
> - shorten comment (removed original descriptor)
> - optimized new descriptor (simpler and shorter)
Concept looks go to me, but I'm getting
--
simon@ubuntu:~/linux-2.6$ patch -p 1 <
../Downloads/v2-hid-Fix-Logitech-Driving-Force-Pro-wheel.patch
patching file drivers/hid/hid-lg.c
patch: **** malformed patch at line 91: USB_DEVICE_ID_LOGITECH_G25_WHEEL), --
Looks like word wrap has been applied to the patch.
It also fails to patch chunk 3 against 3.0rc1 as the G27 wheel has been
added.
--
--- drivers/hid/hid-lg.c 2011-05-19 06:06:34.000000000 +0200
+++ drivers/hid/hid-lg.c 2011-05-30 21:49:51.535184784 +0200
@@ -450,7 +522,7 @@
{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,
USB_DEVICE_ID_LOGITECH_G25_WHEEL),
.driver_data = LG_FF },
{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,
USB_DEVICE_ID_LOGITECH_DFP_WHEEL),
- .driver_data = LG_FF },
+ .driver_data = LG_NOGET | LG_FF },
{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,
--
{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,
USB_DEVICE_ID_LOGITECH_G25_WHEEL),
.driver_data = LG_FF },
{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,
USB_DEVICE_ID_LOGITECH_G27_WHEEL),
.driver_data = LG_FF },
{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,
USB_DEVICE_ID_LOGITECH_DFP_WHEEL),
.driver_data = LG_FF },
--
All that said it appears to build (don't have this wheel to test) and have
it in a git archive if you'd like be to spin a fixed patch for you.
Simon
next reply other threads:[~2011-06-02 16:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-02 16:35 simon [this message]
2011-06-03 9:25 ` michael
2011-06-02 22:40 ` [PATCHv3] " Simon Wood
2011-06-07 13:48 ` Jiri Kosina
-- strict thread matches above, loose matches on Subject: below --
2011-06-01 18:49 [PATCH v2] " Michael Bauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b85316d7925dad6c55672d7d9738e18.squirrel@host171.canaca.com \
--to=simon@mungewell.org \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@m-bauer.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome