mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Adrian Hunter <adrian.hunter@intel.com>
To: "Luck, Tony" <tony.luck@intel.com>,
	Yazen Ghannam <yazen.ghannam@amd.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	"seanjc@google.com" <seanjc@google.com>,
	"Annapurve, Vishal" <vannapurve@google.com>,
	Borislav Petkov <bp@alien8.de>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "x86@kernel.org" <x86@kernel.org>,
	H Peter Anvin <hpa@zytor.com>,
	"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"Edgecombe, Rick P" <rick.p.edgecombe@intel.com>,
	"Huang, Kai" <kai.huang@intel.com>,
	"Chatre, Reinette" <reinette.chatre@intel.com>,
	"Li, Xiaoyao" <xiaoyao.li@intel.com>,
	"tony.lindgren@linux.intel.com" <tony.lindgren@linux.intel.com>,
	"binbin.wu@linux.intel.com" <binbin.wu@linux.intel.com>,
	"Weiny, Ira" <ira.weiny@intel.com>,
	"Yamahata, Isaku" <isaku.yamahata@intel.com>,
	"Du, Fan" <fan.du@intel.com>,
	"Zhao, Yan Y" <yan.y.zhao@intel.com>,
	"Gao, Chao" <chao.gao@intel.com>
Subject: Re: [PATCH RESEND V2 1/2] x86/mce: Fix missing address mask in recovery for errors in TDX/SEAM non-root mode
Date: Wed, 20 Aug 2025 18:59:32 +0300	[thread overview]
Message-ID: <2b86c458-f63b-4f74-8fcd-1456ddad4d7a@intel.com> (raw)
In-Reply-To: <SJ1PR11MB60833C7AE2FA8D8200EA3645FC30A@SJ1PR11MB6083.namprd11.prod.outlook.com>

On 19/08/2025 21:03, Luck, Tony wrote:
>> For struct mce?  Maybe that should be 2 new fields:
>>
>> 	__u64 addr;		/* Deprecated */
>> 	...
>> 	__u64 mci_addr;		/* Bank's MCi_ADDR MSR */
>> 	__u64 phys_addr;	/* Physical address */
> 
> Would "addr" keep the current (low bits masked, high bits preserved) value?

Yeah, it wouldn't make much sense if phys_addr was the same as addr anyway.
Not really thinking


  reply	other threads:[~2025-08-20 15:59 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-19 16:24 [PATCH RESEND V2 0/2] Fixes for recovery for machine check " Adrian Hunter
2025-08-19 16:24 ` [PATCH RESEND V2 1/2] x86/mce: Fix missing address mask in recovery for errors " Adrian Hunter
2025-08-19 17:28   ` Yazen Ghannam
2025-08-19 17:51     ` Luck, Tony
2025-08-19 17:58       ` Adrian Hunter
2025-08-19 18:03         ` Luck, Tony
2025-08-20 15:59           ` Adrian Hunter [this message]
2025-08-20 16:12             ` Luck, Tony
2025-08-20 17:56               ` Yazen Ghannam
2025-08-21  6:49                 ` Adrian Hunter
2025-08-19 21:32   ` Borislav Petkov
2025-08-21  7:24     ` Adrian Hunter
2025-08-21 13:25       ` Borislav Petkov
2025-08-22  7:57         ` Adrian Hunter
2025-08-22 13:54           ` Borislav Petkov
2025-08-22 14:54             ` Adrian Hunter
2025-08-27  8:22     ` Adrian Hunter
2025-08-27  8:29       ` Borislav Petkov
2025-08-19 16:24 ` [PATCH RESEND V2 2/2] x86/mce: Remove MCI_ADDR_PHYSADDR Adrian Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2b86c458-f63b-4f74-8fcd-1456ddad4d7a@intel.com \
    --to=adrian.hunter@intel.com \
    --cc=binbin.wu@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=chao.gao@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=fan.du@intel.com \
    --cc=hpa@zytor.com \
    --cc=ira.weiny@intel.com \
    --cc=isaku.yamahata@intel.com \
    --cc=kai.huang@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=reinette.chatre@intel.com \
    --cc=rick.p.edgecombe@intel.com \
    --cc=seanjc@google.com \
    --cc=tglx@linutronix.de \
    --cc=tony.lindgren@linux.intel.com \
    --cc=tony.luck@intel.com \
    --cc=vannapurve@google.com \
    --cc=x86@kernel.org \
    --cc=xiaoyao.li@intel.com \
    --cc=yan.y.zhao@intel.com \
    --cc=yazen.ghannam@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®