From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932697AbdA0Oot (ORCPT ); Fri, 27 Jan 2017 09:44:49 -0500 Received: from mail-co1nam03on0054.outbound.protection.outlook.com ([104.47.40.54]:28264 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754546AbdA0OoA (ORCPT ); Fri, 27 Jan 2017 09:44:00 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Christian.Koenig@amd.com; Subject: Re: [PATCH] drm/ttm: Make sure BOs being swapped out are cacheable To: Thomas Hellstrom , =?UTF-8?Q?Michel_D=c3=a4nzer?= , Sinclair Yeh , , References: <20170125082131.25544-1-michel@daenzer.net> <56e0a49e-89b6-4542-e905-57f0dc2ae79c@amd.com> <20170126004632.GA3457@vmware.com> <9af4b5b5-a8a5-8908-f59f-6cdc8efe0570@daenzer.net> <5778f881-ce81-1c58-f2d4-02175c3d2615@vmware.com> <20170127073040.l2ofthrhsbteahpx@phenom.ffwll.local> <5e8d77b2-8b71-6542-4ef5-c7a5d16f2455@amd.com> <20170127141249.4tft6eajtw35pcho@phenom.ffwll.local> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <2b8ceab6-f419-0670-0df9-77e726177742@amd.com> Date: Fri, 27 Jan 2017 15:43:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170127141249.4tft6eajtw35pcho@phenom.ffwll.local> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [2a02:908:1251:7981:5d6a:1040:c41c:5a5] X-ClientProxiedBy: VI1PR07CA0079.eurprd07.prod.outlook.com (10.164.94.175) To DM5PR12MB1306.namprd12.prod.outlook.com (10.168.237.149) X-MS-Office365-Filtering-Correlation-Id: 8ddbbdf1-c223-42dc-e632-08d446c2dbd0 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401076);SRVR:DM5PR12MB1306; X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1306;3:Q+zv60MCWeU43FRZhFelbxtxDW1tZKEhZqis00o4dcWQbSDiNXVIZ7rEhNBzwJ7P76f8pIWhk5OvV8lX6lEJmqWRDvg9K8yBJ2Se2KgUcxSP9lyG/frrfB/OBeT9PkPXAq6wOBUvHMPX18GeKqB8Wj5JMuG+Hr6Hg1HXasvXxElu3Iyilx6s91jS1tu/X++4mkGJqsupsKEn8eCBiQk+KTutO85BKF8RrTJ+T/HVHMYmG2PMP7ehZjL1RQoJFB2DCgd8LpMoBAGo7DteMUyiCkqPPstyNwfsteSEFHQKy0I=;25:V0Pa51Lwr8Wj8hJTVSM/akcH6RmZAGkwD3H3IojARd35fgf04wyCXtURQFke+4WI2IuFGcmv+KzfSN0ouYNbSbbW7rqsfjuiVB0tHDpdS3q7e/svrL/ZntZYsZmSQQQiZCpXPwZRqSNFk0TN7+Z/Xp2K5Cot5h5VpW+keFcofmHpyMZ0grxc2oPpGqBaf0Y8qxUIms8KjWRMX3MT+CE2S9v1WUuRyNX734YqD44bmbyHi2qENwnQzCUolL2l+2dwjKjSRm4dTacGvoy1r6So2kxwpiWcZucf4H050z3W1okWUGOrimaxMh4QNvGTeYBpBkrK01kcBZkUhQoNIDMB/wyQl2Cn1p5099safqybyx9ijHactx+sm28mGi2PcYWl77TN5Iomm8xcqxtc9BMzWrUeMwW4eaOLD7vpCZenDsL5VZvMjiPdSmmbjW+c3jeP+3GAJohUAORNGn9N8DDvRg== X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1306;31:/t1OU5Rfgkljgrj5/8eDxahyPcZd+qmSJ8D1+7FfcVHYMPSgxG+sD1CaI/SUeF7qWLevJKv4wk56mPUlYjUNvPCxqtD2flSMmMUYBkp+S67CtVNp0g9BNmzX2sVya2RA9tb8fA56g0G/KmE/tGGLH+7xEOwpA5juZqCy/Qbd+UYtc1jmvQxOHEXlm4s4vhI72NXwnaaDJNN00/G4EsqGgGW+BlqYIklcRtPd5ZlRl+UO0gX0PzDcMj0Ox89nfbHshbO/8i6KAIU4+1YWAlAUBw==;20:xtSUSyWavUpQHS8UTWa/alkWcKCEaNZO5c5iG5fWOAFIBsDIqwgZV+x2DkK1amVPbNUKo5tep3j2+gKpoqBA7cBaPeD6MDDKungNQThHZzGEIqA59GA8OJL7WfvVDvy1Vg9b4d/4KmqeoW+sVotvE9wJzOcxfpUsT3sq9zi+gpVAZq5fdoYkz2nbBRMWvubVQE42nG4liNG/Z5FofhOzCPSkzOvFFdszhk0QqEqOW6Hl0XgGMJ4pkZQDpsnS9y/p9mbS8aYLbCGbYsDj43khoQxq2dRkBy1IppcbfnydzAxRlATOQ3Ic9RZvIj5lI57zolfpVtg+YmTpJIr1f+MyJ3D2gwiJW2KfQDkTL97CJI693+fiAHcBoMP2+Hydc2mPj8pr2hhHTf3EjyjgF92KizRw+Sb64jnRp+NXd/WzcD4oQ8gsI25I+KzsaVp3oJ6u0P7D0TcSxt+394PsBD4K3XkU2N+sFLE1bWhjnsHU4yqVMDAEkn3b81fg/gJfub0E X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(61668805478150)(9452136761055)(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026)(6041248)(20161123560025)(20161123562025)(20161123555025)(20161123564025)(6072148);SRVR:DM5PR12MB1306;BCL:0;PCL:0;RULEID:;SRVR:DM5PR12MB1306; X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1306;4:O5x64x3NhohKOrtCs4tuG0TMD+XyNmes1GrkMw7oi4vO5SJhrgXtoxHq01Gooa1PpU2Yf+rukKtGfjnXap8900NlJvg3d8nvsRtnb6VwshnV3DXu3eHv8IeI7ZTUYrd0q3DTL6F/lH+iR4rGv6woXM9IgJ4PYs9bx9r9OExszb3AKimmaYFwcTxwG4d8oSE1YxYYRNNyR/W2GOks0T4hGCloSA8i3bB7VrK6aW7bpxPQ+QcGMb1VklxUALeI3sTUwGZ83yZYgGJGpVsDR2SZhGpg0lIkoiBbOkm8yl7iwGnXHWojHgPddTqwo0EKAkl8yOB4Y67Eru9/RdxxVLYqOiu7J1MkE7Ap5gCJKsvBizRMM29AC81cVxL2Jby7grP1PEbF60FoldpzmiR6K44S7QHBXeiCpAT51lSjZXkM6JViN0P+NQRH7rjP0Up+mS+8yz9LnDO6rcrxnpPJBcFcLCqNGcDLVUNXvEQiSScntRvzD9gtpSwZmxjhYzWSdu5XgK5ENDT1URQkSE4tL/dIHS7q13qjBnjAcNQW5veSAQgCUSloCEIX1/VhAi42G8POegswdr8SbRyPJeKptb5fsgNKPVTVNf6xwuXlR1j8Con8/sKY6eNNuqdLsvXw5v3ptZkO4rLzOtmb+9crAcK2Udnnb1HTNt4To3nyVyosK/QbKy+PbGNHIGeIBEBRuD2o X-Forefront-PRVS: 0200DDA8BE X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(39850400002)(39840400002)(39410400002)(39450400003)(39860400002)(24454002)(377454003)(51914003)(189002)(199003)(64126003)(305945005)(101416001)(65826007)(33646002)(106356001)(2950100002)(92566002)(2906002)(31696002)(6666003)(42186005)(6116002)(86362001)(47776003)(105586002)(93886004)(4001350100001)(7736002)(2201001)(76176999)(31686004)(54356999)(6486002)(1706002)(25786008)(229853002)(36756003)(83506001)(189998001)(81166006)(50466002)(68736007)(2870700001)(6306002)(65956001)(107886002)(81156014)(38730400001)(65806001)(53936002)(8676002)(23746002)(50986999)(5001770100001)(97736004)(5660300001);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR12MB1306;H:[IPv6:2a02:908:1251:7981:5d6a:1040:c41c:5a5];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DM5PR12MB1306;23:axC2TUGCPHciFtgRYV7bgNKDTuyiqKArYi7LK?= =?Windows-1252?Q?sYms1PegPpPOomznDXAT1uE9jPRebzIAMjFswguyE/pjQWFcF25Uh325?= =?Windows-1252?Q?KZCIzjwcDpN1MwhGJ/MDZPaY1UAI/+V1zHF1XhFMl06anuBIUI3ooDaJ?= =?Windows-1252?Q?NtPxQfAN30YXjYWZ3wil3bjmcLdiVQlcKCxQF7z1BK62QF2uTi47Mcsj?= =?Windows-1252?Q?TTD+J0ACsELduJheXtpjqoSfU73lbu/ZqZeMZtUE6+WRxkRBMPMHvP+m?= =?Windows-1252?Q?o/TF+pD+EWwXlZeQIXDe9FGqc+pkN6QYGy4CEYA7AYPguAphEoPdO7x6?= =?Windows-1252?Q?Xh0fnjf4T5/cqWUTZelGthq9CBLk1ei38XKuTiqrk7HKDQPbEray/3j+?= =?Windows-1252?Q?7pPOSplczX1kyYNgR5VIxreUzB0m17cdiSfwGo5Frc41rmeFWohoijYO?= =?Windows-1252?Q?VJZJmLiuo5/ejflQS7qBf9fOR1A/PGcLZcYFRiqCHCCFfLZr6dYcN890?= =?Windows-1252?Q?ljVyklHjPVcIMcYZVzJW0NbM3HDlrgt9uMhVJA//oBHSPUwNmSm5JVJZ?= =?Windows-1252?Q?90MgY9MXDPf8JF5bLxeP/kT26YGRAHy6EmjdVx1DXcxwxO0ihjm/REwR?= =?Windows-1252?Q?bVwkcibmwzHnmuO7hGjWMepivAfnmRe+x6ygxn8Fpdi7UbzI22DkU6rp?= =?Windows-1252?Q?cT8LmWx5A87fODoZ7Cxo8inGXLZ0jv/fvngZitwkEQ5ItjwKidSGdoPp?= =?Windows-1252?Q?O60FUGL/yuwOZZoTcPa6sf5hHKdH5xD2JMXn7oZRLL6R1lu+ArrMtDQK?= =?Windows-1252?Q?epjabc8kJw06dC5x+pVb/K1tfzP+0Psn60t919trRMSn+etXGOniFho1?= =?Windows-1252?Q?m34kyVR88vKB5IoHm27P4si9iCSjESBT/lu7giDE/qbPYNu9DuZixWWw?= =?Windows-1252?Q?ROM+LbnywWDD31MJHC0Eb14pcFj/cz1hWlbc1zBnW6FUOl9Q8bddK0pR?= =?Windows-1252?Q?IareMTIIwSi42HE9QgVzDdLEbOVYrEXtQL5eKI6BxzYv11REBVxhHTDx?= =?Windows-1252?Q?/f0Z2KFH9Vbbl8LT1jQsxZmVN5MhJHUyYVpk2mThH8DioS4dHEFsPSKy?= =?Windows-1252?Q?hPWgCGxedcIneBOGy+e+4FWMd5WXaMdzCH02YzmFrNK+x+1nFUTY/yym?= =?Windows-1252?Q?PBzpepn4PYic18Ms4SS5oD9xdDx+J9LS/eXtXKPOJO4Tjxa+1f66SDTJ?= =?Windows-1252?Q?fWf55hGkqUCYK6JMXr6yGOzIhB8adychuUz+S554oJHpeJ8PGjaT9AWM?= =?Windows-1252?Q?iXACVOZdp8jfHsvSi9aoUaucZ41q2VZHkWhbVDhqBkU1dWmRb3xDH7p1?= =?Windows-1252?Q?Y5xHTBu/P6cc7CgfNskGBnTSIL46F1VcMwsiVune5K38w869R3pYOcNU?= =?Windows-1252?Q?jsBQEBSRbvi4bPfeOgqtM0qVVX6//ngqnPVV5KlJ3i2wakVm0UjL4uFl?= =?Windows-1252?Q?+AYf72AapbK4WMiSdS37+1KCbCZMfxMcRHksE8YdWEEb4t2cjIRVP/2J?= =?Windows-1252?Q?iYHLgWgRwJow78Fa4MY+FVOAH4ujmamLtOj?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1306;6:kQ6MjVlzhkpWpKhY2bD/cMUrlLXpJ25JWR302QzwxEb0pOOzxGt7rhXZIcU6cveYYX8wHecNrMkMRSTtSZCaGqKb97nSfYcDYF2KulskBC5Yt2m9AgJ3Q8WCAmjA1wI/cj9Z9OzH1gLsNuNeQ9Ku3q332u+yGxEXz47yScQZ/lOVrGMwf0eWLLevqR/pc5oZgE91ohp5LGkaUKCAI8CFHxG7TnEwU9I38YNPwIxhFVBqmPJ+PHfweiMt73/nXzrmCEaYqUu2pX3wCJywNqoVhMs0Rsq0tznZpYOx6EcfPWgyxlEo9D2FXL0HkWAPiuiYGJTgazVwEJD0B1EVgAgHtp29JMAHmzjst++JiKu2REjGBkHvsUCkQ3GUPql3CDNL0+pD2HOK1pOr/aNfvZsHu9GocAbs3b6lSUQ0Xt7r1SkUILH97frUjwH65Jfz9YBD5tMnIAqPqaycRxMfVmiYEg==;5:HbjCGAfHW3sewxtE71I7yjVW/OtOZY4cq8eKnJP8hERCQ69C14tR3yTiqbt5joBlminipQ6KudHxH/NIEHPJu+9KNI2K2uFIIQjcj749xvDZV9gLh7IYjRlKHCL0bTfxwvXWqj+3HVigIcXZJytH0A==;24:jD/HhZFoJpnuoxGGvjyXAP1zgcJxKNYw0vvjL1HtS0GnuRnsTFMhAhZ6I6l2AGF4UWxWvZUCErpsGlJmnUCkZtFCCaWibu4Z51qxoqAzomU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1306;7:ChFyCp4LfidRWv/iuQnmqP9bGiPUuuws/BuFLwQ5zzJJVoKIZMInDukrV8Rd8+lPyFEo15kvBkbHf+IvDUzi5svaDxXHhfYl9TaC0euWwspOplZkafUEHHIG92ppa3YkfwEaHvjkW5wnZrD052ClugEsL1oAb6uDBWWvfFLBgvl1Qrydt6bwAHd5r/9S25pfTjDn/QhlJewX0YHslTKAp469GHUcFIvYHkW+QdUL0wRk32navd/KzrOVEdZur6nPdwdnO2nDqgcEAOgwbSoEkR6lRIwUVwPOsWsm8bypvsMGuUz9KVvzT+uGpiFOk7AUY0Zf2JluLMotKxgxO60LAwxm6Bl9BaSZW4cyd76UMYwYOq/9saPsSEcA6EUHqsyffrzimOU0aB/DzRsGoToGsZlSVZfMz024yMNJYcB0OFXn52avB6jSCv0eISCquvjhT1QLHK0fNyKBiGm7MNnQEA==;20:5RKCl+XO2cCAH0V/916OBmZDNXDBZAcBqCZUUs77b0VP8rJk+g+Dr/rFutvsUlNIe6R9zN7iJuRpLw7Z0mE3RtF4whw8OoQR2eeRYWB39qDhYn+eJu+gp/haslRboTt5+Bgfj+XAKOHuCfsW6wExvTEAioRvzjwH2CzF1DZpJJ4GC3akCXXSYPbp63nAIjNQBh4KRWASVnUs0lAp4+LdYXRQVXuvu3ZbZdUyFh+DD3UzAueKpTLLVb003fU5jnSt X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2017 14:43:28.0433 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1306 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 27.01.2017 um 15:12 schrieb Daniel Vetter: > On Fri, Jan 27, 2017 at 09:22:47AM +0100, Christian König wrote: >> Am 27.01.2017 um 08:30 schrieb Daniel Vetter: >>> On Fri, Jan 27, 2017 at 07:23:58AM +0100, Thomas Hellstrom wrote: >>>> On 01/27/2017 03:29 AM, Michel Dänzer wrote: >>>>> On 26/01/17 09:46 AM, Sinclair Yeh wrote: >>>>>> On Wed, Jan 25, 2017 at 10:49:33AM +0100, Christian König wrote: >>>>>>> Am 25.01.2017 um 10:25 schrieb Thomas Hellstrom: >>>>>>>> On 01/25/2017 09:21 AM, Michel Dänzer wrote: >>>>>>>>> From: Michel Dänzer >>>>>>>>> >>>>>>>>> The current caching state may not be tt_cached, even though the >>>>>>>>> placement contains TTM_PL_FLAG_CACHED, because placement can contain >>>>>>>>> multiple caching flags. Trying to swap out such a BO would trip up the >>>>>>>>> >>>>>>>>> BUG_ON(ttm->caching_state != tt_cached); >>>>>>>>> >>>>>>>>> in ttm_tt_swapout. >>>>>>>>> >>>>>>>>> Cc: stable@vger.kernel.org >>>>>>>>> Signed-off-by: Michel Dänzer >>>>>>>> Reviewed-by: Thomas Hellstrom >>>>>>> Reviewed-by: Christian König . >>>>>> Reviewed-by: Sinclair Yeh >>>>> Thanks for the reviews! Via which tree should we merge this? >>>>> >>>>> >>>> I don't maintain a TTM tree any longer. Let's check with Daniel if he >>>> can merge it through drm-misc. >>> I'm trying very hard not to get volunteered for ttm maintainer :-) >> Yeah, ok I volunteer. Wanted to take that over for a while anyway. > I guess you didn't use the dim magic to push it? The test integration tree > isn't rebuild ... Quickstart for the tooling: Autsch! Do I have to use that or can I just go with my usual tool set? Would probably be a pain to set this up everywhere here. Christian. > > https://01.org/linuxgraphics/gfx-docs/maintainer-tools/dim.html > > -Daniel