From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7915CC2B9F8 for ; Tue, 25 May 2021 07:11:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5052E61005 for ; Tue, 25 May 2021 07:11:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231522AbhEYHMu (ORCPT ); Tue, 25 May 2021 03:12:50 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:56917 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231480AbhEYHMs (ORCPT ); Tue, 25 May 2021 03:12:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621926676; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7mLmIW6ehg0LCjXEELVdzJZToVTG1vKZ+tSeDNW/S8w=; b=BgJyl5SkbW+HvzQOebGY2fUdmVW3fMTPfNeEEiWooJwhgfgRvFr3fReOiSiC8nAqU9nGl7 Y9ZXleNCtYw/4POrpiFuFL6J9IhhGMHp+Jw1AfSUuXz7zlfsfX1fu+9n/iDs1LQNvHB9BA 1Gr2oQEye6pG+Ushf240VvsOTG0fKEA= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-368-hFxloFD4MhijVOnhUcB2FA-1; Tue, 25 May 2021 03:11:14 -0400 X-MC-Unique: hFxloFD4MhijVOnhUcB2FA-1 Received: by mail-ej1-f69.google.com with SMTP id h18-20020a1709063992b02903d59b32b039so8298008eje.12 for ; Tue, 25 May 2021 00:11:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7mLmIW6ehg0LCjXEELVdzJZToVTG1vKZ+tSeDNW/S8w=; b=UuJ2lLIzvizcmWIABw3sp1voBStXkQ5ld2TvGrdmHRUPZODXgb4dZIbf8dRipu4O8S bd4NiQA3mHqQFFOm4Pq+i5RHbssgpk9qHJ8aKA9QDa8++GJUjsygwN7idoNglXzGrM3u ct20OslP6kNBEJQ5ptjDm5x33ujGChIRd45ounCUN0QlWrkjVJdNy/S8jG07wMOy6kgu +XkDF8/xRkdVDEqxkSxRbhXAHRDMQyEPbdqQWiKxRheoQdSz175zH+Eu4vmXPArKkJSI WVnNAPKQmHKR5Q2zndujF0HujAAH8HllWxchUSdIos0Rqifb328CDexFvdwlzx5DW1Rq stAA== X-Gm-Message-State: AOAM533WgIeIqS16Br6rJaeuAPBoh3QWgWGycidWTA8pBNi0P6rppMCz oMX6X5rP8j9NQe+YJcVx+wgBPeRKIQzIpKMZ28Eh7nQWnxcLptIPc0rmmMw+TyI4TD8Qli0wjH1 cNMZ1YcRPxxBdqvGIOvK6CnrSvpUb7bgT/RM10U5o2d+/ScdrO+lWMVY39E3ihbtnvROLghCQ1I mx X-Received: by 2002:a05:6402:c8:: with SMTP id i8mr11472869edu.380.1621926673194; Tue, 25 May 2021 00:11:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwiPJkqMYvGP9jvqBWS9kpUE2n3iiJUQJOaGaZuwoHN+m9v6QC3OymSTLFWevkXIv8urAMHkQ== X-Received: by 2002:a05:6402:c8:: with SMTP id i8mr11472845edu.380.1621926673036; Tue, 25 May 2021 00:11:13 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id n24sm10390224edv.51.2021.05.25.00.11.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 May 2021 00:11:12 -0700 (PDT) Subject: Re: [PATCH v2 5/5] KVM: x86: hyper-v: Deactivate APICv only when AutoEOI feature is in use To: Vitaly Kuznetsov , kvm@vger.kernel.org Cc: Sean Christopherson , Wanpeng Li , Jim Mattson , Maxim Levitsky , Kechen Lu , linux-kernel@vger.kernel.org References: <20210518144339.1987982-1-vkuznets@redhat.com> <20210518144339.1987982-6-vkuznets@redhat.com> <82e2a6a0-337a-4b92-2271-493344a38960@redhat.com> <87fsyb8h7s.fsf@vitty.brq.redhat.com> From: Paolo Bonzini Message-ID: <2b8d0e27-a893-b090-7ecd-df17eefdf6f1@redhat.com> Date: Tue, 25 May 2021 09:11:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <87fsyb8h7s.fsf@vitty.brq.redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/05/21 08:23, Vitaly Kuznetsov wrote: >> Should it also disable APICv unconditionally if >> HV_DEPRECATING_AEOI_RECOMMENDED is not in the guest CPUID? That should >> avoid ping-pong between enabled and disabled APICv even in pathological >> cases that we cannot think about. > When you run Hyper-V on KVM it doesn't use SynIC (let alone AutoEOI) but > we still inhibit APICv unconditionally. The patch as-is improves this > without any userspace changes required and I see it as a benefit. Going > forward, we will definitely add something like 'hv-synic-noaeoi' to QEMU > to make non-nesting setups benefit too but it'll take a while for this > option to propagate to real world configurations (sigh). Ok, if enable<->disable APICv becomes an issue we can also consider disabling APICv forever if AutoEOI is ever used. Paolo