mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH 4/8] staging: rtl8192e: Remove unused variable last_ratr
Date: Mon, 2 Oct 2023 19:53:26 +0200	[thread overview]
Message-ID: <2b91a8f4ec6184c2f16b8f65bdf65c69a4d17458.1696266964.git.philipp.g.hortmann@gmail.com> (raw)
In-Reply-To: <cover.1696266964.git.philipp.g.hortmann@gmail.com>

last_ratr is written but never evaluated. Remove dead code.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
---
 drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 2 --
 drivers/staging/rtl8192e/rtllib.h          | 1 -
 2 files changed, 3 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
index 8f5e4b932350..52b9393b55e7 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
@@ -370,8 +370,6 @@ static void _rtl92e_dm_check_rate_adaptive(struct net_device *dev)
 			ratr_value &= ~(RATE_ALL_OFDM_2SS);
 			rtl92e_writel(dev, RATR0, ratr_value);
 			rtl92e_writeb(dev, UFWP, 1);
-
-			pra->last_ratr = target_ratr;
 		}
 
 	} else {
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index 004818520ea8..1e474691aa88 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -1164,7 +1164,6 @@ struct rate_adaptive {
 	u8				ping_rssi_enable;
 	u32				ping_rssi_ratr;
 	u32				ping_rssi_thresh_for_ra;
-	u32				last_ratr;
 	u8				PreRATRState;
 
 };
-- 
2.42.0


  parent reply	other threads:[~2023-10-02 17:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-02 17:53 [PATCH 0/8] staging: rtl8192e: Remove unused functions related to removed reset Philipp Hortmann
2023-10-02 17:53 ` [PATCH 1/8] staging: rtl8192e: Remove unused function rtl92e_dm_backup_state() Philipp Hortmann
2023-10-02 17:53 ` [PATCH 2/8] staging: rtl8192e: Remove unused function rtl92e_dm_restore_state() Philipp Hortmann
2023-10-02 17:53 ` [PATCH 3/8] staging: rtl8192e: Remove unused function rtl92e_cam_restore() Philipp Hortmann
2023-10-02 17:53 ` Philipp Hortmann [this message]
2023-10-02 17:53 ` [PATCH 5/8] staging: rtl8192e: Remove unused variable rate_adaptive_disabled Philipp Hortmann
2023-10-02 17:53 ` [PATCH 6/8] staging: rtl8192e: Remove unused variable rfc_txpowertrackingindex Philipp Hortmann
2023-10-02 17:53 ` [PATCH 7/8] staging: rtl8192e: Remove unused/constant parameter mesh_flag and shutdown Philipp Hortmann
2023-10-02 17:53 ` [PATCH 8/8] staging: rtl8192e: Remove constant parameter from rtllib_stop_protocol() Philipp Hortmann
2023-10-04  8:19 ` [PATCH 0/8] staging: rtl8192e: Remove unused functions related to removed reset Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2b91a8f4ec6184c2f16b8f65bdf65c69a4d17458.1696266964.git.philipp.g.hortmann@gmail.com \
    --to=philipp.g.hortmann@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®