From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBC61C32771 for ; Wed, 28 Sep 2022 07:59:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233827AbiI1H7B (ORCPT ); Wed, 28 Sep 2022 03:59:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233549AbiI1H6y (ORCPT ); Wed, 28 Sep 2022 03:58:54 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F8EBF370A; Wed, 28 Sep 2022 00:58:53 -0700 (PDT) Received: from fraeml701-chm.china.huawei.com (unknown [172.18.147.200]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4McpkT3r1Sz6H75t; Wed, 28 Sep 2022 15:57:37 +0800 (CST) Received: from lhrpeml500003.china.huawei.com (7.191.162.67) by fraeml701-chm.china.huawei.com (10.206.15.50) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2375.31; Wed, 28 Sep 2022 09:58:50 +0200 Received: from [10.126.175.219] (10.126.175.219) by lhrpeml500003.china.huawei.com (7.191.162.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 28 Sep 2022 08:58:50 +0100 Message-ID: <2b9a216c-dd91-d843-4a84-ac7ec78db853@huawei.com> Date: Wed, 28 Sep 2022 08:58:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v6 5/8] scsi: hisi_sas: use sas_find_attathed_phy_id() instead of open coded To: Jason Yan , , CC: , , , , , , , Jack Wang References: <20220928070130.3657183-1-yanaijie@huawei.com> <20220928070130.3657183-6-yanaijie@huawei.com> From: John Garry In-Reply-To: <20220928070130.3657183-6-yanaijie@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.126.175.219] X-ClientProxiedBy: lhrpeml500003.china.huawei.com (7.191.162.67) To lhrpeml500003.china.huawei.com (7.191.162.67) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/09/2022 08:01, Jason Yan wrote: > The attached phy finding is open coded. Now we can replace it with > sas_find_attached_phy_id(). To keep consistent, the return value of > hisi_sas_dev_found() is also changed to -ENODEV after calling > sas_find_attathed_phy_id() failed. > > Signed-off-by: Jason Yan > Reviewed-by: Jack Wang > Reviewed-by: Damien Le Moal > --- Acked-by: John Garry