From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753090AbcIORpJ (ORCPT ); Thu, 15 Sep 2016 13:45:09 -0400 Received: from mail-by2nam03on0078.outbound.protection.outlook.com ([104.47.42.78]:22117 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752730AbcIORpB (ORCPT ); Thu, 15 Sep 2016 13:45:01 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Christian.Koenig@amd.com; Subject: Re: [PATCH] drm/radeon/radeon_device: remove unused function To: Baoyou Xie , "Deucher, Alexander" , "airlied@linux.ie" References: <1473948831-27667-1-git-send-email-baoyou.xie@linaro.org> CC: "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "arnd@arndb.de" , "xie.baoyou@zte.com.cn" From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <2b9e04e2-ef1e-0c26-b296-c47c9191930d@amd.com> Date: Thu, 15 Sep 2016 19:44:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1473948831-27667-1-git-send-email-baoyou.xie@linaro.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [2a02:908:1251:7981:5036:9c7:9152:f15b] X-ClientProxiedBy: HE1PR02CA0052.eurprd02.prod.outlook.com (10.163.170.20) To CY4PR12MB1304.namprd12.prod.outlook.com (10.168.168.141) X-MS-Office365-Filtering-Correlation-Id: 777a4273-68f5-40fd-1df5-08d3dd90026c X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1304;2:ja8ofF6BQLUbYKsaRGztmBsOA4FkNldYgv6oUVMmbECbsRqUeQBXrsgvi1Y5eBxb8X5SLX+MuxyrR7U0/4Y7TP1Z93BxeDiryn+4UJB7GJQA88RynFqFGLEYujUr6eAOB4ipRzVIvDneiGHEEjl0EfCLdm3jjPNUNBl6UEkiqJzPrLo3QUESloqyJ5p4oOZp;3:zyw4lUbjYJ7eaFn/ZWPF5eLkp2958JPyg0sRv8E3m4Y+zmoOcTuex6iloiV8giAi+WyKeBdKyx0pOladaluQtSdLb/f3SBmUeMWgNWGj0ikr5ERHnLwTGYi9016Vd7vY X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY4PR12MB1304; X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1304;25:L+KFX6nwhBAbdKv4rXEjHdJIwfT1vrJvxmvEWcL7Dl0PLx1PZSdKEG455mSFlvGuyszpUSuZOsyF7tk4jyOAuhnRyErTPMUnaJ2XFLCjdS3l0Jylh9Dm/wSLV/gKWuTLY51PM1GzSw5b4v/lWqpVhG+pej5wztB8XEwg1xZZOs1EiRWGbHpazQC5Nw5di1WAOHWj6OHNm9wLZq5rwzgkMI9SE8UdlmY5q+cYIWBiL3waVypUiO3iFH2ds3feWnQT05Qr4K+Qv9ArYvWqSXv+P5Sz0Mie/vAfMION6GfHIoxQXOMd545a7MCmhw5AxcfaG+8wtZ3sT6nQrVklycTtiGMnY5b+uEZRJTUCnxlFhWzWPBixZc4O4gUt8Ffuju3BrPJdrw2SzUWgWcJpK38nuzncN65E4036uSBJKH0HQSpQAQtlyf8OtzNeekCRVfS5j81JvInDHkp/Q6MWrTfC8rswWBMOdIh+LVBTQRCAg15cXuvw0VSc6Yw5R4gkAGIC+ylC9AHsf+vBgSo+qXKUMC88gz4X/fh808/D4O6AL/sLVxrhYKg/kwPnX4y8cqemNcteEWtWJycXut3pAh1vREj7XnXER6/hpcwP1DdEnQANaOlX5DKGawxsrQUHgRZr52wYGM7Bvfz36wkrYynXNtZ7oYJtI7i940PoWPs7hTh2N24+fBZB/YaUkLf40Ozkc3yzgUAJOzlrDrQLlgJZQS3HejTzBraf+R/78huAiN0HWjr5kfPFtAJunzjvbJl/ X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1304;31:ox10UH7ETqngiib4RiMnpUA2zYUVOX+ERSQFLlFRS5TdTojBZE+PtyPAdSOkZ+dq8xgyqIiOSLmGt0B78IMJ7zJ9hJClhoX0KJYY/llo+j6UH26iGQ8AyIAfQ++lpc8qgHG9vGa5+qpJe5XeZ4yjHn4NfM9BapmhoM1x3Eqz4mMAwixk6Lx3ALCEooU9MOsHYP1f8jgaU2ytDfUorndGb6ybNaGwFlivUZ5cIx+jyc0=;20:gcmO5GQKERyzvXrrVqZ/w+f7/W9VuNbqAav4Vmq5HyLzrWc+5G/rin0PR8RWOlh2/BjfSwOkdA1Ol/sQl/FMLliqOEMGk2chpxwi8yOe3X2qfOZ+kNeMgN4zqluheOGT/rjWti9vFvJU/wcX9QXQvwdm0Fo3Pe4MHNAU2rFpWkiUFLiuIO94uufDISpUaNlIQBBjrCiyW44cE6TGENpOi9/Sms7eHspSLO7tupL8Xo1EJXBZDi+onqXptbLaIrLDp78vBJ54Wx7fyNfGlQGHqp764dipmP4U4AOWVeFarwmJeg1dvaWDwH1Ac8dEiyzRV79b3DkURJG9lVNR6Lji6u3crjddRCA8LTkwx7/eAWJPnYRGpcHmEY75WcRlZ1MRiVyXCrEdYfAlnpjswhrHASAyf9JaoaTADtc98Nd9bciFVixPRhpNqevk3Hq6DsCc0PSAVizQj3Qbz8nHnvGTcCgQTp+NQ99+SswiyMCnrNcfvaFrDfLZllMyoSzP88SW X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026);SRVR:CY4PR12MB1304;BCL:0;PCL:0;RULEID:;SRVR:CY4PR12MB1304; X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1304;4:pLKGTe9x0sjvJ4LylhKy4yOe5hEegbpC+yLpEv5TBtu3tJMlQPkZZCyaxNPTwTjX/P3n5/xd2pftMCEfyEw5BJ4IdcF3qDloLSUUhJ6NmcWqjsRlWzDaXArxy8BIixVBkVYl1NM8zFyikvbuiCb86MRslDKk1pn0srfValMdyIFutUiHxkUFsST2zfA69RyEcgeVLIzyUHrCgfXkZ+ke33ouhiLbgWF3V164aJaMLfjA6a7B3gJy2QSBI1J9YfLlrw4yfMItn39ubjt5L5/9/ND2H9Bz6e/7xylS1S4nCE8n2uF112dfznRZ3ajvOuFYahNBDxdy2vb+nQa3GzcDa3iQlV/AL1Iw+38bNJM7inai3u/u1ydwMpdD0/s7huEJIrhfqh/dfb4hz5LkL//YHRLd+IwZyQ/v8QUCAr/AFSb0Q4Z/m3rVbHw8qDVsazWI X-Forefront-PRVS: 0066D63CE6 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(199003)(189002)(2906002)(81166006)(81156014)(92566002)(8676002)(36756003)(4326007)(31696002)(23746002)(31686004)(50986999)(76176999)(54356999)(101416001)(65806001)(42186005)(2950100001)(64126003)(106356001)(105586002)(50466002)(2501003)(77096005)(19580395003)(68736007)(65956001)(6116002)(1706002)(83506001)(2870700001)(586003)(47776003)(19580405001)(7846002)(97736004)(7736002)(305945005)(65826007)(5001770100001)(5660300001)(33646002)(4001350100001)(86362001)(189998001)(3826002);DIR:OUT;SFP:1101;SCL:1;SRVR:CY4PR12MB1304;H:[IPv6:2a02:908:1251:7981:5036:9c7:9152:f15b];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;CY4PR12MB1304;23:1lsTLpJfGTBwpcjygeBY5Odtirv11b3iyBT8r?= =?Windows-1252?Q?1itMAF3ntanNysCw1UY+yQmteWPQArM/h7/4NLITRnwTKKTWRW4JoMFy?= =?Windows-1252?Q?7CE7cVF2RpzD/B2x6ZjGd4vs4to2X4PEjjLRLNlB9QVCM/qbKGVDU5AA?= =?Windows-1252?Q?/eV7HMXoAOPIoCWijB5KuhJgzPq1KTY5eQT9iQJD/SIskfR6W05YgMvi?= =?Windows-1252?Q?LyUFxJJUOvJ/qTcNpo4eW7YBA7fDUV+qSrAsVlRi7+Jg+chjxaksLKog?= =?Windows-1252?Q?OTo+NECCxzsOx920EHQXs/Dqn7bbFt/9Y7BR8GRCsORXIPH/skmJo93E?= =?Windows-1252?Q?3lLlRRQ0qe1k4C1l0/yrW72OrT8K0BPWhut5CKlBB62RDHWZ0ycKrohY?= =?Windows-1252?Q?VDCQMu8Yy0OYscyRDCOhuvqYz3BajwFN7fVs6RBGUa6FWLDkLFMHEF4g?= =?Windows-1252?Q?FYTEQ0NIJWkfqywgBTb7uJArqqnI0sTKanfuzvUC/iVI04qz7YMs3lpv?= =?Windows-1252?Q?Wf/9I1dpNReORPi91GDntjSVDYpvl6eYouecU30vCz12ySBzEBHj5Atg?= =?Windows-1252?Q?BTVrRKf5G5fpXctX3HqO5H6JhZcQOJ1uMYTYie0/ypOoY12QglS8AVhG?= =?Windows-1252?Q?FDW7kkbToIqHz8yflBZMHlKQ72FRdZCTwBYCz/3Vz1szzr89y9op4Q/W?= =?Windows-1252?Q?xwBb6SsiXjPWkO8YW4F1nNKbAgYBq/z8d4iQ5o2LP/EnhhkXa1oBkgHr?= =?Windows-1252?Q?J0tamPxDe+mTuJStmbaKOj5Q84zAHQ1RlRxPMz9//8ysPriki6Di/tL2?= =?Windows-1252?Q?3LB2Xlo6Tt4NSuw85EiKdUalJiGvZhgugCEMY469ZPlWzLk8YXCt7rx+?= =?Windows-1252?Q?/VKRsli6KdRx9sWJFkisD8atTcA/UJczKb66iwv/SKoH1cBjlNOx19hl?= =?Windows-1252?Q?XcrvVd2g7nTtaIFvSprZ46hZfnLIDS9bpJABOx0B/xMwIXNjYGBj61MW?= =?Windows-1252?Q?w6MzASYtsUZJz8cVL7kUY00C2l/8Qdk4iqq8jQAoYlaBxzdBtASxlUBP?= =?Windows-1252?Q?QrHCd1rsNmy+12IkvujWwh1FiB31GBKySzjWP5f+MMXWrP/oq/+g5ft8?= =?Windows-1252?Q?pa4tLwFSWo0qY1vaMEbFxzbeqnihezWVQlDMhDYxNEfwNtjDRZHx1xRf?= =?Windows-1252?Q?FCi0qHB3EwUhyISvKLCkaqYq1VmsE5apTjvI4l1OsKvUHmy8e7iIYrB2?= =?Windows-1252?Q?h5Wi6W2V/wR0Un2VoXSWi30gOAEeH75iIEwJHru0YX3RwwBDZk39t43o?= =?Windows-1252?Q?4x3M3bI3eEdMoArEqkRZx4hVnFnyhYtxUgRMwKPxuUGIuI=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1304;6:aRLhBaXbk3PR+cbngmWp7l2QWZfA6dLqeZI1iPqWHxFp77GkpB/iwj5vrpyzT++r8q+flUd0kTOsGQlTLkCzGfDxuO2L0OzPEGH0MCLKA4u232v7di/XbtZ4x6ujU2ghCGJf75ysqcmLpzCupC5aIPJFTlT+v8OtHtyxWoKpWECWIch1Ap0JznA4bEXTiTeXPQg4Evbu/cn7NKzwZncGzh4t53AIHefIC6NEo4k8Efuu72ZWDUn9lJhJv/578rTMIBDUvZ78XqQX+gKQ5FQXfev6smPHtH4uMCcDEbonAFy9uWqWDU/ufKNOJoIsBTtdIEXxIYqRgfbfSAYo2BOnDw==;5:FWqypaj1+oUm6Q9vJ750xsPOywVfZ8zF5guHRDXLXRwM8bAYDbVUJh6Hiwod4fyodoL71a1Lqj9VhmMDN6+P7ebxqHiTe96DstgoUGkA8N0edFb3JNAcf723+nkz1jchotDsElUVO7qzAA71+6YD+g==;24:d7+IuUe1n+bBQ6wAIG8e7LGyvkIA07g/CCMkAV/x+VAdzGWESgJtIYHHes8LtCaYuWWlI5TNBnjIrzZESLsMpP8tA4pZS1nMrXq4IczbPLo=;7:Ds9Ng2yNsHirRt0tFhKoqkzX45wdHeFrGBkPKos29W20y5Rbah01rlPqhO4TIfVMmyC3OWY7C3QcSsCZPvWKxcoFebaU+s4p5rNy3vdGCCbLjbO6kdUduUW0kblvdj4byKAJFpvORM/w/2Kmd5/3PXWVO8Ui5s6JA5HaHA+sIn66sm571U5jo+tH66odrN8l1zyewnVGAzAYOtmfZ82FydN54mkNohI2Wc4LTjDzXZ+RwTITZpjHSxsYODloEnAk SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1304;20:xtDRz+HyCNgm0H3Fxu1m0QSAAX7DBeBeWoFfetIoHKucQd87S8v3a2tzLDjDkCXsRt1ZwFXSzOArXIsMUpFIj+JO1UPsMuHWIB/qFJvWChlZzLVHQdtlG/QHIncCVOMMlqjWIOBxWgG6TK5DUO5Bl4g/Lp3YopS9QaIZB0Bng6mENuzrltBWlApmxYuwROi7YCOWtLCbV+lf0tiVDUn0+P+lxIzGp9rOQ8tU1M0bpBGxqHN8jSccmoa+3RUXSWL2 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2016 17:44:55.0310 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1304 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 15.09.2016 um 16:13 schrieb Baoyou Xie: > We get 2 warnings when building kernel with W=1: > drivers/gpu/drm/radeon/radeon_device.c:1961:5: warning: no previous prototype for 'radeon_debugfs_init' [-Wmissing-prototypes] > drivers/gpu/drm/radeon/radeon_device.c:1966:6: warning: no previous prototype for 'radeon_debugfs_cleanup' [-Wmissing-prototypes] > > In fact, these functions are dummy, but can be removed, > so this patch removes them. > > Signed-off-by: Baoyou Xie Reviewed-by: Christian König . > --- > drivers/gpu/drm/radeon/radeon_device.c | 11 ----------- > drivers/gpu/drm/radeon/radeon_drv.c | 9 --------- > 2 files changed, 20 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/radeon_device.c b/drivers/gpu/drm/radeon/radeon_device.c > index a00dd2f..63447f1 100644 > --- a/drivers/gpu/drm/radeon/radeon_device.c > +++ b/drivers/gpu/drm/radeon/radeon_device.c > @@ -1956,14 +1956,3 @@ static void radeon_debugfs_remove_files(struct radeon_device *rdev) > } > #endif > } > - > -#if defined(CONFIG_DEBUG_FS) > -int radeon_debugfs_init(struct drm_minor *minor) > -{ > - return 0; > -} > - > -void radeon_debugfs_cleanup(struct drm_minor *minor) > -{ > -} > -#endif > diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c > index 07e4493..86bab2e 100644 > --- a/drivers/gpu/drm/radeon/radeon_drv.c > +++ b/drivers/gpu/drm/radeon/radeon_drv.c > @@ -156,11 +156,6 @@ void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr); > extern long radeon_kms_compat_ioctl(struct file *filp, unsigned int cmd, > unsigned long arg); > > -#if defined(CONFIG_DEBUG_FS) > -int radeon_debugfs_init(struct drm_minor *minor); > -void radeon_debugfs_cleanup(struct drm_minor *minor); > -#endif > - > /* atpx handler */ > #if defined(CONFIG_VGA_SWITCHEROO) > void radeon_register_atpx_handler(void); > @@ -531,10 +526,6 @@ static struct drm_driver kms_driver = { > .disable_vblank = radeon_disable_vblank_kms, > .get_vblank_timestamp = radeon_get_vblank_timestamp_kms, > .get_scanout_position = radeon_get_crtc_scanoutpos, > -#if defined(CONFIG_DEBUG_FS) > - .debugfs_init = radeon_debugfs_init, > - .debugfs_cleanup = radeon_debugfs_cleanup, > -#endif > .irq_preinstall = radeon_driver_irq_preinstall_kms, > .irq_postinstall = radeon_driver_irq_postinstall_kms, > .irq_uninstall = radeon_driver_irq_uninstall_kms,