From: "Thomas Weißschuh" <thomas@t-8ch.de>
To: Yuan Tan <tanyuan@tinylab.org>
Cc: falcon@tinylab.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, w@1wt.eu
Subject: Re: [PATCH v2 2/2] selftests/nolibc: add testcase for pipe
Date: Mon, 31 Jul 2023 17:41:36 +0200 [thread overview]
Message-ID: <2ba88bae-2986-4e70-9828-824d7b140277@t-8ch.de> (raw)
In-Reply-To: <C3AF612281F87D1A+733ce5c0d1efe1f81423e6885203d92cdb4eaee7.camel@tinylab.org>
On 2023-07-31 20:35:28+0800, Yuan Tan wrote:
> On Mon, 2023-07-31 at 08:10 +0200, Thomas Weißschuh wrote:
> > On 2023-07-31 13:51:00+0800, Yuan Tan wrote:
> > > Add a testcase of pipe that child process sends message to parent
> > > process.
> >
> > Thinking about it some more:
> >
> > What's the advantage of going via a child process?
> > The pipe should work the same within the same process.
> >
>
> The pipe is commonly used for process communication, and I think as a
> test case it is supposed to cover the most common scenarios.
The testcase is supposed to cover the code of nolibc.
It should be the *minimal* amount of code to be reasonable sure that the
code in nolibc does the correct thing.
If pipe() returns a value that behaves like a pipe I see no reason to
doubt it will also survive fork().
Validating that would mean testing the kernel and not nolibc.
For the kernel there are different testsuites.
Less code means less work for everyone involved, now and in the future.
next prev parent reply other threads:[~2023-07-31 15:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 5:50 [PATCH v2 0/2] tools/nolibc: add pipe(), pipe2() and their testcase Yuan Tan
2023-07-31 5:50 ` [PATCH v2 1/2] tools/nolibc: add pipe() and pipe2() support Yuan Tan
2023-07-31 6:07 ` Thomas Weißschuh
2023-07-31 6:13 ` Thomas Weißschuh
2023-07-31 5:51 ` [PATCH v2 2/2] selftests/nolibc: add testcase for pipe Yuan Tan
2023-07-31 6:10 ` Thomas Weißschuh
2023-07-31 12:35 ` Yuan Tan
2023-07-31 15:41 ` Thomas Weißschuh [this message]
2023-07-31 18:01 ` Yuan Tan
2023-07-31 18:28 ` Thomas Weißschuh
2023-08-01 6:51 ` Yuan Tan
2023-08-01 7:20 ` Thomas Weißschuh
2023-08-01 12:23 ` Yuan Tan
2023-08-01 14:46 ` Thomas Weißschuh
2023-07-31 6:13 ` [PATCH v2 0/2] tools/nolibc: add pipe(), pipe2() and their testcase Thomas Weißschuh
2023-07-31 11:08 ` Yuan Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ba88bae-2986-4e70-9828-824d7b140277@t-8ch.de \
--to=thomas@t-8ch.de \
--cc=falcon@tinylab.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=tanyuan@tinylab.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®