mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "genjian zhang" <zhanggenjian@126.com>
To: axboe@kernel.dk, dlemoal@kernel.org, shinichiro.kawasaki@wdc.com,
	johannes.thumshirn@wdc.com, kch@nvidia.com,
	zhengqixing@huawei.com, willy@infradead.org,
	namcao@linutronix.de, vincent.fu@samsung.com
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Genjian Zhang" <zhanggenjian@kylinos.cn>,
	zhanggenjian@126.com
Subject: Re:[PATCH v2] null_blk: Fix the description of the cache_size module argument
Date: Mon, 8 Sep 2025 17:58:24 +0800 (CST)	[thread overview]
Message-ID: <2baa9d5f.86c7.19928c331e3.Coremail.zhanggenjian@126.com> (raw)
In-Reply-To: <20250815090732.1813343-1-zhanggenjian@126.com>

At 2025-08-15 17:07:32, "Genjian" <zhanggenjian@126.com> wrote:
>From: Genjian Zhang <zhanggenjian@kylinos.cn>
>
>When executing modinfo null_blk, there is an error in the description
>of module parameter mbps, and the output information of cache_size is
>incomplete.The output of modinfo before and after applying this patch
>is as follows:
>
>Before:
>[...]
>parm:           cache_size:ulong
>[...]
>parm:           mbps:Cache size in MiB for memory-backed device.
>		Default: 0 (none) (uint)
>[...]
>
>After:
>[...]
>parm:           cache_size:Cache size in MiB for memory-backed device.
>		Default: 0 (none) (ulong)
>[...]
>parm:           mbps:Limit maximum bandwidth (in MiB/s).
>		Default: 0 (no limit) (uint)
>[...]
>
>Fixes: 058efe000b31 ("null_blk: add module parameters for 4 options")
>Signed-off-by: Genjian Zhang <zhanggenjian@kylinos.cn>
>Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
>---
> drivers/block/null_blk/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/block/null_blk/main.c b/drivers/block/null_blk/main.c
>index 91642c9a3b29..f982027e8c85 100644
>--- a/drivers/block/null_blk/main.c
>+++ b/drivers/block/null_blk/main.c
>@@ -223,7 +223,7 @@ MODULE_PARM_DESC(discard, "Support discard operations (requires memory-backed nu
> 
> static unsigned long g_cache_size;
> module_param_named(cache_size, g_cache_size, ulong, 0444);
>-MODULE_PARM_DESC(mbps, "Cache size in MiB for memory-backed device. Default: 0 (none)");
>+MODULE_PARM_DESC(cache_size, "Cache size in MiB for memory-backed device. Default: 0 (none)");
> 
> static bool g_fua = true;
> module_param_named(fua, g_fua, bool, 0444);
>-- 
>2.25.1

Changes in v2:
 - Adjusted the patch title.
 - Removed redundant blank lines.
 - Link to v1: https://lore.kernel.org/all/30445c6a.6920.198acef8f24.Coremail.zhanggenjian@126.com/

Gentle ping.

Thanks
-Genjian


  reply	other threads:[~2025-09-08  9:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-15  9:07 [PATCH " Genjian
2025-09-08  9:58 ` genjian zhang [this message]
2025-09-08 14:07 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2baa9d5f.86c7.19928c331e3.Coremail.zhanggenjian@126.com \
    --to=zhanggenjian@126.com \
    --cc=axboe@kernel.dk \
    --cc=dlemoal@kernel.org \
    --cc=johannes.thumshirn@wdc.com \
    --cc=kch@nvidia.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namcao@linutronix.de \
    --cc=shinichiro.kawasaki@wdc.com \
    --cc=vincent.fu@samsung.com \
    --cc=willy@infradead.org \
    --cc=zhanggenjian@kylinos.cn \
    --cc=zhengqixing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®