From: Mikko Perttunen <cyndis@kapsi.fi>
To: Aapo Vienamo <avienamo@nvidia.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Mikko Perttunen <mperttunen@nvidia.com>
Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/7] arm64: dts: tegra210-p2180: Allow ldo2 to go down to 1.8 V
Date: Wed, 25 Jul 2018 09:50:59 +0300 [thread overview]
Message-ID: <2bb6f4a6-5f5d-0ab6-ae62-169bd03739ca@kapsi.fi> (raw)
In-Reply-To: <1532090746-15863-6-git-send-email-avienamo@nvidia.com>
Reviewed-by: Mikko Perttunen <mperttunen@nvidia.com>
On 20.07.2018 15:45, Aapo Vienamo wrote:
> Set regulator-min-microvolt property of ldo2 to 1.8 V in
> tegra210-p2180.dtsi. ldo2 is used by the sdmmc1 SDHCI controller and its
> voltage needs to be adjusted down to 1.8 V to support faster signaling
> modes. It appears that the comment about the SDHCI driver requesting
> invalid voltages no longer applies.
>
> Signed-off-by: Aapo Vienamo <avienamo@nvidia.com>
> ---
> arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi b/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi
> index 212e663..8496101 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi
> @@ -178,16 +178,7 @@
>
> vddio_sdmmc: ldo2 {
> regulator-name = "VDDIO_SDMMC";
> - /*
> - * Technically this supply should have
> - * a supported range from 1.8 - 3.3 V.
> - * However, that would cause the SDHCI
> - * driver to request 2.7 V upon access
> - * and that in turn will cause traffic
> - * to be broken. Leave it at 3.3 V for
> - * now.
> - */
> - regulator-min-microvolt = <3300000>;
> + regulator-min-microvolt = <1800000>;
> regulator-max-microvolt = <3300000>;
> regulator-always-on;
> regulator-boot-on;
>
next prev parent reply other threads:[~2018-07-25 6:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-20 12:45 [PATCH 0/7] Tegra SDHCI enable 1.8 V signaling on Tegar210 and Tegra186 Aapo Vienamo
2018-07-20 12:45 ` [PATCH 1/7] dt-bindings: Document Tegra SDHCI pinctrl bindings Aapo Vienamo
2018-07-25 6:47 ` Mikko Perttunen
2018-07-20 12:45 ` [PATCH 2/7] mmc: tegra: Reconfigure pad voltages during voltage switching Aapo Vienamo
2018-07-25 6:41 ` Mikko Perttunen
2018-07-25 8:35 ` Aapo Vienamo
2018-07-20 12:45 ` [PATCH 3/7] arm64: dts: Add Tegra210 sdmmc pinctrl voltage states Aapo Vienamo
2018-07-21 0:14 ` kbuild test robot
2018-07-25 6:49 ` Mikko Perttunen
2018-07-20 12:45 ` [PATCH 4/7] arm64: dts: Add Tegra186 " Aapo Vienamo
2018-07-21 1:29 ` kbuild test robot
2018-07-25 6:50 ` Mikko Perttunen
2018-07-20 12:45 ` [PATCH 5/7] arm64: dts: tegra210-p2180: Allow ldo2 to go down to 1.8 V Aapo Vienamo
2018-07-25 6:50 ` Mikko Perttunen [this message]
2018-07-20 12:45 ` [PATCH 6/7] arm64: dts: tegra210-p2180: Correct sdmmc4 vqmmc-supply Aapo Vienamo
2018-07-25 6:53 ` Mikko Perttunen
2018-07-20 12:45 ` [PATCH 7/7] arm64: dts: tegra210-p2597: Remove no-1-8-v from sdmmc1 Aapo Vienamo
2018-07-25 6:58 ` Mikko Perttunen
2018-07-25 8:12 ` Aapo Vienamo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2bb6f4a6-5f5d-0ab6-ae62-169bd03739ca@kapsi.fi \
--to=cyndis@kapsi.fi \
--cc=adrian.hunter@intel.com \
--cc=avienamo@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mperttunen@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®