From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D9283EB100 for ; Thu, 18 Jun 2026 10:22:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781778147; cv=none; b=eskKE/JRqaAkNH/xXIGqNgwd/Zkx1dd475yRCUg7E0aUHjvJFKLAQFWCy1aL1seWaIQw76DTkete7BWiC5No7ruVP1i6LYop/DKrj5wov2zbFghVi5rT8gxSbtUjemVMWZbP4gPY/uzawdGYzPIzOWsoLKNF3YhOyEyckZ9lQnM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781778147; c=relaxed/simple; bh=7GQkuyRg+UDBSS/P9xS38Vtou4tB13kaAZH5MkFcybA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gtlVdmkypBnd3KO7v4T89uSdnecE8LvvmbFTqIbPTPgjShY9dRK5zyTHEL/JAluldMDeb/opYH9j0hS6HXpfLc20GvKFBQkIXngyiB5Cx26YMTGwsosT7D9ITlYvdIlHP5gNvoStSlJNcRETxBiaiM0p4/pseBqomqLh8L6wYDg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=OKsp7sSk; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=J+Q3x0ZQ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="OKsp7sSk"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="J+Q3x0ZQ" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65I8Dgex692871 for ; Thu, 18 Jun 2026 10:22:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= WXkzGNHSr32PSEXak0uSnyGttjoeqfrsCE+Fxu+JSt0=; b=OKsp7sSkXt71iqPF MoEK0azKtufcbzTnjKMsKcLZicqHEtdG5zx1cRIMPPWSnhAYfhYFamCRw5UDukQF GC7TqJMHWCdzmCkIQvaqynaXDLENCyXiCaG/CgEBOupPhwwokqXG3TGHWjutST7G qj5UE0hEH3vopXmmS2qyfaOGx+fImd/EjTzA5+vAhbE/26k0eoo25s7ta7c6Y96C hqlSfVjzcJ+vov/bGEh/Wz+Yycxck93O72JlQRQ77EWrkJFmfc3a/Xw7GYlf4yvl yX+V/XKEcwJ3Hc3vRBBNIo3K7iUw6TZZpcHz0vQH63MwTe1hfSyupYG29P1Wr434 QipzZw== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eux2cc31s-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 18 Jun 2026 10:22:19 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-84534f17866so686004b3a.2 for ; Thu, 18 Jun 2026 03:22:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781778138; x=1782382938; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WXkzGNHSr32PSEXak0uSnyGttjoeqfrsCE+Fxu+JSt0=; b=J+Q3x0ZQ2z5hZn3R8ecdMVCj/xVGpem+U6o2DgY9taV9vwt6ywLwAKFrs/i+os/Dad Ds5u4GzYW73Jrx+Dc6QwJtThIB8TK1u0lEr6niZ0K8pOE+3xRPxDvj0pUdFcdtE9wf6f gGibRLnechQu0CASaSWPwV89A+rBYM4Ml3cgWhDPTl8SPiNrfxfMDw4mKVEktTt8gNP6 crCEtnbXBPdi2vTNYQQMzJ5EWbFRcu0MaG/l2qrhSUfG137CA9seTlC4UWuFbrc8oogb SL4CtwxCwjUm0s9txUVDHHEhyF5xFxBDCcEYJlwWza1dXL21+6/7zoZWypYSQy1q0Zoc ADdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781778138; x=1782382938; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WXkzGNHSr32PSEXak0uSnyGttjoeqfrsCE+Fxu+JSt0=; b=nCelbaiFsxnRP3kLloPTPFrNZcjvmxouCiRNj6Rd9z6RWE1i38/Z7aYCh1nZrpExPf pKxwgFgRIMhZ+MQbX7CMmpttmPSA0Qd04+jVVHY+9RhwqMYrimKEZsKtj30sJkZhiq// DVGu0w7Cf7WSu1cnMCurH6hIzzTQoachzkxHlFXW+xCWGorLnEv7r5g0fU6nSwNFfLdg wKyGqc3Y8QA/HRVvXuAHy0oXhVl8NZKUqZWwpyRfl9EzLb7f4rtdkUyB7ILwKSVeqd0B T6yZwRye/mtNMsSNUn299KQttIkM8zcMIHdsRmfpnMDrw9/MDIr9my/x5b7QqW5szXta 82YA== X-Forwarded-Encrypted: i=1; AFNElJ/Fuq2HAUZliSf/YgK5OhBVfpmJbSX2gHdJE+XY9yjgaeg8JTMMsXG9qsGvlkYlYhpO6QT+X/jGSyi4Hns=@vger.kernel.org X-Gm-Message-State: AOJu0YyoP1dWeQA6rrKcaebszisTFYi5jD/dLrf8QKxwbhnW2CCfACzx i2B04Hk4VWen1Zy1htL7DFUEWVFDvz2drtq226B6lltHfx9CBkIXrVs5cX3vtsKt9iiWGU+99aA UcDyxz+UEukZU51e2yUda9oM3mjK68h8LdrGlwH7muNe5GbJUPAJ4kkcZzg9+oAHb5ZI= X-Gm-Gg: AfdE7cnPo/NcP4vY+PStGW9PjC0EXYjB6/LjtGe9DhKAqwLfaeYd6/6zQmoyHOAIMR6 leoCzwCJJB2RjqMACujGqqkO/AcsFh9Jl+U8ryxLkgMn+ymN1SfQEpTMsof7GVtWmXsN3xPFFXi p5+i/DQ4xddhBkEDwjA2iRR9IT/8yxQdXUJ2ytvnT8RVrGjNgtT6+pWfxqB5n+ONsNW0R9rT2Hh hYjflFsIxjHYBqIoFQfBzcdgs3EIi45dIZ+h85QVo563N4VKssqzLTa58OPPYOwOafxBg6IZP6s UL4Pl0C6Uof4q9u0vlfOayx4Q6szHZmc3z+CLHvG+icIRY8sexhd28idf0PhXbJ7KksH09P/UBF +n/qJj52lbQFjy59B/OnhfQw/fJEPPyO0jqHF1EIQ X-Received: by 2002:a05:6a00:4c8e:b0:842:2f09:fde9 with SMTP id d2e1a72fcca58-84541991be6mr2404149b3a.8.1781778138582; Thu, 18 Jun 2026 03:22:18 -0700 (PDT) X-Received: by 2002:a05:6a00:4c8e:b0:842:2f09:fde9 with SMTP id d2e1a72fcca58-84541991be6mr2404097b3a.8.1781778138109; Thu, 18 Jun 2026 03:22:18 -0700 (PDT) Received: from [10.218.7.34] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84535894715sm3890225b3a.11.2026.06.18.03.22.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Jun 2026 03:22:17 -0700 (PDT) Message-ID: <2bbb3b84-45c8-42dd-8e4c-d5aade9889a3@oss.qualcomm.com> Date: Thu, 18 Jun 2026 15:52:10 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] iio: adc: qcom-spmi-adc5-gen3: Share SDAM0 IRQ with ADC_TM auxiliary driver To: Andy Shevchenko Cc: Jonathan Cameron , David Lechner , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Amit Kucheria , Thara Gopinath , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , linux-arm-msm@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Kamal Wadhwa , David Collins , Anjelique Melendez , Neil Armstrong , Stephan Gerhold References: <20260526-gen3_adc_tm-v2-0-702fbac919ac@oss.qualcomm.com> <20260526-gen3_adc_tm-v2-1-702fbac919ac@oss.qualcomm.com> <20260604114630.23ca427a@jic23-huawei> Content-Language: en-US From: Jishnu Prakash In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE4MDA5NiBTYWx0ZWRfX8p87VHz0PAQ3 1zZeL4prruCqL8HOMBzr2l299dwabTt00GqRrbmIUooPfgCelXA3wARkPXldzi77kmZEuyJ/OaU tb63540WNEfuP/XzYnUPidlcZi+l9JuAJJLbJa8z+IsgO3Dxj9LG9aj2g647OuFt7SuWAElEGzs vFWiL5Hlktq38PJMcGEv1HjQVv6b2n26M4pxXsxDPGHmWbyIE9ZPuyAv4yPd6thayPdBlUV0sK3 Y+HLpOVSMhwsSjBfgaCeYKw3TbOArEySK42dq/GejsBZbdNw1JuIjR05ThAEy1QdivNOGlBaVHL 9JD05gYPcdGQDF94B3aSZqHUMrTJteBujAToecsErHD/GuKvTnzOYWWSik9HXzgUJCkUSYV5C5U jQ7dqdazvP++5YFpmzmuz2vc11yco6ic3hUWnmun3RvLtIDJPlT7cFZXv2nYe81aJyICLbPwhtB FSegpJiQXvR3nQxoW/w== X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE4MDA5NiBTYWx0ZWRfX84lT8R1K/iFa Z7KuflReUeEKpQQWsWzjCHlYMiqdEkGIs7Q8CRbEb8nBa/+7O0EGcFI3ZQtpaFoEKlC5lcwvyov SP0qGJNHmsDm4oPc4OB/wW8FQA0/82A= X-Proofpoint-GUID: td225izMkGXcN8BDH40MEXuicOUeYWAM X-Proofpoint-ORIG-GUID: td225izMkGXcN8BDH40MEXuicOUeYWAM X-Authority-Analysis: v=2.4 cv=WN1PmHsR c=1 sm=1 tr=0 ts=6a33c6db cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=QyXUC8HyAAAA:8 a=2FWZ_7yD6c0lXRLnv0MA:9 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-18_01,2026-06-17_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 malwarescore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 spamscore=0 priorityscore=1501 adultscore=0 clxscore=1015 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606180096 Hi Andy, On 6/12/2026 12:23 AM, Andy Shevchenko wrote: > On Thu, Jun 11, 2026 at 04:13:07PM +0530, Jishnu Prakash wrote: >> On 6/4/2026 8:14 PM, Andy Shevchenko wrote: >>> On Thu, Jun 04, 2026 at 11:46:30AM +0100, Jonathan Cameron wrote: >>>> On Wed, 3 Jun 2026 02:35:20 +0300 >>>> Andy Shevchenko wrote: >>>>> On Tue, May 26, 2026 at 04:26:09PM +0530, Jishnu Prakash wrote: > > ... > >>>>>> + ret = devm_request_threaded_irq(dev, adc->dev_data.base[ADC5_GEN3_VADC_SDAM].irq, >>>>>> + NULL, adc5_gen3_isr, IRQF_ONESHOT | IRQF_SHARED, >>>>>> + adc->dev_data.base[ADC5_GEN3_VADC_SDAM].irq_name, >>>>>> + adc); >>>>>> if (ret) >>>>>> return dev_err_probe(dev, ret, >>>>>> "Failed to request SDAM%d irq\n", >>>>> >>>>> Also add a patch to drop this duplicate message. >>>> >>>> There is another thread going on this. It might not be duplicate >>>> if -EPROBE_DEFER is returned. The message won't be printed but it >>>> will be logged for helping debug deferred probe reasons. >>> >>> Yes, and I explained that it is duplicated as long as I understand current >>> code base. >> >> After I checked for Andy's first comment, my understanding was that >> devm_request_threaded_irq would internally call dev_err_probe in case >> of an error, so this dev_err_probe print above would not be needed. > > Correct. > >> Please let me know if it's better to keep or remove this print. > > You already know my position here :-) > >> And if I make the change, shall I add it in a separate patch >> before or after this patch in the next series? > > The rule of thumb is to make sure your series won't do ping-pong type of > changes: when one patch introduces (or moves) some code that is removed or > modified in different way by another patch in the same series. Thanks for confirming, I'll add it after this patch. Thanks, Jishnu > >>>> So maybe we have been a little too energetic in removing these. >>> >>> Or maybe sashiko consumed a bit of LSD :-) >